Bug 1392977 - Review Request: ocid - OCI-based implementation of Kubernetes Container Runtime Interface
Summary: Review Request: ocid - OCI-based implementation of Kubernetes Container Runti...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jan Chaloupka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1393086 1394018 1404732
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-08 15:08 UTC by Lokesh Mandvekar
Modified: 2017-09-19 12:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-19 12:45:49 UTC
Type: ---
jchaloup: fedora-review+


Attachments (Terms of Use)
Godeps,json for deps (3.53 KB, text/plain)
2016-12-15 12:53 UTC, Jan Chaloupka
no flags Details

Description Lokesh Mandvekar 2016-11-08 15:08:33 UTC
Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec
SRPM URL: WIP, not yet :)

Description:
OCI-based implementation of Kubernetes Container Runtime Interface

Fedora Account System Username: lsm5

Comment 1 Lokesh Mandvekar 2016-11-08 15:09:47 UTC
$ sudo dnf builddep ocid.spec
Last metadata expiration check: 0:12:17 ago on Tue Nov  8 09:51:53 2016.
No matching package to install: 'golang(github.com/Microsoft/go-winio)'
No matching package to install: 'golang(github.com/containernetworking/cni/libcni)'
No matching package to install: 'golang(github.com/containernetworking/cni/pkg/invoke)'
No matching package to install: 'golang(github.com/containernetworking/cni/pkg/types)'
No matching package to install: 'golang(github.com/containernetworking/cni/pkg/version)'
No matching package to install: 'golang(github.com/containers/image/directory)'
No matching package to install: 'golang(github.com/containers/image/directory/explicitfilepath)'
No matching package to install: 'golang(github.com/containers/image/docker)'
No matching package to install: 'golang(github.com/containers/image/docker/policyconfiguration)'
No matching package to install: 'golang(github.com/containers/image/image)'
No matching package to install: 'golang(github.com/containers/image/manifest)'
No matching package to install: 'golang(github.com/containers/image/oci/layout)'
No matching package to install: 'golang(github.com/containers/image/openshift)'
No matching package to install: 'golang(github.com/containers/image/transports)'
No matching package to install: 'golang(github.com/containers/image/types)'
No matching package to install: 'golang(github.com/containers/image/version)'
No matching package to install: 'golang(github.com/docker/docker/api/types/blkiodev)'
No matching package to install: 'golang(github.com/docker/docker/api/types/container)'
No matching package to install: 'golang(github.com/docker/docker/api/types/mount)'
No matching package to install: 'golang(github.com/docker/docker/api/types/strslice)'
No matching package to install: 'golang(github.com/docker/docker/api/types/versions)'
No matching package to install: 'golang(github.com/docker/docker/plugin/getter)'
No matching package to install: 'golang(github.com/opencontainers/image-spec/specs-go)'
No matching package to install: 'golang(github.com/opencontainers/image-spec/specs-go/v1)'
No matching package to install: 'golang(github.com/opencontainers/runtime-tools/generate)'
No matching package to install: 'golang(github.com/rajatchopra/ocicni)'
No matching package to install: 'golang(golang.org/x/net/internal/timeseries)'
No matching package to install: 'golang(google.golang.org/grpc/internal)'
No matching package to install: 'golang(k8s.io/kubernetes/pkg/kubelet/api/v1alpha1/runtime)'
No matching package to install: 'golang(k8s.io/kubernetes/pkg/selection)'
No matching package to install: 'golang(k8s.io/kubernetes/pkg/util/homedir)'

Comment 2 Lokesh Mandvekar 2016-12-14 18:29:46 UTC
using bundled deps, since docker/docker is a build dep which itself has bundled deps. The bundled deps have been marked as such in the devel package. 

Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec

When I try to build the rpm, I see this:

RPM build errors:
    Could not open %files file /home/lsm5/repositories/pkgs/reviews/ocid/BUILD/cri-o-c57530eb4769fbc2c91d89e7d5ce48a740f812ee/unit-test-devel.file-list: No such file or directory


No idea why.

Comment 3 Jan Chaloupka 2016-12-15 12:53:56 UTC
Created attachment 1232165 [details]
Godeps,json for deps

Comment 4 Lokesh Mandvekar 2016-12-15 13:35:01 UTC
Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec
Godeps.json: https://lsm5.fedorapeople.org/ocid/Godeps.json

Comment 7 Lokesh Mandvekar 2016-12-15 14:31:34 UTC
Spec URL: https://lsm5.fedorapeople.org/ocid/ocid.spec ..devel disabled.

Comment 8 Jan Chaloupka 2016-12-15 14:39:42 UTC
Given only binaries are built, the spec file conforms to the current packaging guidelines. However, I would recommend to update the spec file with:
- replace make all in %build section with actual commands so the LDFLAGS can be set and %gobuild macro used instead of go command
- partial unbundle the deps (the package depends on kubernetes and docker which are by its nature unbundeable at the moment)
- once the intel issue is fixed (worth openning upstream issue/bz for it), extend the list of supported architectures to all supported
- provide Godeps.json (or its variant) as a part of the devel subpackage once https://github.com/kubernetes-incubator/cri-o/issues/280 is resolved and the devel rpm is built.

Comment 9 Fedora Update System 2016-12-16 08:40:14 UTC
ocid-0-0.3.gitc57530e.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b2562cef01

Comment 10 Fedora Update System 2016-12-16 09:12:34 UTC
ocid-0-0.3.gitc57530e.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e27ec90884

Comment 11 Fedora Update System 2016-12-17 01:37:28 UTC
ocid-0-0.3.gitc57530e.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b2562cef01

Comment 12 Fedora Update System 2016-12-19 20:59:10 UTC
ocid-0-0.3.gitc57530e.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e27ec90884

Comment 13 Fedora Update System 2017-01-03 19:00:36 UTC
ocid-0-0.7.git2e6070f.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-59e06d79d7

Comment 14 Fedora Update System 2017-01-03 19:09:24 UTC
ocid-0-0.7.git2e6070f.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9d15b70db

Comment 15 Fedora Update System 2017-01-04 22:21:49 UTC
ocid-0-0.7.git2e6070f.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b9d15b70db

Comment 16 Fedora Update System 2017-01-04 23:28:49 UTC
ocid-0-0.7.git2e6070f.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-59e06d79d7

Comment 17 Neil Horman 2017-01-16 13:48:27 UTC
lokesh, is it possible to enable ppc64le and aarch64 on this package?

Comment 18 Fedora Update System 2017-01-18 19:47:17 UTC
ocid-0-0.8.git2e6070f.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d4f51b1502

Comment 19 Fedora Update System 2017-01-18 20:28:27 UTC
ocid-0-0.8.git2e6070f.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e3922e19df

Comment 20 Fedora Update System 2017-01-19 07:24:08 UTC
ocid-0-0.8.git2e6070f.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e3922e19df

Comment 21 Fedora Update System 2017-01-19 09:12:32 UTC
ocid-0-0.8.git2e6070f.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d4f51b1502

Comment 22 Lokesh Mandvekar 2017-09-19 12:45:49 UTC
Package retired in favor of cri-o


Note You need to log in before you can comment on or make changes to this bug.