Bug 1392984 - Status card content should not wrap
Summary: Status card content should not wrap
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dashboard
Classification: oVirt
Component: General
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.1.1
: 1.1.0
Assignee: Scott Dickerson
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-08 15:48 UTC by Vojtech Szocs
Modified: 2017-04-21 09:39 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-21 09:39:17 UTC
oVirt Team: UX
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
oourfali: devel_ack+
pstehlik: testing_ack+


Attachments (Terms of Use)
Status card content wrap example (10.30 KB, image/png)
2016-11-08 15:48 UTC, Vojtech Szocs
no flags Details
events count text wraps (5.67 KB, image/png)
2017-02-22 15:42 UTC, Lucie Leistnerova
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 71329 0 master MERGED Adjust content wrapping in aggregate status cards 2017-02-03 13:25:04 UTC
oVirt gerrit 71642 0 ovirt-engine-dashboard-1.1 MERGED Adjust content wrapping in aggregate status cards 2017-02-06 16:41:44 UTC

Description Vojtech Szocs 2016-11-08 15:48:04 UTC
Created attachment 1218602 [details]
Status card content wrap example

Icons and numbers representing objects with different statuses (up, down, warning, etc.) should not wrap to the next line.

This is to keep a consistent inner layout of all status cards.

Please see the attached screenshot for reference.

Comment 1 Scott Dickerson 2016-12-19 19:40:04 UTC
Vojtech - isn't this a restating of BZ 1369550?

We want the status cards, including content, to all be the same height.  The width of the cards are controlled by widths on the card's containers.  

I'd rather see the contents of the card wrap internally and then all of the cards have their internal heights adjusted to match.  That way the widths stay the same.  I can add some styles so the icons don't wrap without their text.  That should help the visuals.

Comment 2 Vojtech Szocs 2017-01-02 12:28:28 UTC
(In reply to Scott Dickerson from comment #1)
> Vojtech - isn't this a restating of BZ 1369550?

This BZ was meant to fix the "uncontrolled wrapping" issue, see the attached screenshot. [The "up" icon is not on the same row as the corresponding "up" text/number.]

If this can be fixed via BZ 1369550, feel free to close this one.

> We want the status cards, including content, to all be the same height.  The
> width of the cards are controlled by widths on the card's containers.  
> 
> I'd rather see the contents of the card wrap internally and then all of the
> cards have their internal heights adjusted to match.  That way the widths
> stay the same.  I can add some styles so the icons don't wrap without their
> text.  That should help the visuals.

As for the wrapping: we either allow it across [icon + number] pairs (aka "controlled wrapping"), or disallow it (to have everything in one row). We should probably ask PatternFly team what's the recommended approach.

As for the same height: please see my comment https://bugzilla.redhat.com/show_bug.cgi?id=1369550#c2

PatternFly status card reference: http://www.patternfly.org/pattern-library/cards/aggregate-status-card/

Comment 3 Scott Dickerson 2017-01-25 05:21:28 UTC
After discussing the issue with Serena in the PatternFly Group, the recommendation is to allow content wrapping, but do not all the icon and count text to break across lines.

BZ1369550 forces all the cards to match title and content height.  Wrapped content looks better when all of the aggregate status card's heights are matched.

Comment 4 Lucie Leistnerova 2017-02-22 15:41:54 UTC
When I resize browser window the icon with count text in events still wraps. See attachment.

tested in ovirt-engine-dashboard-1.1.0-5.el7ev.x86_64

Comment 5 Red Hat Bugzilla Rules Engine 2017-02-22 15:41:58 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Lucie Leistnerova 2017-02-22 15:42:33 UTC
Created attachment 1256507 [details]
events count text wraps

Comment 7 Scott Dickerson 2017-02-22 18:49:32 UTC
Lucie - Can you tell me what browser and version you tested on?  I verified the fix worked on current versions of IE, Chrome and FF.

Comment 8 Lucie Leistnerova 2017-02-23 07:45:35 UTC
Firefox 51.0.1 on Fedora 24, Google Chrome 56.0 doesn't wrap

Comment 9 Lucie Leistnerova 2017-02-23 14:56:15 UTC
Firefox doesn't wrap neither after yum update (no Firefox update) of my Fedora and reboot, so It was about my system.

verified in ovirt-engine-dashboard-1.1.0-5.el7ev.x86_64


Note You need to log in before you can comment on or make changes to this bug.