Bug 1393023 - validation required for git url in Automate->Import/export
Summary: validation required for git url in Automate->Import/export
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.7.0
Assignee: mkanoor
QA Contact: Dmitry Misharov
URL:
Whiteboard: ui:automate
Depends On: 1386254
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-08 17:25 UTC by Satoe Imaishi
Modified: 2017-01-04 13:10 UTC (History)
9 users (show)

Fixed In Version: 5.7.0.11
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1386254
Environment:
Last Closed: 2017-01-04 13:10:26 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0012 0 normal SHIPPED_LIVE CFME 5.7.0 bug fixes and enhancement update 2017-01-04 17:50:36 UTC

Comment 2 CFME Bot 2016-11-08 18:06:04 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/266ab79987b88ff042fc1c35a16f02eccec05c02

commit 266ab79987b88ff042fc1c35a16f02eccec05c02
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Nov 8 11:35:38 2016 -0500
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Tue Nov 8 12:58:17 2016 -0500

    Merge pull request #12186 from mkanoor/bugzilla_1386254
    
    Handle errors during git repository fetch
    (cherry picked from commit eff224bf9647ff7a5e8531e6b61fac48cf6b1603)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1393023

 app/controllers/miq_ae_tools_controller.rb       | 68 +++++++++++++-----------
 spec/controllers/miq_ae_tools_controller_spec.rb | 64 ++++++++++++++--------
 2 files changed, 80 insertions(+), 52 deletions(-)

Comment 3 Dmitry Misharov 2016-11-10 14:07:42 UTC
Infinite spinner is occurred if the address doesn't start with "http://".

Comment 4 CFME Bot 2016-11-11 18:46:20 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/85b508cbf642428317cc5e125f3398031baaf57c

commit 85b508cbf642428317cc5e125f3398031baaf57c
Author:     Greg McCullough <gmccullo>
AuthorDate: Fri Nov 11 08:41:18 2016 -0500
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Fri Nov 11 13:43:24 2016 -0500

    Merge pull request #12566 from mkanoor/bugzilla_1393023_round2
    
    Fixed a bug when the URL doesn't have a path component
    (cherry picked from commit 365ff11285cca7c970567d71f9f30ec2881a20cc)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1393023

 app/controllers/miq_ae_tools_controller.rb | 2 +-
 app/models/git_repository.rb               | 7 +++++++
 spec/models/git_repository_spec.rb         | 4 ++++
 3 files changed, 12 insertions(+), 1 deletion(-)

Comment 5 Dmitry Misharov 2016-11-16 09:18:13 UTC
Verified in 5.7.0.11-rc1.20161115160629_46cf4f1. Git repository address validation works fine.

Comment 7 errata-xmlrpc 2017-01-04 13:10:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0012.html


Note You need to log in before you can comment on or make changes to this bug.