Bug 1393451 - vm provisioning "hide deprecated checkbox" doesnt clear list on change
Summary: vm provisioning "hide deprecated checkbox" doesnt clear list on change
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.8.0
Assignee: Brian McLaughlin
QA Contact: Ronny Pfannschmidt
URL:
Whiteboard: vm:provision
Depends On:
Blocks: 1395850
TreeView+ depends on / blocked
 
Reported: 2016-11-09 15:12 UTC by Ronny Pfannschmidt
Modified: 2017-06-12 17:15 UTC (History)
9 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1395850 (view as bug list)
Environment:
Last Closed: 2017-06-12 17:15:59 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Ronny Pfannschmidt 2016-11-09 15:12:53 UTC
Description of problem:

when provisioning a vm, at the select template step,
repeatedly checking/unchecking the "hide deprecated" checkbox
keeps extending the list of templates without clearing it first

happens on 5.7

Comment 2 Greg McCullough 2016-11-09 15:25:13 UTC
Feature added in PR https://bugzilla.redhat.com/show_bug.cgi?id=1393451.

Comment 3 Greg McCullough 2016-11-09 15:40:06 UTC
(In reply to Greg McCullough from comment #2)
> Feature added in PR https://bugzilla.redhat.com/show_bug.cgi?id=1393451.

Actual PR link: https://github.com/ManageIQ/manageiq/pull/11896

Comment 5 Ronny Pfannschmidt 2016-11-15 10:14:23 UTC
noticed a change in behavior on cfme_57010-beta3_161109 - it new shows all templates in all cases

im providing access to a appliance to demonstrate vie email

Comment 6 Harpreet Kataria 2016-11-15 15:07:51 UTC
https://github.com/ManageIQ/manageiq/pull/12646

Comment 7 CFME Bot 2016-11-16 17:16:35 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/40619ae47c18d5b60325b392ed7aeda3d3a6a390

commit 40619ae47c18d5b60325b392ed7aeda3d3a6a390
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Nov 15 10:03:10 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Nov 16 10:34:46 2016 -0500

    Display value of deprecated column in provisioning grids.
    
    Not displaying value when deprectaed column value is nil is causing confusuion on screen, it is difficult to tell if grid results were changed when Hode Deprectaed  checkbox is checked/unchecked
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1393451

 app/views/miq_request/_pre_prov.html.haml             | 2 +-
 app/views/miq_request/_prov_vm_grid.html.haml         | 4 +++-
 spec/views/miq_request/_prov_vm_grid.html.erb_spec.rb | 1 +
 3 files changed, 5 insertions(+), 2 deletions(-)

Comment 8 CFME Bot 2016-11-16 17:51:10 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/0cca60cca9f656bab4929c338196659b357694ed

commit 0cca60cca9f656bab4929c338196659b357694ed
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Wed Nov 16 18:11:46 2016 +0100
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Wed Nov 16 12:47:29 2016 -0500

    Merge pull request #12646 from h-kataria/hide_deprecated_show_value
    
    Display value of 'Deprecated' column in provisioning grids.
    (cherry picked from commit 50b1b63fa93ec384c6b5d742dcae67242dcf5802)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1393451

 app/views/miq_request/_pre_prov.html.haml             | 2 +-
 app/views/miq_request/_prov_vm_grid.html.haml         | 4 +++-
 spec/views/miq_request/_prov_vm_grid.html.erb_spec.rb | 1 +
 3 files changed, 5 insertions(+), 2 deletions(-)

Comment 11 Harpreet Kataria 2017-03-29 20:15:04 UTC
Brian,
Can you please take a look, see if you can recreate this issue, I was not able to recreate on upstream master and PR to fix this issue originally was backported to EUWE. Let me know what you find.

Thanks,
~Harpreet

Comment 12 Brian McLaughlin 2017-03-30 21:20:08 UTC
Harpreet,

I have not been able to recreate the issue as described in upstream master or the latest cut of EUWE.


Brian


Note You need to log in before you can comment on or make changes to this bug.