VirtualBMC is a proxy that translates IPMI commands to libvirt calls. This allows projects such as OpenStack Ironic to test IPMI drivers using VMs. Spec file: https://raw.githubusercontent.com/umago/virtualbmc-spec/rpm-master/python-virtualbmc.spec SRPM: file: https://github.com/umago/virtualbmc-spec/raw/rpm-master/python-virtualbmc-0.1.1-0.20160902100346.f3c05f9.el7.centos.src.rpm Upstream repository: https://github.com/openstack/virtualbmc Pypi: https://pypi.python.org/pypi/virtualbmc
Raising severity, as without this package we won't be able to provide alternative to the deprecated pxe_ssh driver for virtual testing. The spec looks good at first glance.
$ licensecheck -r . ./virtualbmc/vbmc.py: *No copyright* Apache (v2.0) ./virtualbmc/utils.py: *No copyright* Apache (v2.0) ./virtualbmc/tests/unit/utils.py: Apache (v2.0) ./virtualbmc/tests/unit/test_vbmc.py: Apache (v2.0) ./virtualbmc/tests/unit/test_utils.py: Apache (v2.0) ./virtualbmc/tests/unit/test_manager.py: Apache (v2.0) ./virtualbmc/tests/unit/test_config.py: Apache (v2.0) ./virtualbmc/tests/unit/cmd/test_vbmc.py: Apache (v2.0) ./virtualbmc/tests/unit/base.py: Apache (v2.0) ./virtualbmc/manager.py: *No copyright* Apache (v2.0) ./virtualbmc/log.py: *No copyright* Apache (v2.0) ./virtualbmc/exception.py: *No copyright* Apache (v2.0) ./virtualbmc/config.py: *No copyright* Apache (v2.0) ./virtualbmc/cmd/vbmc.py: *No copyright* Apache (v2.0) ./virtualbmc/__init__.py: *No copyright* Apache (v2.0) ./setup.py: Apache (v2.0) GENERATED FILE ./doc/source/conf.py: Apache (v2.0) ./LICENSE: *No copyright* GENERATED FILE License-wise, it looks ok (ASL 2.0). A couple quick comments: - I'm missing doc generation in the spec - Does virtualbmc support Python 3? If so, it would be nice to have a python3 subpackage. Can you start with steps 2 and 3 from https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk so we can iron out any spec details?
python3 is enabled upstream and python3 is likely to be enabled in RDO P or Q.
Thanks for the review folks, the new version of the .spec and SRPM are: SPEC: https://github.com/umago/virtualbmc-spec/raw/rpm-master/python-virtualbmc.spec SRPM: https://github.com/umago/virtualbmc-spec/raw/rpm-master/python-virtualbmc-0.1.1-0.20161115150838.89345c6.el7.centos.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 7 files have unknown license. Detailed output of licensecheck in /tmp/review-python-virtualbmc/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://tarballs.openstack.org/virtualbmc/virtualbmc-0.1.1.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-virtualbmc , python2-virtualbmc-tests , python-virtualbmc-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python2-virtualbmc-0.1.1-0.20161115150838.89345c6.fc23.noarch.rpm python2-virtualbmc-tests-0.1.1-0.20161115150838.89345c6.fc23.noarch.rpm python-virtualbmc-doc-0.1.1-0.20161115150838.89345c6.fc23.noarch.rpm python-virtualbmc-0.1.1-0.20161115150838.89345c6.fc23.src.rpm python2-virtualbmc.noarch: E: no-changelogname-tag python2-virtualbmc.noarch: W: no-documentation python2-virtualbmc.noarch: W: no-manual-page-for-binary vbmc python2-virtualbmc-tests.noarch: E: no-changelogname-tag python2-virtualbmc-tests.noarch: W: no-documentation python-virtualbmc-doc.noarch: E: no-changelogname-tag python-virtualbmc-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-virtualbmc-doc/html/.buildinfo python-virtualbmc.src: E: no-changelogname-tag python-virtualbmc.src: W: invalid-url Source0: virtualbmc-0.1.1.dev3-0.20161115150838.89345c6.tar.gz 4 packages and 0 specfiles checked; 4 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- python-virtualbmc-doc.noarch: E: no-changelogname-tag python-virtualbmc-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-virtualbmc-doc/html/.buildinfo python2-virtualbmc-tests.noarch: E: no-changelogname-tag python2-virtualbmc-tests.noarch: W: no-documentation python2-virtualbmc.noarch: E: no-changelogname-tag python2-virtualbmc.noarch: W: no-documentation python2-virtualbmc.noarch: W: no-manual-page-for-binary vbmc 3 packages and 0 specfiles checked; 3 errors, 4 warnings. Diff spec file in url and in SRPM --------------------------------- --- /tmp/python-virtualbmc.spec 2016-11-15 17:36:38.244247861 +0100 +++ /tmp/review-python-virtualbmc/srpm-unpacked/python-virtualbmc.spec 2016-11-15 16:08:38.000000000 +0100 @@ -1,2 +1,4 @@ +%global dlrn 1 +%define upstream_version 0.1.1.dev3 %{!?upstream_version: %global upstream_version %{version}%{?milestone}} @@ -8,10 +10,10 @@ Name: python-%{sname} Version: 0.1.1 -Release: 0.20161115112629.89345c6%{?dist} +Release: 0.20161115150838.89345c6%{?dist} Summary: A virtual BMC for controlling virtual machines using IPMI commands License: ASL 2.0 URL: http://launchpad.net/%{sname}/ -Source0: http://tarballs.openstack.org/%{sname}/%{sname}-%{upstream_version}.tar.gz +Source0: virtualbmc-0.1.1.dev3-0.20161115150838.89345c6.tar.gz BuildArch: noarch @@ -152,4 +154,2 @@ %changelog -* Tue Nov 15 2016 Lucas Alvares Gomes <lucasagomes> 0.1.0-1 -- Initial package. Requires -------- python-virtualbmc-doc (rpmlib, GLIBC filtered): python2-virtualbmc-tests (rpmlib, GLIBC filtered): python(abi) python2-virtualbmc python2-virtualbmc (rpmlib, GLIBC filtered): /usr/bin/python2 libvirt-python python(abi) python-pbr python-prettytable python-pyghmi python-six shadow-utils Provides -------- python-virtualbmc-doc: python-virtualbmc-doc python2-virtualbmc-tests: python2-virtualbmc-tests python2-virtualbmc: python-virtualbmc python2-virtualbmc Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n python-virtualbmc Buildroot used: fedora-23-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 The Source0 URL and diffs between the spec file and the one included in the SRPM are expected, because it is an SRPM generated by DLRN. The package is APPROVED, please go ahead with step 4 from https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk
This landed so closing.