Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1393524 - hammer os: unify --description vs. --title for its subcommands
Summary: hammer os: unify --description vs. --title for its subcommands
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Hammer
Version: 6.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: Unspecified
Assignee: Swapnil Abnave
QA Contact: Lukas Pramuk
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-09 18:19 UTC by Lukas Pramuk
Modified: 2018-09-04 17:43 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-04 17:43:30 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
explain-title-description-confusion (168.91 KB, image/png)
2017-03-16 15:34 UTC, Swapnil Abnave
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 17304 0 None None None 2016-11-10 09:22:23 UTC

Description Lukas Pramuk 2016-11-09 18:19:38 UTC
Description of problem:
Upon os creation we refer to an entity as '--description' and then upon os update/info/deletion we refer to the very same entity as '--title'

Version-Release number of selected component (if applicable):
Sat6.3.0 Snap6

Steps to Reproduce:
1. # hammer os create --name RedHat --description 'RHEL Server 7.3' --major 7 --minor 3 --media 'Internal RHEL'

2. # hammer os update --title 'RHEL Server 7.3' --media 'Internal RHEL'

3. # hammer os info --title 'RHEL Server 7.3'

4. # hammer os delete --title 'RHEL Server 7.3'

Actual results:
create expects --description VS. update/info/delete expect --title

Expected results:
all subcommands expects the same (preferably --title as --description is only one exception to the rule)

Comment 2 Tomas Strachota 2016-11-10 10:11:53 UTC
Even though they're tied together, description and title aren't the same thing. We use --title as an identifier for operating systems. By default it's "<name> <major>.<minor>". If user sets a description, we use it's shortened version for title.
You can also notice that the update command has both --title (identifier) and --description (value setter). This approach is consistent with the UI.
 
I understand that it might not be 100% intuitive and from user's perspective it's just title with some default value. Unifying them could be a good step, but we must do it in both UI and CLI for the sake of consistency.

I'm asking our UX expert Roxanne to decide here. If she agrees it's worth changing, I'll open one more bug for the UI counterpart. Otherwise I think we should close this as notabug.

Comment 3 Lukas Pramuk 2016-11-11 13:08:03 UTC
I know that if I omit --description upon os creation then the title is "<name> <major>.<minor>" That's the automatic title, and I can override it with my own if I want to.

But still the option can be named --title (instead of --description)

Comment 4 Lukas Pramuk 2016-11-11 13:13:42 UTC
I can have title empty and then is generated out of required fields.
Even @UI the field can be named Title instead of Description (for the sake of consistency).

Comment 5 Roxanne Hoover 2016-11-11 15:49:04 UTC
If I override the title and I provide a description does that then override the title?

Are you asking whether we should get rid of description... is there a need for it?

Comment 6 Tomas Strachota 2016-11-14 09:56:08 UTC
In fact the title field isn't exposed to users for editing at all. You can only enter description, which then overrides the title. If no description is provided, title is generated automatically.

I don't think the description is used for anything else but generating the title. Both fields are searchable, but there's probably not much benefit in searching for OSs that have certain title but no description.

So I'm asking whether you see any benefit in the current state (having two terms "description" and "title") or whether you think it's better to unify them into one.

Comment 7 Roxanne Hoover 2016-11-29 15:36:05 UTC
Since one isn't editable and is generated from the other I vote for unification.

Comment 8 Bryan Kearney 2017-03-06 22:40:50 UTC
Swapnil, you marked upstream as needing more info. Do you have what you need?

Comment 9 Swapnil Abnave 2017-03-16 10:01:44 UTC
Questions for @tomas @lukas (basically summing up my understanding)

1. HammerCLI - create/update/info/delete : --title would be the only option available and not --description?
2. UI - `Description` should be replaced by `Title`? - (If yes, I'll create a new BZ for this)
3. 'Description' won't be updated in any of the above cases?
4. Should the 'description' field/column be removed from `operatingsystem` table(or deprecate now and remove later)?
5. Are we sure about the fact that 'description' never gets updated independently and doesn't have an assertive role?

Comment 10 Tomas Strachota 2017-03-16 11:51:31 UTC
Hi Swapnil

Ad 1.
Yes, --title everywhere, no --description. Plus the update command would need to have --new-title

Ad 2.
Yes, it should be replaced with Title.

Ad 3 and 4.
Description column should be removed from db.

Ad 5.
Descriptions are currently searchable independently of titles. Also API returns them as a separate fields. Other than that they aren't really exposed anywhere and they serve only as a source for the title (which is description shortened to 255 characters). So the current value of keeping them both is very little.

Comment 11 Satellite Program 2017-03-16 14:12:48 UTC
Upstream bug assigned to sabnave

Comment 12 Satellite Program 2017-03-16 14:12:52 UTC
Upstream bug assigned to sabnave

Comment 13 Swapnil Abnave 2017-03-16 15:34:50 UTC
Created attachment 1263738 [details]
explain-title-description-confusion

I am reverting this BZ status to NEW. Need to discuss with the owner of OS feature, removing 'description' would be an acceptable option or not.

As I see that 'Description' and 'Title' is creating lots of confusion between 3 realms: API | Web-UI | HammerCLI

API:
create and update API uses 'Description'

Web-UI:
While creating OS, 'Description' is offered to enter. Later copied to 'Title' and shown in the list(index) as 'Title'.

HammerCLI:
As Lukas described: https://bugzilla.redhat.com/show_bug.cgi?id=1393524#c0
Adding to it. hammer list shows the header as 'TITLE'
See attached image to get the whole idea.

Comment 14 Satellite Program 2017-03-16 16:12:26 UTC
Upstream bug assigned to sabnave

Comment 17 Satellite Program 2018-03-20 00:15:35 UTC
Upstream bug assigned to sabnave

Comment 18 Bryan Kearney 2018-09-04 17:43:30 UTC
Thank you for your interest in Satellite 6. We have evaluated this request, and we do not expect this to be implemented in the product in the foreseeable future. We are therefore closing this out as WONTFIX. If you have any concerns about this, please feel free to contact Rich Jerrido or Bryan Kearney. Thank you.


Note You need to log in before you can comment on or make changes to this bug.