Bug 1393818 - Incorrect summary of Docker repo being added
Summary: Incorrect summary of Docker repo being added
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Update Infrastructure for Cloud Providers
Classification: Red Hat
Component: Tools
Version: 3.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: bizhang
QA Contact: Radek Bíba
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-10 12:02 UTC by Radek Bíba
Modified: 2017-03-01 22:13 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-01 22:13:47 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0367 0 normal SHIPPED_LIVE Red Hat Update Infrastructure 3.0 Release 2017-03-02 03:05:22 UTC

Description Radek Bíba 2016-11-10 12:02:32 UTC
Description of problem:
The summary that asks you to review and confirm the information about a newly added Docker repo contains the display name twice, and the ID isn't shown.

Version-Release number of selected component (if applicable):
rh-rhui-tools-pre.3.0.24-1.el7ui (RHUI 3 ISO 20161109). I didn't run RHUI with the RHEL 6 ISO, but I see the same source code in rh-rhui-tools-libs-pre.3.0.24-1.el6ui, so RHEL 6 must be affected, too.

How reproducible:
Always

Steps to Reproduce:
1. Run rhui-manager and add a Docker repo.

Actual results:
The summary looks strange in that the display name is shown as the container ID. See here:

====
rhui (repo) => ad

Unique ID for the container (alphanumerics, _, and - only):
redhat-cert_docker

Name of the container in the registry: [redhat-cert_docker]:
rhcertification/redhat-certification

Display name for the container: [redhat-cert_docker]:
Red Hat Certification (Docker)

The following container will be added:
  Container Id:              Red Hat Certification (Docker)
  Display Name:              Red Hat Certification (Docker)
  Upstream Container Name:   rhcertification/redhat-certification
Proceed? (y/n)
====

Expected results:
The unique name is displayed.

I see the following piece of code in /usr/lib/python2.7/site-packages/rhui/tools/screens/repo.py, lines 249-253:

====
        # Confirmation
        self.prompt.write('The following container will be added:')
        self.prompt.write('  Container Id:              %s' % name)
        self.prompt.write('  Display Name:              %s' % name)
        self.prompt.write('  Upstream Container Name:   %s' % upstream_name)
====

If I replace 'name' with 'id' on the 'Container Id' line, I get the expected summary:

====
The following container will be added:
  Container Id:              redhat-cert_docker
  Display Name:              Red Hat Certification (Docker)
  Upstream Container Name:   rhcertification/redhat-certification
====

Comment 2 Radek Bíba 2016-11-16 09:46:41 UTC
Verified, thanks!

------------------------------------------------------------------------------
rhui (repo) => ad

Name of the container in the registry: 
dotnet/dotnetcore-10-rhel7

Unique ID for the container (alphanumerics, _, and - only): [dotnet_dotnetcore-10-rhel7]


Display name for the container: [dotnet_dotnetcore-10-rhel7]:
.NET Core 1.0 for RHEL

The following container will be added:
  Container Id:              dotnet_dotnetcore-10-rhel7
  Display Name:              .NET Core 1.0 for RHEL
  Upstream Container Name:   dotnet/dotnetcore-10-rhel7
Proceed? (y/n) y

Successfully added container .NET Core 1.0 for RHEL

------------------------------------------------------------------------------

Comment 3 errata-xmlrpc 2017-03-01 22:13:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0367


Note You need to log in before you can comment on or make changes to this bug.