Spec URL: https://rcritten.fedorapeople.org/novajoin.spec SRPM URL: https://rcritten.fedorapeople.org/novajoin-1.0.7-1.fc23.src.rpm Description: A nova vendordata plugin for the OpenStack nova metadata service to manage host instantiation in an IPA server. Fedora Account System Username: rcritten
Depends on Nova which was retired in Fedora, moving to RDO.
Please rename SRPM: Name: novajoin should be Name: python-novajoin empty top-level package packages makes no sense, unless you wanted to put systemd services there? In that case use Name: openstack-novajoin and check example spec for services https://github.com/openstack-packages/openstack-example-spec/blob/master/openstack-example.spec
Spec URL: https://rcritten.fedorapeople.org/python-novajoin.spec SRPM URL: https://rcritten.fedorapeople.org/python-novajoin-1.0.7-1.fc23.src.rpm
$ licensecheck -r . ./tools/lintstack.sh: Apache (v2.0) ./tools/lintstack.py: Apache (v2.0) ./tools/check_exec.py: *No copyright* Apache (v2.0) ./setup.py: Apache (v2.0) ./scripts/novajoin-server: Apache (v2.0) ./scripts/novajoin-notify: Apache (v2.0) ./scripts/novajoin-ipa-setup: *No copyright* UNKNOWN ./scripts/novajoin-install: Apache (v2.0) ./pylintrc: *No copyright* UNKNOWN ./novajoin/wsgi.py: Apache (v2.0) ./novajoin/tests/unit/test_service.py: Apache (v2.0) ./novajoin/tests/unit/fake_constants.py: *No copyright* UNKNOWN ./novajoin/tests/unit/api/v1/test_api.py: Apache (v2.0) ./novajoin/tests/unit/api/fakes.py: Apache (v2.0) ./novajoin/tests/unit/__init__.py: Apache (v2.0) ./novajoin/test.py: Apache (v2.0) ./novajoin/policy.py: Apache (v2.0) ./novajoin/notifications.py: Apache (v2.0) ./novajoin/middleware/auth.py: Apache (v2.0) ./novajoin/middleware.py: Apache (v2.0) ./novajoin/keystone_client.py: Apache (v2.0) ./novajoin/join.py: Apache (v2.0) ./novajoin/ipa.py: Apache (v2.0) ./novajoin/glance.py: Apache (v2.0) ./novajoin/exception.py: Apache (v2.0) ./novajoin/errors.py: Apache (v2.0) ./novajoin/context.py: Apache (v2.0) ./novajoin/configure_ipa.py: Apache (v2.0) ./novajoin/config.py: Apache (v2.0) ./novajoin/base.py: Apache (v2.0) ./doc/source/conf.py: Apache (v2.0) ./README.md: Apache (v2.0) GENERATED FILE ./Makefile: *No copyright* UNKNOWN ./LICENSE: *No copyright* GENERATED FILE This project is using an Apache 2.0 License.
Spec URL: https://rcritten.fedorapeople.org/python-novajoin.spec SRPM URL: https://rcritten.fedorapeople.org/python-novajoin-1.0.10-1.fc23.src.rpm
This is the finally approved version in https://review.rdoproject.org/r/#/c/4143/: Spec URL: https://raw.githubusercontent.com/rdo-packages/novajoin-distgit/5c8519cf369fbb7717dcd83119c0f8e351dd78c2/python-novajoin.spec SRPM URL: http://46.231.132.68:8080/v1/AUTH_b50e80d3969f441a8b7b1fe831003e0a/rdoartifacts/43/4143/13/check/DLRN-rpmbuild/Zac03761b2e8147b785532e78c6ee3fba/artifacts/centos/repos/aa/f8/aaf832f0ab55cbd9600def187876aa7512624ce2_dev/python-novajoin-1.0.11-0.20161222210723.aaf832f.el7.centos.src.rpm Note spec is for delorean so both version and release are XXX.
Reviewed in https://review.rdoproject.org/r/4143 formal fedora-review report coming...
Here's formal report from package built in RDO Ocata repository. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3153920 bytes in 46 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation => WAIVED ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 26 files have unknown license. Detailed output of licensecheck in /home/hguemar/dist-git-fedora/mozjs45/python-novajoin /review-python-novajoin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package requires other packages for directories it uses. Note: No known owner of /etc/nova [-]: Package must own all directories that it creates. Note: Directories without known owners: /etc/nova, /etc/logrotate.d [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files => I'll fix this [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-novajoin-1.0.11-1.el7.noarch.rpm python-novajoin-tests-unit-1.0.11-1.el7.noarch.rpm python-novajoin-1.0.11-1.el7.src.rpm python-novajoin.noarch: W: spelling-error %description -l en_US vendordata -> vendor data, vendor-data, vendetta python-novajoin.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal python-novajoin.noarch: W: spelling-error %description -l en_US instantiation -> instantiate, substantiation, installation python-novajoin.noarch: E: incoherent-logrotate-file /etc/logrotate.d/novajoin python-novajoin.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/novajoin/configure_ipa.py 644 /usr/bin/python python-novajoin.noarch: E: non-readable /etc/nova/join.conf 640 python-novajoin.noarch: E: non-standard-dir-perm /var/log/novajoin 700 python-novajoin-tests-unit.noarch: W: no-documentation python-novajoin.src: W: spelling-error %description -l en_US vendordata -> vendor data, vendor-data, vendetta python-novajoin.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal python-novajoin.src: W: spelling-error %description -l en_US instantiation -> instantiate, substantiation, installation 3 packages and 0 specfiles checked; 4 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- python-novajoin.noarch: W: invalid-url URL: https://launchpad.net/novajoin <urlopen error [Errno -2] Name or service not known> python-novajoin.noarch: E: non-readable /etc/nova/join.conf 0640L python-novajoin.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/novajoin/configure_ipa.py 0644L /usr/bin/python python-novajoin.noarch: E: incoherent-logrotate-file /etc/logrotate.d/novajoin python-novajoin.noarch: E: non-standard-dir-perm /var/log/novajoin 0700L python-novajoin-tests-unit.noarch: W: invalid-url URL: https://launchpad.net/novajoin <urlopen error [Errno -2] Name or service not known> python-novajoin-tests-unit.noarch: W: no-documentation 2 packages and 0 specfiles checked; 4 errors, 3 warnings. Requires -------- python-novajoin (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python config(python-novajoin) ipa-admintools openstack-nova-common python(abi) python-cinderclient python-glanceclient python-keystoneauth1 python-keystoneclient python-neutronclient python-novaclient python-oslo-concurrency python-oslo-messaging python-oslo-policy python-oslo-serialization python-oslo-service python-oslo-utils python-paste python-routes python-six python-webob systemd python-novajoin-tests-unit (rpmlib, GLIBC filtered): python(abi) python-anyjson python-coverage python-fixtures python-mock python-novajoin python-os-testr python-subunit python-testrepository python-testresources python-testscenarios python-testtools Provides -------- python-novajoin: config(python-novajoin) python-novajoin python-novajoin-tests-unit: python-novajoin-tests-unit Source checksums ---------------- https://tarballs.openstack.org/novajoin/novajoin-1.0.11.tar.gz : CHECKSUM(SHA256) this package : 1a5a0260614884a61fbfe6a8eb2173182aafcafc81a5a4547a2e856f4b1995ad CHECKSUM(SHA256) upstream package : 1a5a0260614884a61fbfe6a8eb2173182aafcafc81a5a4547a2e856f4b1995ad Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n python-novajoin -m rdo-ocata-el7 Buildroot used: cloud7-openstack-ocata-el7-build Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6