Bug 1394281 - Network CRUD actions do not use task queue
Summary: Network CRUD actions do not use task queue
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.8.0
Assignee: Gilles Dubreuil
QA Contact: Omri Hochman
URL:
Whiteboard: openstack:sdn
Depends On:
Blocks: 1405641
TreeView+ depends on / blocked
 
Reported: 2016-11-11 14:55 UTC by Tzu-Mainn Chen
Modified: 2018-06-15 13:57 UTC (History)
7 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1405641 (view as bug list)
Environment:
Last Closed: 2017-06-12 17:16:31 UTC
Category: ---
Cloudforms Team: Openstack
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Tzu-Mainn Chen 2016-11-11 14:55:26 UTC
Network CRUD actions do not use task queue; they should to enable task tracking and consistent logs.

Comment 2 Gilles Dubreuil 2016-11-17 09:25:58 UTC
Addressed with https://github.com/ManageIQ/manageiq/pull/12071

Comment 4 Gilles Dubreuil 2016-12-06 23:11:18 UTC
Update: Master's Pull Request has been merged.
The 5.7.1 (euwe branch) backport to come next.

Comment 8 CFME Bot 2017-01-13 13:10:51 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/0b86cdd06cbb6d621af697f38e06a7ce0156c850

commit 0b86cdd06cbb6d621af697f38e06a7ce0156c850
Author:     Martin Povolny <mpovolny>
AuthorDate: Tue Dec 6 14:44:05 2016 +0100
Commit:     Tzu-Mainn Chen <tzumainn>
CommitDate: Thu Jan 12 03:55:56 2017 +0100

    [EUWE] Cloud Network UI: Task queue, validation, buttons and translation
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1394281
    
    This is an Euwe-only PR to resolve conflicts with:
    
    	app/controllers/cloud_network_controller.rb
    	app/models/manageiq/providers/openstack/network_manager.rb
    
    This PR is equivalent to https://github.com/ManageIQ/manageiq/pull/12071
    on master.

 app/controllers/cloud_network_controller.rb        | 197 ++++++++++-----------
 .../toolbar/cloud_networks_center.rb               |  36 ++--
 app/models/cloud_network.rb                        |  42 +----
 app/models/cloud_network/operations.rb             |  49 -----
 .../providers/openstack/network_manager.rb         |  22 +++
 .../openstack/network_manager/cloud_network.rb     |  96 ++++++----
 config/routes.rb                                   |   1 +
 spec/controllers/cloud_network_controller_spec.rb  | 114 ++++++++----
 ...shared_examples_for_cloud_network_controller.rb |   2 -
 9 files changed, 281 insertions(+), 278 deletions(-)
 delete mode 100644 app/models/cloud_network/operations.rb

Comment 9 Ronnie Rasouli 2017-03-08 07:17:18 UTC
verified on 5.8.0.3


Note You need to log in before you can comment on or make changes to this bug.