Bug 1394282 - Subnet CRUD actions do not use task queue
Summary: Subnet CRUD actions do not use task queue
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.8.0
Assignee: Gilles Dubreuil
QA Contact: Omri Hochman
URL:
Whiteboard: openstack:sdn
Depends On:
Blocks: 1405640
TreeView+ depends on / blocked
 
Reported: 2016-11-11 14:56 UTC by Tzu-Mainn Chen
Modified: 2018-06-15 13:57 UTC (History)
7 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1405640 (view as bug list)
Environment:
Last Closed: 2017-06-12 16:39:17 UTC
Category: ---
Cloudforms Team: Openstack
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Tzu-Mainn Chen 2016-11-11 14:56:44 UTC
Subnet CRUD actions should use task queue for consistent logging and task tracking

Comment 2 Gilles Dubreuil 2016-11-17 09:24:03 UTC
Addressed with https://github.com/ManageIQ/manageiq/pull/12045

Comment 4 Gilles Dubreuil 2016-12-16 00:22:00 UTC
Master PR has been merged. Waiting now for cherry pick backport for euwe branch.

Comment 8 CFME Bot 2017-01-17 13:55:55 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/e049370ddfdf2f4f6dc1d8db7220a74040c510e6

commit e049370ddfdf2f4f6dc1d8db7220a74040c510e6
Author:     Martin Povolny <mpovolny>
AuthorDate: Thu Dec 15 09:43:17 2016 +0100
Commit:     Tzu-Mainn Chen <tzumainn>
CommitDate: Fri Jan 13 20:40:19 2017 +0100

    [EUWE] Cloud Subnet UI: Task queue, validation, buttons
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1394282
    
    This is an Euwe-only commit to resolve conflicts with:
    
    	app/controllers/cloud_subnet_controller.rb
    
    This PR is equvalent to https://github.com/ManageIQ/manageiq/pull/12045 for master

 .../cloud_subnet/cloud_subnet_form_controller.js   |   3 +
 app/controllers/cloud_subnet_controller.rb         | 187 ++++++++++++---------
 .../toolbar/cloud_subnets_center.rb                |  40 ++---
 app/models/cloud_subnet.rb                         |  27 ---
 .../providers/openstack/network_manager.rb         |  23 ++-
 .../openstack/network_manager/cloud_subnet.rb      |  63 ++++---
 app/views/cloud_subnet/_common_new_edit.haml       |  32 ++++
 app/views/cloud_subnet/edit.html.haml              |  34 +---
 app/views/cloud_subnet/new.html.haml               |  45 ++---
 config/routes.rb                                   |   1 +
 spec/controllers/cloud_subnet_controller_spec.rb   | 116 +++++++++----
 11 files changed, 331 insertions(+), 240 deletions(-)
 create mode 100644 app/views/cloud_subnet/_common_new_edit.haml

Comment 9 Ronnie Rasouli 2017-03-08 07:31:40 UTC
verified on 5.8.0.3


Note You need to log in before you can comment on or make changes to this bug.