Bug 1394675 - kubernetes: Only set websocket protocols if we actually have them
Summary: kubernetes: Only set websocket protocols if we actually have them
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 3.3.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Dominik Perpeet
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-14 08:16 UTC by Dominik Perpeet
Modified: 2017-03-08 18:43 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-18 09:51:21 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
log-1 (147.86 KB, image/png)
2016-12-12 09:06 UTC, Yanping Zhang
no flags Details
log-2 (104.77 KB, image/png)
2016-12-12 09:06 UTC, Yanping Zhang
no flags Details
log-3 (128.41 KB, image/png)
2016-12-12 09:07 UTC, Yanping Zhang
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0067 0 normal SHIPPED_LIVE Red Hat OpenShift Container Platform 3.4 Image Release Advisory 2017-01-18 16:59:07 UTC

Description Dominik Perpeet 2016-11-14 08:16:19 UTC
Description of problem:
kubernetes: Only set websocket protocols if we actually have them

Reported upstream in https://github.com/cockpit-project/cockpit/issues/5347

Version-Release number of selected component (if applicable):
122-1 and kubernetes 1.4

How reproducible:
Always

Additional info:
Fixed upstream in a5f781c6bd9ab1256a19648a792a47be79b28e71

Comment 1 Dominik Perpeet 2016-11-14 08:41:52 UTC
Upstream master commit
https://github.com/cockpit-project/cockpit/commit/d220e21d0eb75ca2361d77393d6840167001298b

Comment 2 Stef Walter 2016-11-14 13:45:02 UTC
Changing to OCP product. This doesn't affect Cockpit as released in RHEL ... only the registry container and its use of WebSockets.

Comment 3 Dominik Perpeet 2016-11-23 19:10:54 UTC
Fixed in cockpit 122-3

registry container image:
openshift3/registry-console:3.3-5

Comment 5 Yadan Pei 2016-11-24 08:23:56 UTC
Hi Dominik,

Any instructions on how to check this bug on registry console? The origin issue happens on getting pod container logs but I have no idea how to check on registry console.

Comment 6 Yadan Pei 2016-11-24 08:39:39 UTC
I should check it could get container logs successfully on cockpit web console through https://<master>:9090, right?

Comment 9 Dominik Perpeet 2016-11-24 11:42:29 UTC
Should be an issue with a newer kubernetes version (1.4 as reported upstream), but I'm not sure if this is testable right now. We included the patch because this Cockpit version might be used in newer environments later on.

If the container logs are showing up well for current and maybe newer versions, then this should be good. If you can only test the current version, then it's at least not a regression.

Comment 10 Yadan Pei 2016-11-25 01:45:49 UTC
Target release is set as 3.3.1 but the kubernetes version for 3.3.1 is still in version 1.3(kubernetes v1.3.0+52492b4)

For OCP 3.4, kubernetes version is upgraded to 1.4(kubernetes v1.4.0+776c994), however in OCP 3.4,latest cockpit version is still 122-1

So I guess this could not be tested yet, right?

Comment 11 Yadan Pei 2016-12-01 00:40:44 UTC
Please change to ON_QA when it could be tested

Comment 12 Dominik Perpeet 2016-12-01 08:50:02 UTC
Troy keeps track of which images are rebuilt for testing, but you are correct: This can only be tested with a patched cockpit build (>= 122-3) and kubernetes 1.4.

Comment 14 Troy Dawson 2016-12-01 14:15:05 UTC
Since this needs kubernetes 1.4, and a newer cockpit, I have dropped it from the errata it was on, and changed the release targets.  I am also moving it back to assigned.  When we have an updated cockpit for release Dominik can put it onto Modified and I'll get the image and errata setup.

Comment 15 Yadan Pei 2016-12-05 05:56:13 UTC
Thanks Troy and Dominik

Comment 16 Dominik Perpeet 2016-12-05 15:06:48 UTC
Once we have a 3.4 build with the latest Cockpit, this should be good to be tested.

Comment 17 Troy Dawson 2016-12-05 15:37:55 UTC
I mis-read comment 12.
I'll do a 3.4 build.

Comment 18 Troy Dawson 2016-12-05 17:15:03 UTC
This should now be fixed in image
  openshift3/registry-console:3.4-1

Comment 19 Yadan Pei 2016-12-06 09:20:16 UTC
Checked openshift3/registry-console:3.4-1, it has 122-3 cockpit build

Comment 20 Yadan Pei 2016-12-08 07:39:16 UTC
Will you prepare new OCP 3.4 build with latest cockpit-kubernetes-122-3.el7.x86_64.rpm ?

Comment 21 Troy Dawson 2016-12-08 14:29:24 UTC
The OCP 3.4 build is
  openshift3/registry-console:3.4-1

Comment 23 Yanping Zhang 2016-12-12 09:03:35 UTC
openshift v3.4.0.34+87d9d8d
kubernetes v1.4.0+776c994
etcd 3.1.0-rc.0
openshift3/registry-console:3.4-1
cockpit-shell-122-3.el7.noarch
cockpit-kubernetes-122-1.el7.x86_64
cockpit-bridge-122-3.el7.x86_64
cockpit-docker-122-3.el7.x86_64
cockpit-ws-122-3.el7.x86_64

Test on OCP 3.4 with above version, login on cockpit web console, check containers' logs, no matter proxy is used for browser or not, the containers' logs can be shown normally, attach screenshots for containers' logs.

Didn't find issue during the check, so move the bug to Verified.

Comment 24 Yanping Zhang 2016-12-12 09:06:23 UTC
Created attachment 1230730 [details]
log-1

Comment 25 Yanping Zhang 2016-12-12 09:06:58 UTC
Created attachment 1230731 [details]
log-2

Comment 26 Yanping Zhang 2016-12-12 09:07:33 UTC
Created attachment 1230732 [details]
log-3

Comment 28 errata-xmlrpc 2017-01-18 09:51:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0067


Note You need to log in before you can comment on or make changes to this bug.