RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1394704 - Conditional jump or move depends on uninitialised value in setmntent(3)
Summary: Conditional jump or move depends on uninitialised value in setmntent(3)
Keywords:
Status: CLOSED DUPLICATE of bug 1437147
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: glibc
Version: 6.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: glibc team
QA Contact: qe-baseos-tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-14 09:44 UTC by Branislav Blaškovič
Modified: 2017-04-03 08:42 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-03 08:42:43 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Branislav Blaškovič 2016-11-14 09:44:43 UTC 
Description of problem:
There are errors when running quota via valgrind which were not there in older versions.

Version-Release number of selected component (if applicable):
quota-3.17-23.el6

Steps to Reproduce:
1. Run test /CoreOS/quota/Regression/bz684017-memory-leak

Actual results:
==2504== Conditional jump or move depends on uninitialised value(s)
==2504==    at 0x4EA2849: _IO_file_fopen@@GLIBC_2.2.5 (in /lib64/libc-2.12.so)
==2504==    by 0x4E96D95: __fopen_internal (in /lib64/libc-2.12.so)
==2504==    by 0x4F12C83: setmntent (in /lib64/libc-2.12.so)
==2504==    by 0x11099A: cache_mnt_table (quotasys.c:992)
==2504==    by 0x111221: init_mounts_scan (quotasys.c:1263)
==2504==    by 0x1113F2: create_handle_list (quotasys.c:717)
==2504==    by 0x10B0A4: showquotas (quota.c:132)
==2504==    by 0x10BB6B: main (quota.c:340)
==2504== 
==2504== Conditional jump or move depends on uninitialised value(s)
==2504==    at 0x4EA284F: _IO_file_fopen@@GLIBC_2.2.5 (in /lib64/libc-2.12.so)
==2504==    by 0x4E96D95: __fopen_internal (in /lib64/libc-2.12.so)
==2504==    by 0x4F12C83: setmntent (in /lib64/libc-2.12.so)
==2504==    by 0x11099A: cache_mnt_table (quotasys.c:992)
==2504==    by 0x111221: init_mounts_scan (quotasys.c:1263)
==2504==    by 0x1113F2: create_handle_list (quotasys.c:717)
==2504==    by 0x10B0A4: showquotas (quota.c:132)
==2504==    by 0x10BB6B: main (quota.c:340)
==2504== 
==2504== Conditional jump or move depends on uninitialised value(s)
==2504==    at 0x4EA2854: _IO_file_fopen@@GLIBC_2.2.5 (in /lib64/libc-2.12.so)
==2504==    by 0x4E96D95: __fopen_internal (in /lib64/libc-2.12.so)
==2504==    by 0x4F12C83: setmntent (in /lib64/libc-2.12.so)
==2504==    by 0x11099A: cache_mnt_table (quotasys.c:992)
==2504==    by 0x111221: init_mounts_scan (quotasys.c:1263)
==2504==    by 0x1113F2: create_handle_list (quotasys.c:717)
==2504==    by 0x10B0A4: showquotas (quota.c:132)
==2504==    by 0x10BB6B: main (quota.c:340)
==2504== 
==2504== Conditional jump or move depends on uninitialised value(s)
==2504==    at 0x4EA2860: _IO_file_fopen@@GLIBC_2.2.5 (in /lib64/libc-2.12.so)
==2504==    by 0x4E96D95: __fopen_internal (in /lib64/libc-2.12.so)
==2504==    by 0x4F12C83: setmntent (in /lib64/libc-2.12.so)
==2504==    by 0x11099A: cache_mnt_table (quotasys.c:992)
==2504==    by 0x111221: init_mounts_scan (quotasys.c:1263)
==2504==    by 0x1113F2: create_handle_list (quotasys.c:717)
==2504==    by 0x10B0A4: showquotas (quota.c:132)
==2504==    by 0x10BB6B: main (quota.c:340)
==2504== 
==2504== Conditional jump or move depends on uninitialised value(s)
==2504==    at 0x4EA2868: _IO_file_fopen@@GLIBC_2.2.5 (in /lib64/libc-2.12.so)
==2504==    by 0x4E96D95: __fopen_internal (in /lib64/libc-2.12.so)
==2504==    by 0x4F12C83: setmntent (in /lib64/libc-2.12.so)
==2504==    by 0x11099A: cache_mnt_table (quotasys.c:992)
==2504==    by 0x111221: init_mounts_scan (quotasys.c:1263)
==2504==    by 0x1113F2: create_handle_list (quotasys.c:717)
==2504==    by 0x10B0A4: showquotas (quota.c:132)
==2504==    by 0x10BB6B: main (quota.c:340)
==2504== 
==2504== Conditional jump or move depends on uninitialised value(s)
==2504==    at 0x4EBEA13: __GI_strstr (in /lib64/libc-2.12.so)
==2504==    by 0x4EA29A6: _IO_file_fopen@@GLIBC_2.2.5 (in /lib64/libc-2.12.so)
==2504==    by 0x4E96D95: __fopen_internal (in /lib64/libc-2.12.so)
==2504==    by 0x4F12C83: setmntent (in /lib64/libc-2.12.so)
==2504==    by 0x11099A: cache_mnt_table (quotasys.c:992)
==2504==    by 0x111221: init_mounts_scan (quotasys.c:1263)
==2504==    by 0x1113F2: create_handle_list (quotasys.c:717)
==2504==    by 0x10B0A4: showquotas (quota.c:132)
==2504==    by 0x10BB6B: main (quota.c:340)
==2504== 
Disk quotas for user root (uid 0): none
==2504== 
==2504== HEAP SUMMARY:
==2504==     in use at exit: 2,048 bytes in 1 blocks
==2504==   total heap usage: 181 allocs, 180 frees, 34,065 bytes allocated
==2504== 
==2504== LEAK SUMMARY:
==2504==    definitely lost: 0 bytes in 0 blocks
==2504==    indirectly lost: 0 bytes in 0 blocks
==2504==      possibly lost: 0 bytes in 0 blocks
==2504==    still reachable: 2,048 bytes in 1 blocks
==2504==         suppressed: 0 bytes in 0 blocks
==2504== Reachable blocks (those to which a pointer was found) are not shown.
==2504== To see them, rerun with: --leak-check=full --show-reachable=yes


Expected results:
No errors.
Comment 1 Branislav Blaškovič 2016-11-14 09:46:59 UTC 
It works fine on RHEL-6.8.
Bug is reproducible on RHEL-6.9-20161110.2.

Weird is, that there are the same quota versions, so I assume that the bug could be in glibc maybe?
Comment 2 Petr Pisar 2016-11-14 10:31:32 UTC 
Yes this is an issue in glibc. The quota's code is:

  mntf = setmntent("/proc/mounts", "r");

The mntf is a FILE* pointer.

I can reproduce it with glibc-2.12-1.208.el6.x86_64 and valgrind-3.8.1-8.el6.x86_64 running:

# valgrind quota -f /

There is no need for any file system with enabled or set quotas.
Comment 3 Petr Pisar 2016-11-14 10:35:11 UTC 
C reproducer:

#include <stdlib.h>
#include <stdio.h>
#include <mntent.h>

int main(void) {
        FILE *mntf;
        mntf = setmntent("/proc/mounts", "r");
        if (mntf) {
                endmntent(mntf);
        }
        exit(EXIT_SUCCESS);
}
Comment 8 Florian Weimer 2017-04-03 08:42:43 UTC 

*** This bug has been marked as a duplicate of bug 1437147 ***
Note You need to log in before you can comment on or make changes to this bug.