Red Hat Bugzilla – Bug 139483
asm-x86_64/system.h should do include asm-x86_64/bitops.h
Last modified: 2007-11-30 17:07:05 EST
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922 Description of problem: I just saw the error message which is related this: In file included from /usr/include/asm/system.h:4, from fbdpsp.c:831: /usr/include/asm-x86_64/system.h: In function `__cmpxchg': /usr/include/asm-x86_64/system.h:75: `LOCK_PREFIX' undeclared (first use in this function) /usr/include/asm-x86_64/system.h:75: (Each undeclared identifier is reported only once /usr/include/asm-x86_64/system.h:75: for each function it appears in.) /usr/include/asm-x86_64/system.h:75: syntax error before string constant /usr/include/asm-x86_64/system.h:81: syntax error before string constant /usr/include/asm-x86_64/system.h:87: syntax error before string constant /usr/include/asm-x86_64/system.h:93: syntax error before string constant make: *** [fbdpsp.o] Error 1 Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1.build something including asm/system.h 2. 3. Actual Results: failed to build Expected Results: it should be built completely Additional info: this problem doesn't happen on x86. also, it happens on FC.
There's nothing in system.h which userland has any business with. Why are you including this file at all?
jfbterm - a terminal program to show CJK characters on the framebuffer, has #include <asm/system.h>. and the build fails due to lacking of bitops.h.
Why is it including this file? What happens if you remove the #include <asm/system.h>?
Okay... it looks buildable even without it. Thanks.
Note that the use of bitops.h is likely to be broken and racy. Some time in the not-so-distant future we may well remove this file too. It's kernel-private stuff, and doesn't work properly in userspace.
Sure. thanks again.