1395116 – Snapshot link in vm summary page becomes inactive on deleting a snapshot and viewing its history

Bug 1395116 - Snapshot link in vm summary page becomes inactive on deleting a snapshot and viewing its history

Summary: Snapshot link in vm summary page becomes inactive on deleting a snapshot and ...

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	Red Hat CloudForms Management Engine
Classification:	Red Hat
Component:	UI - OPS
Sub Component:
Version:	5.7.0
Hardware:	Unspecified
OS:	Unspecified
Priority:	high
Severity:	high
Target Milestone:	GA
Target Release:	5.8.0
Assignee:	Brian McLaughlin
QA Contact:	Aziza Karol
Docs Contact:
URL:
Whiteboard:	snapshot
Depends On:
Blocks:	1417763
TreeView+	depends on / blocked

Reported:	2016-11-15 08:26 UTC by Aziza Karol
Modified:	2017-06-12 16:04 UTC (History)
CC List:	6 users (show)
Fixed In Version:	5.8.0.0
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Clones:	1417763 (view as bug list)
Environment:
Last Closed:	2017-06-12 16:04:07 UTC
Category:	---
Cloudforms Team:	---
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)
snapshot (224.89 KB, image/png) 2016-11-15 08:26 UTC, Aziza Karol	no flags	Details
View All

Description Aziza Karol 2016-11-15 08:26:04 UTC

Created attachment 1220712 [details]
snapshot

Description of problem:
Deleting a snapshot and viewing its history make the snapshot link in the vm summary page inactive.

Version-Release number of selected component (if applicable):
5.7.0.10-beta3.20161109111947_9a61b18 

How reproducible:
100%

Steps to Reproduce:
1.Navigate to vm summary page, click on snapshots.
2.create few snapshots and delete on of the snapshot
3.View history link of "snapshot VM xx". see attached screenshot. 
4.Again try to click on snapshot link in vm summary page.

Actual results:
Couldn't find Snapshot Error thrown in production log.Also the snapshot link in vm summary page does not redirect to the snapshot summary page.

Expected results:
no error on deleting the snapshot and clicking on snapshot link should work.


Additional info:
production.log
----] I, [2016-11-15T03:11:20.140850 #2901:16c3904]  INFO -- : Started POST "/vm_infra/show/257?display=snapshot_info" for 127.0.0.1 at 2016-11-15 03:11:20 -0500
[----] I, [2016-11-15T03:11:20.144565 #2901:16c3904]  INFO -- : Processing by VmInfraController#show as JS
[----] I, [2016-11-15T03:11:20.144673 #2901:16c3904]  INFO -- :   Parameters: {"authenticity_token"=>"VTj0V4a3eeS1Bp+VoR/09dK0hzPkPshibJjeVUzwAdgBD4ipjsdyUvqdso66cxx27iHX3zSmh+kl+v8VVplKDw==", "display"=>"snapshot_info", "id"=>"257"}
[----] I, [2016-11-15T03:11:20.244097 #2901:16c3904]  INFO -- :   Rendered layouts/_flash_msg.html.haml (0.1ms)
[----] I, [2016-11-15T03:11:20.249979 #2901:16c3904]  INFO -- :   Rendered vm_common/_snapshots_desc.html.haml (5.6ms)
[----] I, [2016-11-15T03:11:20.250110 #2901:16c3904]  INFO -- :   Rendered vm_common/_config.html.haml (6.3ms)
[----] F, [2016-11-15T03:11:20.250390 #2901:16c3904] FATAL -- : Error caught: [ActionView::Template::Error] Couldn't find Snapshot with 'id'=42
/opt/rh/cfme-gemset/gems/activerecord-5.0.0.1/lib/active_record/core.rb:173:in `find'
/var/www/miq/vmdb/app/views/vm_common/_snapshots_desc.html.haml:5:in `_app_views_vm_common__snapshots_desc_html_haml__3069715456577180745_151702620'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/template.rb:158:in `block in render'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications.rb:166:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/template.rb:348:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/template.rb:156:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/partial_renderer.rb:343:in `render_partial'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/partial_renderer.rb:311:in `block in render'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications.rb:164:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications.rb:164:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/partial_renderer.rb:310:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/renderer.rb:47:in `render_partial'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/renderer.rb:21:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/helpers/rendering_helper.rb:32:in `render'
/var/www/miq/vmdb/app/views/vm_common/_config.html.haml:87:in `_app_views_vm_common__config_html_haml___2433499793002359708_119131760'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/template.rb:158:in `block in render'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications.rb:166:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/template.rb:348:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/template.rb:156:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/partial_renderer.rb:343:in `render_partial'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/partial_renderer.rb:311:in `block in render'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications.rb:164:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications.rb:164:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/partial_renderer.rb:310:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/renderer.rb:47:in `render_partial'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/renderer/renderer.rb:21:in `render'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/rendering.rb:103:in `_render_template'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/streaming.rb:217:in `_render_template'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/rendering.rb:83:in `render_to_body'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/rendering.rb:52:in `render_to_body'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/renderers.rb:144:in `render_to_body'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/abstract_controller/rendering.rb:48:in `render_to_string'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/rendering.rb:41:in `render_to_string'
/var/www/miq/vmdb/app/controllers/vm_common.rb:1414:in `block in replace_right_cell'
/var/www/miq/vmdb/app/controllers/vm_common.rb:1480:in `replace_right_cell'
/var/www/miq/vmdb/app/controllers/vm_common.rb:351:in `show'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/abstract_controller/base.rb:188:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/rendering.rb:30:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:126:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:455:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:101:in `__run_callbacks__'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:90:in `run_callbacks'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/abstract_controller/callbacks.rb:19:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/rescue.rb:20:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications.rb:164:in `block in instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/notifications.rb:164:in `instrument'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal/params_wrapper.rb:248:in `process_action'
/opt/rh/cfme-gemset/gems/activerecord-5.0.0.1/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/abstract_controller/base.rb:126:in `process'
/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/rendering.rb:30:in `process'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal.rb:190:in `dispatch'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_controller/metal.rb:262:in `dispatch'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/routing/route_set.rb:50:in `dispatch'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/routing/route_set.rb:32:in `serve'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/journey/router.rb:39:in `block in serve'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/journey/router.rb:26:in `each'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/journey/router.rb:26:in `serve'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/routing/route_set.rb:725:in `call'
/opt/rh/cfme-gemset/gems/secure_headers-3.0.3/lib/secure_headers/middleware.rb:10:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.1/lib/rack/etag.rb:25:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.1/lib/rack/conditional_get.rb:38:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.1/lib/rack/head.rb:12:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.1/lib/rack/session/abstract/id.rb:222:in `context'
/opt/rh/cfme-gemset/gems/rack-2.0.1/lib/rack/session/abstract/id.rb:216:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/cookies.rb:613:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/callbacks.rb:38:in `block in call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:97:in `__run_callbacks__'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:750:in `_run_call_callbacks'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:90:in `run_callbacks'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/callbacks.rb:36:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
/opt/rh/cfme-gemset/gems/railties-5.0.0.1/lib/rails/rack/logger.rb:36:in `call_app'
/opt/rh/cfme-gemset/gems/railties-5.0.0.1/lib/rails/rack/logger.rb:26:in `call'
/opt/rh/cfme-gemset/gems/request_store-1.3.1/lib/request_store/middleware.rb:9:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/request_id.rb:24:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.1/lib/rack/method_override.rb:22:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.1/lib/rack/runtime.rb:22:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
/opt/rh/cfme-gemset/gems/actionpack-5.0.0.1/lib/action_dispatch/middleware/executor.rb:12:in `call'
/opt/rh/cfme-gemset/gems/rack-2.0.1/lib/rack/sendfile.rb:111:in `call'
/opt/rh/cfme-gemset/gems/railties-5.0.0.1/lib/rails/engine.rb:522:in `call'
/opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/configuration.rb:224:in `call'
/opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/server.rb:561:in `handle_request'
/opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/server.rb:406:in `process_client'
/opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/server.rb:271:in `block in run'
/opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/thread_pool.rb:111:in `block in spawn_thread'
[----] I, [2016-11-15T03:11:20.251571 #2901:16c3904]  INFO -- :   Rendered layouts/_exception_contents.html.haml (0.2ms)
[----] I, [2016-11-15T03:11:20.252155 #2901:16c3904]  INFO -- : Completed 200 OK in 107ms (Views: 1.2ms | ActiveRecord: 0.0ms)

Comment 2 CFME Bot 2017-01-18 04:18:06 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/183

Comment 3 CFME Bot 2017-01-27 20:23:17 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/722bd2c4cc5ab80c6c3ae6702d3d067e199cd2d0

commit 722bd2c4cc5ab80c6c3ae6702d3d067e199cd2d0
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Fri Jan 27 14:51:01 2017 -0500
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Fri Jan 27 14:51:01 2017 -0500

    Set session[:snap_selected] to nil if Snapshot does not exist
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1395116

 app/controllers/vm_common.rb | 1 +
 1 file changed, 1 insertion(+)

Comment 4 CFME Bot 2017-01-27 20:23:23 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/7962ae0b0933bb9fc0f149488e7d82869364cb06

commit 7962ae0b0933bb9fc0f149488e7d82869364cb06
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Fri Jan 27 14:51:55 2017 -0500
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Fri Jan 27 15:01:01 2017 -0500

    Test
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1395116

 spec/controllers/vm_common_spec.rb | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comment 6 Aziza Karol 2017-03-14 04:23:24 UTC

Snapshot link in vm summary page works fine after deleting the snapshot.

Verified:
5.8.0.4.20170307183144_745a3d9

Note You need to log in before you can comment on or make changes to this bug.