Spec URL: https://lupinix.fedorapeople.org/review/python-wcsaxes.spec SRPM URL: https://lupinix.fedorapeople.org/review/python-wcsaxes-0.9-1.fc25.src.rpm Description: WCSAxes is a Python module which enhances matplotlib to plot astronomical and geospatial data. Fedora Account System Username: lupinix Koji scratch build (rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=16463801 Thank you very much for review in advance!
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed - ASL license is not correct. Use 'ASL 2.0' - Unexpanded-macro %description - Hidden-file-or-dir /usr/share/doc/python3-wcsaxes-doc/html/.buildinfo ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 103 files have unknown license. Detailed output of licensecheck in /home/sagitter/1395273-python- wcsaxes/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: python2-wcsaxes (description), python3-wcsaxes (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-wcsaxes , python3-wcsaxes , python3-wcsaxes-doc [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-wcsaxes-0.9-1.fc26.noarch.rpm python3-wcsaxes-0.9-1.fc26.noarch.rpm python3-wcsaxes-doc-0.9-1.fc26.noarch.rpm python-wcsaxes-0.9-1.fc26.src.rpm python2-wcsaxes.noarch: W: spelling-error Summary(en_US) geospatial -> spatial python2-wcsaxes.noarch: W: unexpanded-macro %description -l C %{description} python2-wcsaxes.noarch: W: invalid-license ASL python3-wcsaxes.noarch: W: spelling-error Summary(en_US) geospatial -> spatial python3-wcsaxes.noarch: W: unexpanded-macro %description -l C %{description} python3-wcsaxes.noarch: W: invalid-license ASL python3-wcsaxes-doc.noarch: W: invalid-license ASL python3-wcsaxes-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python3-wcsaxes-doc/html/.buildinfo python-wcsaxes.src: W: spelling-error Summary(en_US) geospatial -> spatial python-wcsaxes.src: W: spelling-error %description -l en_US matplotlib -> diplomatic python-wcsaxes.src: W: spelling-error %description -l en_US geospatial -> spatial python-wcsaxes.src: W: invalid-license ASL 4 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- python2-wcsaxes.noarch: W: spelling-error Summary(en_US) geospatial -> spatial python2-wcsaxes.noarch: W: unexpanded-macro %description -l C %{description} python2-wcsaxes.noarch: W: invalid-license ASL python3-wcsaxes-doc.noarch: W: invalid-license ASL python3-wcsaxes-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python3-wcsaxes-doc/html/.buildinfo python3-wcsaxes.noarch: W: spelling-error Summary(en_US) geospatial -> spatial python3-wcsaxes.noarch: W: unexpanded-macro %description -l C %{description} python3-wcsaxes.noarch: W: invalid-license ASL 3 packages and 0 specfiles checked; 0 errors, 8 warnings. Requires -------- python2-wcsaxes (rpmlib, GLIBC filtered): python(abi) python2-astropy python2-matplotlib python3-wcsaxes-doc (rpmlib, GLIBC filtered): python3-wcsaxes (rpmlib, GLIBC filtered): python(abi) python3-astropy python3-matplotlib Provides -------- python2-wcsaxes: python-wcsaxes python2-wcsaxes python2.7dist(wcsaxes) python2dist(wcsaxes) python3-wcsaxes-doc: python3-wcsaxes-doc python3-wcsaxes: python3-wcsaxes python3.5dist(wcsaxes) python3dist(wcsaxes) Source checksums ---------------- https://files.pythonhosted.org/packages/source/w/wcsaxes/wcsaxes-0.9.tar.gz : CHECKSUM(SHA256) this package : fd1897f611c48edee00b05bdd7bb238372843b9a8b8f7592cb0d5a7ed4d15b53 CHECKSUM(SHA256) upstream package : fd1897f611c48edee00b05bdd7bb238372843b9a8b8f7592cb0d5a7ed4d15b53 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1395273 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Spec URL: https://lupinix.fedorapeople.org/review/python-wcsaxes.spec SRPM URL: https://lupinix.fedorapeople.org/review/python-wcsaxes-0.9-2.fc25.src.rpm Thank you very much for your quick review! - ASL license is not correct. Use 'ASL 2.0' ==> Fixed - Unexpanded-macro %description ==> Fixed - Hidden-file-or-dir /usr/share/doc/python3-wcsaxes-doc/html/.buildinfo ==> Fixed by removing this file, does not contain any useful information anyway.
Package approved.
Again, thank you very much :)
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-wcsaxes
python-wcsaxes-0.9-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-884992496e
python-wcsaxes-0.9-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8b93ef0700
python-wcsaxes-0.9-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-884992496e
python-wcsaxes-0.9-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8b93ef0700
*** Bug 1389695 has been marked as a duplicate of this bug. ***
python-wcsaxes-0.9-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-884992496e
python-wcsaxes-0.9-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8b93ef0700
python-wcsaxes-0.9-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8b93ef0700
python-wcsaxes-0.9-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-884992496e
python-wcsaxes-0.9-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-wcsaxes-0.9-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.