Bug 1395492 - trace/error-gen be turned on together while use 'volume set' command to set one of them
Summary: trace/error-gen be turned on together while use 'volume set' command to set o...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ryan Ding
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-16 03:09 UTC by Ryan Ding
Modified: 2017-12-08 17:32 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.13.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-08 17:32:42 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ryan Ding 2016-11-16 03:09:35 UTC
Description of problem:

while use following command to trun on trace:

    gluster volume set fs1 debug.trace locks

the result show in volume file will be: 

    volume fs1-locks
        type features/locks
        subvolumes fs1-access-control
    end-volume

    volume fs1-trace
        type debug/trace
        subvolumes fs1-locks
    end-volume

    volume fs1-error-gen
        type debug/error-gen
        subvolumes fs1-trace
    end-volume

    volume fs1-worm
        type features/worm
        option worm-file-level off 
        option worm off 
        subvolumes fs1-error-gen
    end-volume

error-gen is also turned on, which is not what we want.

Comment 1 Worker Ant 2016-11-16 07:50:31 UTC
REVIEW: http://review.gluster.org/15849 (glusterd: fix issue that trace/error-gen be turned on together) posted (#2) for review on master by Ryan Ding (ryan.ding)

Comment 2 Worker Ant 2017-01-06 05:06:50 UTC
REVIEW: http://review.gluster.org/15849 (glusterd: Fix the debug and error-gen turned on issue) posted (#3) for review on master by Ryan Ding (ryan.ding)

Comment 3 Worker Ant 2017-08-16 10:51:54 UTC
REVIEW: https://review.gluster.org/15849 (glusterd: Fix the debug and error-gen turned on issue) posted (#4) for review on master by Atin Mukherjee (amukherj)

Comment 4 Worker Ant 2017-08-16 17:01:36 UTC
COMMIT: https://review.gluster.org/15849 committed in master by Atin Mukherjee (amukherj) 
------
commit 9b11b90d30285942113bb1e2d2a662337a75511c
Author: Ryan Ding <ryan.ding>
Date:   Wed Nov 16 10:52:34 2016 +0800

    glusterd: Fix the debug and error-gen turned on issue
    
    Problem:
    When enabling one of the debug or the error-gen xlator, both of
    them will be turned on together.
    The problem is that when adding debug xlators into the graph, its
    on/off status is ignored to be checked.
    
    Fix:
    When adding a debug xlator, check its status and skip those with
    a value of "off".
    
    Change-Id: Ifa79314ff337b60ee941cfb0308c1ccbe42d027f
    BUG: 1395492
    Signed-off-by: Zhang Huan <zhanghuan>
    Reviewed-on: https://review.gluster.org/15849
    Tested-by: Atin Mukherjee <amukherj>
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 5 Shyamsundar 2017-12-08 17:32:42 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.