Spec URL: https://jonny.fedorapeople.org/python-mnemonic.spec SRPM URL: https://jonny.fedorapeople.org/python-mnemonic-0.15-1.fc25.src.rpm Fedora Account System Username: jonny Description: This BIP describes the implementation of a mnemonic code or mnemonic sentence – a group of easy to remember words – for the generation of deterministic wallets. It consists of two parts: generating the mnenomic, and converting it into a binary seed. This seed can be later used to generate deterministic wallets using BIP-0032 or similar methods. See https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki for full specification.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16479966
New koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16480382 Needed to include python{2,3}-pbkdf2 as BR
Seem you have the copy of the "LICENSE" page [1], and not just the "LICENSE" itself. Please, check. Maybe you could use (e.g.) # https://raw.githubusercontent.com/trezor/python-mnemonic/f3348b32217d2bacf7438f5c40e8da4653887c70/LICENSE Source1: ìpython-mnemonic-LICENSE python2-mnemonic.noarch: E: script-without-shebang /usr/share/licenses/python2-mnemonic/LICENSE python3-mnemonic.noarch: E: script-without-shebang /usr/share/licenses/python3-mnemonic/LICENSE python-mnemonic.src: W: file-size-mismatch LICENSE = 37384, https://raw.githubusercontent.com/trezor/python-mnemonic/f3348b32217d2bacf7438f5c40e8da4653887c70/LICENSE = 1084 [1] https://raw.githubusercontent.com/trezor/python-mnemonic/f3348b32217d2bacf7438f5c40e8da4653887c70/LICENSE
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in ~/1395867-python- mnemonic/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL See above Comment#3 ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/gil/1395867 -python-mnemonic/licensecheck.txt [?]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-mnemonic , python3-mnemonic [x]: Package functions as described. [?]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-mnemonic-0.15-1.fc26.noarch.rpm python3-mnemonic-0.15-1.fc26.noarch.rpm python-mnemonic-0.15-1.fc26.src.rpm python2-mnemonic.noarch: W: spelling-error %description -l en_US mnenomic -> mnemonic, economic python2-mnemonic.noarch: E: script-without-shebang /usr/share/licenses/python2-mnemonic/LICENSE python3-mnemonic.noarch: W: spelling-error %description -l en_US mnenomic -> mnemonic, economic python3-mnemonic.noarch: E: script-without-shebang /usr/share/licenses/python3-mnemonic/LICENSE python-mnemonic.src: W: spelling-error %description -l en_US mnenomic -> mnemonic, economic python-mnemonic.src: W: file-size-mismatch LICENSE = 37384, https://raw.githubusercontent.com/trezor/python-mnemonic/f3348b32217d2bacf7438f5c40e8da4653887c70/LICENSE = 1084 3 packages and 0 specfiles checked; 2 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- python2-mnemonic.noarch: W: spelling-error %description -l en_US mnenomic -> mnemonic, economic python2-mnemonic.noarch: E: script-without-shebang /usr/share/licenses/python2-mnemonic/LICENSE python3-mnemonic.noarch: W: spelling-error %description -l en_US mnenomic -> mnemonic, economic python3-mnemonic.noarch: E: script-without-shebang /usr/share/licenses/python3-mnemonic/LICENSE 2 packages and 0 specfiles checked; 2 errors, 2 warnings. Requires -------- python2-mnemonic (rpmlib, GLIBC filtered): python(abi) python2-pbkdf2 python3-mnemonic (rpmlib, GLIBC filtered): python(abi) python3-pbkdf2 Provides -------- python2-mnemonic: python-mnemonic python2-mnemonic python2.7dist(mnemonic) python2dist(mnemonic) python3-mnemonic: python3-mnemonic python3.5dist(mnemonic) python3dist(mnemonic) Source checksums ---------------- https://files.pythonhosted.org/packages/source/m/mnemonic/mnemonic-0.15.tar.gz : CHECKSUM(SHA256) this package : 4c25f036742602181fa8c2deb5f000c7f2c5c3a169c5dd8af8ce1603dffb2652 CHECKSUM(SHA256) upstream package : 4c25f036742602181fa8c2deb5f000c7f2c5c3a169c5dd8af8ce1603dffb2652 https://raw.githubusercontent.com/trezor/python-mnemonic/f3348b32217d2bacf7438f5c40e8da4653887c70/LICENSE : CHECKSUM(SHA256) this package : 40aa62c918e7909a4882819ceec8854dab51848ce84487dd9d3afd38ae928b8b CHECKSUM(SHA256) upstream package : d5e3c7c62a84e80073201e2f6e5130e9e6804fa05f8ac4f8b26a13c7d3969697 diff -r also reports differences Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1395867 --plugins Python -m fedora-rawhide-i386 -L ~/deps Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Built with local dependencies: ~/deps/python3-pbkdf2-1.3-5.fc26.noarch.rpm ~/deps/python2-pbkdf2-1.3-5.fc26.noarch.rpm
Apart from the problem with the license (please, fix before import) file else seems okay
(In reply to gil cattaneo from comment #3) > Seem you have the copy of the "LICENSE" page [1], > and not just the "LICENSE" itself. > Please, check. Maybe you could use (e.g.) > # > https://raw.githubusercontent.com/trezor/python-mnemonic/ > f3348b32217d2bacf7438f5c40e8da4653887c70/LICENSE > Source1: ìpython-mnemonic-LICENSE > > python2-mnemonic.noarch: E: script-without-shebang > /usr/share/licenses/python2-mnemonic/LICENSE > python3-mnemonic.noarch: E: script-without-shebang > /usr/share/licenses/python3-mnemonic/LICENSE > > python-mnemonic.src: W: file-size-mismatch LICENSE = 37384, > https://raw.githubusercontent.com/trezor/python-mnemonic/ > f3348b32217d2bacf7438f5c40e8da4653887c70/LICENSE = 1084 > > [1] > https://raw.githubusercontent.com/trezor/python-mnemonic/ > f3348b32217d2bacf7438f5c40e8da4653887c70/LICENSE Looks like I have messed up something, will look into it.
Created attachment 1221389 [details] LICENSE diff
(In reply to gil cattaneo from comment #5) > Apart from the problem with the license (please, fix before import) file > else seems okay Thanks! I think messed because I used: > $ spectool -g -R python-mnemonic.spec And the old wrong license html page was already there, so the SRPM included the old file.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-mnemonic