Bug 1395910 - boot failure when installing with /boot as a directory of rootfs, instead of a separate volume
Summary: boot failure when installing with /boot as a directory of rootfs, instead of ...
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm-ostree
Version: 28
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Colin Walters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-16 22:59 UTC by Chris Murphy
Modified: 2020-08-02 18:19 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-05-28 19:31:24 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
screenshot of failure (66.57 KB, image/png)
2016-11-16 22:59 UTC, Chris Murphy
no flags Details
anaconda.log (45.54 KB, text/plain)
2016-11-16 22:59 UTC, Chris Murphy
no flags Details
grub.cfg (3.32 KB, text/plain)
2016-11-16 22:59 UTC, Chris Murphy
no flags Details
journal.log (451.58 KB, text/x-vhdl)
2016-11-16 23:00 UTC, Chris Murphy
no flags Details
ostree-fedora-atomic-0.conf (478 bytes, text/plain)
2016-11-16 23:00 UTC, Chris Murphy
no flags Details
program.log (34.07 KB, text/plain)
2016-11-16 23:00 UTC, Chris Murphy
no flags Details
storage.log (81.78 KB, text/plain)
2016-11-16 23:00 UTC, Chris Murphy
no flags Details

Description Chris Murphy 2016-11-16 22:59:03 UTC
Created attachment 1221402 [details]
screenshot of failure

Description of problem:

When /boot is a directory instead of a separate volume, the installation fails to boot. Kernel cannot be found in the path specified in the grub.cfg. Looks like rpm-ostree assumes /boot is a separate volume.


Version-Release number of selected component (if applicable):
Not exactly sure, I used this image:
https://fedorapeople.org/~walters/fedora-atomic-host-25-test.iso
which is based on:
http://kojipkgs.fedoraproject.org/compose/branched/Fedora-25-20161107.n.0/compose/Everything/x86_64/os
which would be
anaconda-25.20.5-1.fc25.x86_64.rpm
rpm-ostree-2016.11-1.fc25.x86_64.rpm  


How reproducible:
Always

Steps to Reproduce:
1. In a virt-manager VM, boot the ISO.
2. Choose custom partitioning
3. Use Standard Partitions, and create a single mount point / formatted as XFS. Nothing else.

Actual results:
Installs fine.
Boot failure, see screenshot.


Expected results:

Should boot. If I redo the installation using autopart, it boots.
Additional info:

Comment 1 Chris Murphy 2016-11-16 22:59:40 UTC
Created attachment 1221403 [details]
anaconda.log

Comment 2 Chris Murphy 2016-11-16 22:59:54 UTC
Created attachment 1221405 [details]
grub.cfg

Comment 3 Chris Murphy 2016-11-16 23:00:09 UTC
Created attachment 1221406 [details]
journal.log

Comment 4 Chris Murphy 2016-11-16 23:00:24 UTC
Created attachment 1221407 [details]
ostree-fedora-atomic-0.conf

Comment 5 Chris Murphy 2016-11-16 23:00:38 UTC
Created attachment 1221408 [details]
program.log

Comment 6 Chris Murphy 2016-11-16 23:00:56 UTC
Created attachment 1221409 [details]
storage.log

Comment 7 Chris Murphy 2016-11-17 02:45:24 UTC
The issue is ostree-fedora-atomic-0.conf and thus grub.cfg is malformed. It's missing the reference to the /boot/ directory when it's not on a boot volume.

linux16 /ostree/fedora-atomic-0ad0abb21855f77b6e6c0193ca75169ccdd442e6f2c4998a707d082374dfa453/vmlinuz-4.8.6-300.fc25.x86_64 rhgb quiet root=UUID=a94617bd-40d4-4371-901f-d96954d7cb46 ostree=/ostree/boot.0/fedora-atomic/0ad0abb21855f77b6e6c0193ca75169ccdd442e6f2c4998a707d082374dfa453/0
initrd16 /ostree/fedora-atomic-0ad0abb21855f77b6e6c0193ca75169ccdd442e6f2c4998a707d082374dfa453/initramfs-4.8.6-300.fc25.x86_64.img

If I manually fix the grub.cfg to add /boot/ in front of /ostree/... then it boots and I get a login prompt.

Comment 8 Chris Murphy 2016-11-17 02:48:26 UTC
The installed system has ostree-2016.12-1.fc25.x86_64 but I think it's the one on the install media that's responsible for creating this initial *.conf and the resulting grub.cfg. If this version already has a fix, maybe there's a command to generate a new *.conf and grub.cfg?

Comment 9 Fedora End Of Life 2017-11-16 18:41:54 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 10 Dusty Mabe 2017-11-16 20:17:35 UTC
Chris, I assume this is still a problem and we want it pulled forward?

Comment 11 Chris Murphy 2017-11-16 21:44:15 UTC
It's still broken. I see it from both sides: equally valid to want it fixed, and valid to say "you know it's just simpler to require a separate /boot volume, and let all simple and complex assembly happen by the kernel, initramfs and systemd, rather than doing the necessary work in GRUB or limiting people's layout options".

The reality is, Windows and macOS and Android and iOS, all have boot volumes. Is it inefficient and archaic? Yeah sorta. But it does work, and one size fits all has certain other efficiencies when it comes to making things bulletproof and troubleshooting them.

I figure if we want really reliable booting and (maybe one day) self-healing, we probably ought to focus on one standard layout and then make the circle bigger as resources dictate.

Comment 12 Colin Walters 2017-11-16 22:55:34 UTC
There are embedded people who use libostree this way, I would certainly be fine trying to support it but it seems unlikely it's going to be near the top of my TODO list anytime soon.

(One related thing is I'd like to switch to libostree's built-in grub2 generator and drop grub out of the OS install entirely)

Comment 13 Fedora End Of Life 2018-02-20 15:27:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 14 Ben Cotton 2019-05-02 22:06:01 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 15 Ben Cotton 2019-05-28 19:31:24 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 16 Chris Murphy 2020-08-02 16:30:45 UTC
See also bug 1862784.


Note You need to log in before you can comment on or make changes to this bug.