Bug 1396483 - Remove INFO message about context-sensitive help missing
Summary: Remove INFO message about context-sensitive help missing
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.0
Hardware: All
OS: All
unspecified
low
Target Milestone: ovirt-4.1.0-alpha
: 4.1.0
Assignee: Greg Sheremeta
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-18 13:09 UTC by Lukas Svaty
Modified: 2017-05-11 09:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:52:22 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
gshereme: devel_ack+
pstehlik: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 67142 0 master MERGED engine: removed csh INFO messages 2016-11-21 18:09:18 UTC

Description Lukas Svaty 2016-11-18 13:09:44 UTC 
Description of problem:
This log message should be warning instead of INFO
2016-11-18 14:04:26,126 INFO  [org.ovirt.engine.docs.utils.servlet.ContextSensitiveHelpMappingServlet] (default task-62) [] Context-sensitive help is not installed. Manual directory doesn't exist: /usr/share/ovirt-engine/manual

Expected results:
2016-11-18 14:04:26,126 WARN  [org.ovirt.engine.docs.utils.servlet.ContextSensitiveHelpMappingServlet] (default task-62) [] Context-sensitive help is not installed. Manual directory doesn't exist: /usr/share/ovirt-engine/manual
Comment 1 Martin Perina 2016-11-20 16:38:47 UTC 
Greg, could you please take a look?
Comment 2 Yedidyah Bar David 2016-11-21 06:51:03 UTC 
(In reply to Lukas Svaty from comment #0)
> Description of problem:
> This log message should be warning instead of INFO

Why? Upstream we do not have a manual. So no sense in warning there. Downstream it's required by the engine, so normally should be available. If it's missing, it's probably a packaging issue. You can add a CI/QE job to check for this, no need to annoy users. Also no need to complicate the code. IMHO.
Comment 3 Lukas Svaty 2016-11-21 10:01:24 UTC 
On upstream I would say this message should be hidden, as we don't have manual. On downstream as you said its required I am inclining to even s/INFO/ERROR/.
Comment 4 Yedidyah Bar David 2016-11-21 10:09:17 UTC 
(In reply to Lukas Svaty from comment #3)
> On upstream I would say this message should be hidden, as we don't have
> manual. On downstream as you said its required I am inclining to even
> s/INFO/ERROR/.

Why?

Please differentiate between "because it's an error, something bad likely happened" (so you might want to do this in CI/QE), and "The user should really know about this". Also a ton of other things are "Required:" (in the spec file), but we don't check for them directly. We rely on yum/rpm to do their job. And users that work around that, well, should know what they are doing.
Comment 5 Lukas Svaty 2016-11-21 11:05:09 UTC 
I'll leave it up to you. I believe this INFO message does not bring anything useful to logs on upstream and don't have enough severity and information to be useful in downstream.

As you said we rely on rpm/yum for packaging issues, and if necessary they will shout on unresolved dependency. Whether it is worth to not show this in upstream it's on DEV decision.
Comment 6 Greg Sheremeta 2016-11-21 16:13:16 UTC 
I'll remove the message. It's always there on upstream and never happens downstream, as Didi noted.
Comment 8 Sandro Bonazzola 2016-12-12 13:57:29 UTC 
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.
Comment 9 Lukas Svaty 2017-01-31 14:21:00 UTC 
verified in ovirt-engine-webadmin-portal-4.1.1-0.0.master.20170131101227.gitf71669f.el7.centos.noarch
Note You need to log in before you can comment on or make changes to this bug.