Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/DNSCryptClient.spec SRPM URL: https://f1ash.fedorapeople.org/DNSCryptClient/DNSCryptClient-1.0.0-1.fc26.src.rpm Description: The Qt GUI wrapped over dnscrypt-proxy for encrypting all DNS traffic between the user and DNS resolvers, preventing any spying, spoofing or man-in-the-middle attacks. Fedora Account System Username: f1ash Success build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16553976
Small suggestion (my usual pet-peave): remove mention of Qt from summary/description, users don't need to know or care what toolkit is used
And I think this is actually essential information and the main reason why I would pick one application over another doing the same thing. I don't like your removal of these mentions at all.
It's a slippery slope (I shudder thinking if *all* packages mentioned largely irrelevant technical details), but I can understand your point of view even if I disagree with it.
compromise: drop from summary, include in description if you insist
ok, dropped from summary and added to description. Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/DNSCryptClient.spec SRPM URL: https://f1ash.fedorapeople.org/DNSCryptClient/DNSCryptClient-1.0.0-2.fc26.src.rpm Success build : http://koji.fedoraproject.org/koji/taskinfo?taskID=16560249
INFO for reviewer or testers: after application using need RESTORE system resolver settings. Click 'Restore' (third) button for it or restore resolv.conf manually.
New version with more control of restoring system settings. Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/DNSCryptClient.spec SRPM URL: https://f1ash.fedorapeople.org/DNSCryptClient/DNSCryptClient-1.2.2-1.fc26.src.rpm Success build : http://koji.fedoraproject.org/koji/taskinfo?taskID=16617802
Renamed package (to comply https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Case_Sensitivity): Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-qt.spec SRPM URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-qt-1.2.2-2.fc26.src.rpm Success build : http://koji.fedoraproject.org/koji/taskinfo?taskID=16619256
OK, now you've sparked my pet-peave even *more*, including -qt in the package name itself. Please omit that part. (I won't review it as-is) Upstream project is named DNSCryptClient, I strongly suggest you follow suit and use: dnscryptclient
Unless there's some other reason you haven't mentioned besides not using mixed case name?
(In reply to Rex Dieter from comment #9) > OK, now you've sparked my pet-peave even *more*, including -qt in the > package name itself. Please omit that part. (I won't review it as-is) > > Upstream project is named DNSCryptClient, I strongly suggest you follow suit > and use: dnscryptclient Renamed project and package name: Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui.spec SRPM URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-1.2.2-3.fc26.src.rpm Success build : http://koji.fedoraproject.org/koji/taskinfo?taskID=16655123
fixed BRs, added systemd scriplets: Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui.spec SRPM URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-1.2.2-4.fc26.src.rpm Success build : http://koji.fedoraproject.org/koji/taskinfo?taskID=16660534
new build with fixed socket name in spec: Success build : http://koji.fedoraproject.org/koji/taskinfo?taskID=16660779
Summary: GUI wrapper for dnscrypt-proxy
fixed summary in new version: Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui.spec SRPM URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-1.2.3-1.fc26.src.rpm Success build : http://koji.fedoraproject.org/koji/taskinfo?taskID=16783203
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in dnscrypt-proxy-gui See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Need to add a %license entry to the files section - You need to either take ownership of /etc/dbus-1/system.d or depend on a package that does - Is it necessary for you to list all of the Requires out, explicitly? Some of them seem to be pulled in, automatically, by the packaging macros. Please evaluate whether all of those are needed or not. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 28 files have unknown license. Detailed output of licensecheck in /home/vagrant/dev/source/packaging/1397089 -dnscrypt-proxy-gui/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/dbus-1/system.d [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/dbus-1/system.d [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dnscrypt-proxy-gui-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dnscrypt-proxy-gui-1.2.3-1.fc24.x86_64.rpm dnscrypt-proxy-gui-debuginfo-1.2.3-1.fc24.x86_64.rpm dnscrypt-proxy-gui-1.2.3-1.fc24.src.rpm dnscrypt-proxy-gui.x86_64: W: spelling-error %description -l en_US resolvers -> resolver, resolves, revolvers dnscrypt-proxy-gui.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/pro.russianfedora.dnscryptclient.conf dnscrypt-proxy-gui.x86_64: W: no-manual-page-for-binary DNSCryptClient dnscrypt-proxy-gui.x86_64: W: empty-%postun dnscrypt-proxy-gui.src: W: spelling-error %description -l en_US resolvers -> resolver, resolves, revolvers 3 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: dnscrypt-proxy-gui-debuginfo-1.2.3-1.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory dnscrypt-proxy-gui.x86_64: W: spelling-error %description -l en_US resolvers -> resolver, resolves, revolvers dnscrypt-proxy-gui.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/pro.russianfedora.dnscryptclient.conf dnscrypt-proxy-gui.x86_64: W: no-manual-page-for-binary DNSCryptClient dnscrypt-proxy-gui.x86_64: W: empty-%postun 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- dnscrypt-proxy-gui-debuginfo (rpmlib, GLIBC filtered): dnscrypt-proxy-gui (rpmlib, GLIBC filtered): /bin/sh dbus dnscrypt-proxy hicolor-icon-theme kf5-kauth kf5-knotifications libKF5Auth.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Notifications.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.6)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) polkit qt5-qtbase rtld(GNU_HASH) systemd Provides -------- dnscrypt-proxy-gui-debuginfo: dnscrypt-proxy-gui-debuginfo dnscrypt-proxy-gui-debuginfo(x86-64) dnscrypt-proxy-gui: application() application(DNSCryptClient.desktop) dnscrypt-proxy-gui dnscrypt-proxy-gui(x86-64) Source checksums ---------------- https://github.com/F1ash/dnscrypt-proxy-gui/archive/1.2.3.tar.gz : CHECKSUM(SHA256) this package : 3513bbf57d7a049f637c84c74b8b5c2029090e8c2aced4806b4966f382992f1e CHECKSUM(SHA256) upstream package : 3513bbf57d7a049f637c84c74b8b5c2029090e8c2aced4806b4966f382992f1e Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1397089 Buildroot used: fedora-24-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to greg.hellings from comment #16) > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: gcc-c++ > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 fedora-review is not up to date here. The guidelines changed to require everything to be specified, in particular the compile and make and so on. [https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2]
fixed release (without rpmlint warning "W: spelling-error %description -l en_US resolvers"): Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui.spec SRPM URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-1.2.3-2.fc26.src.rpm
(In reply to Zbigniew Jędrzejewski-Szmek from comment #17) > (In reply to greg.hellings from comment #16) > > - All build dependencies are listed in BuildRequires, except for any that > > are listed in the exceptions section of Packaging Guidelines. > > Note: These BR are not needed: gcc-c++ > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > > fedora-review is not up to date here. The guidelines changed to require > everything to be specified, in particular the compile and make and so on. > [https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2] i'm remove gcc-c++ already :(
Then you should add it back ;)
fixed: Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui.spec SRPM URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-1.2.3-3.fc26.src.rpm
I think it's worth noting that the package does not compile against f26. I'm not certain if this is a fault of this package or of its dependencies. This is the output I see when trying to build for Rawhide targets: There is no installed groups file. Maybe run: yum groups mark convert (see man yum) Error: libcrypt conflicts with libcrypt-nss-2.24.90-21.fc26.x86_64 Error: libcrypt-nss conflicts with libcrypt-2.24.90-21.fc26.x86_64 You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest ERROR: Exception(/home/vagrant/1397089-dnscrypt-proxy-gui/srpm-unpacked/dnscrypt-proxy-gui-1.2.3-3.fc26.src.rpm) Config(f26-candidate-x86_64) 0 minutes 18 second Can you briefly look into that to discern if it's a problem with this package or with the libcrypt packages? That's my last outstanding concern.
# uname -r 4.9.0-0.rc8.git0.1.fc26.x86_64 # rpm -qR systemd | grep crypt libcrypt.so.1()(64bit) libcrypt.so.1(GLIBC_2.2.5)(64bit) libgcrypt.so.20()(64bit) libgcrypt.so.20(GCRYPT_1.6)(64bit) So, this conflict in systemd dependencies. It seems, this is temporarily problem with libcrypt package naming.
It also looks like it's been resolved now. Hearing no other objections to approval.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/dnscrypt-proxy-gui
dnscrypt-proxy-gui-1.2.3-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3ddc4480c
dnscrypt-proxy-gui-1.2.3-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-33843a76b3
dnscrypt-proxy-gui-1.2.3-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-33843a76b3
dnscrypt-proxy-gui-1.2.3-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3ddc4480c
dnscrypt-proxy-gui-1.2.3-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f51669220c
dnscrypt-proxy-gui-1.2.3-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6841e63ca1
dnscrypt-proxy-gui-1.2.3-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6841e63ca1
dnscrypt-proxy-gui-1.2.3-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f51669220c
dnscrypt-proxy-gui-1.2.3-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
dnscrypt-proxy-gui-1.2.3-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.