Spec URL: https://rathann.fedorapeople.org/review/fontsquirrel-crete-round-fonts/fontsquirrel-crete-round-fonts.spec SRPM URL: https://rathann.fedorapeople.org/review/fontsquirrel-crete-round-fonts/fontsquirrel-crete-round-fonts-0-0.1.20111222.fc25.src.rpm Description: Crete Round is a warm slab serif providing a hint of softness to texts. It started as a tailored version of the original Crete fonts - www.type-together.com/Crete - created specially to serve as corporate typeface for the type design competition Letter2 - www.letter2.org. Crete Round is more independent from the original with modified terminals and serifs to create two new fonts that deliver a more contemporary and functional appearance. The tall x-height, low contrast and sturdy slabs prove to be surprisingly efficient for web use. This font supports 128 languages and has 416 glyphs. Fedora Account System Username: rathann
oh I just realized I had picked this for review but did not post a review. Doing it now. Sorry for delay.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Suggestions: 1) Add fonts appstream metainfo file for gnome-software before import of this package ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "SIL (v1.1)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/parag/1397775 -fontsquirrel-crete-round-fonts/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [!]: Run repo-font-audit on all fonts in package. Note: Test run failed ==> I will work on fixing the fontaudit tests I think it need to be re-written for dnf and createrepo_c [x]: Run ttname on all fonts in package. Note: ttname analyze results in fonts/ttname.log. Rpmlint ------- Checking: fontsquirrel-crete-round-fonts-0-0.1.20111222.fc26.noarch.rpm fontsquirrel-crete-round-fonts-0-0.1.20111222.fc26.src.rpm fontsquirrel-crete-round-fonts.noarch: W: spelling-error %description -l en_US www -> WWW, wow fontsquirrel-crete-round-fonts.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s fontsquirrel-crete-round-fonts.noarch: W: no-documentation fontsquirrel-crete-round-fonts.src: W: spelling-error %description -l en_US www -> WWW, wow fontsquirrel-crete-round-fonts.src: W: spelling-error %description -l en_US glyphs -> glyph, glyph s 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- fontsquirrel-crete-round-fonts.noarch: W: spelling-error %description -l en_US www -> WWW, wow fontsquirrel-crete-round-fonts.noarch: W: spelling-error %description -l en_US glyphs -> glyph, glyph s fontsquirrel-crete-round-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Requires -------- fontsquirrel-crete-round-fonts (rpmlib, GLIBC filtered): config(fontsquirrel-crete-round-fonts) fontpackages-filesystem Provides -------- fontsquirrel-crete-round-fonts: config(fontsquirrel-crete-round-fonts) font(:lang=aa) font(:lang=af) font(:lang=an) font(:lang=ay) font(:lang=bi) font(:lang=br) font(:lang=bs) font(:lang=ca) font(:lang=ch) font(:lang=co) font(:lang=crh) font(:lang=cs) font(:lang=csb) font(:lang=cy) font(:lang=da) font(:lang=de) font(:lang=en) font(:lang=eo) font(:lang=es) font(:lang=et) font(:lang=eu) font(:lang=fi) font(:lang=fil) font(:lang=fj) font(:lang=fo) font(:lang=fr) font(:lang=fur) font(:lang=fy) font(:lang=gd) font(:lang=gl) font(:lang=gv) font(:lang=ho) font(:lang=hr) font(:lang=hsb) font(:lang=ht) font(:lang=hu) font(:lang=ia) font(:lang=id) font(:lang=ie) font(:lang=io) font(:lang=is) font(:lang=it) font(:lang=jv) font(:lang=ki) font(:lang=kj) font(:lang=kl) font(:lang=ku-tr) font(:lang=kwm) font(:lang=la) font(:lang=lb) font(:lang=lg) font(:lang=li) font(:lang=lt) font(:lang=lv) font(:lang=mg) font(:lang=mh) font(:lang=ms) font(:lang=mt) font(:lang=na) font(:lang=nb) font(:lang=nds) font(:lang=ng) font(:lang=nl) font(:lang=nn) font(:lang=no) font(:lang=nr) font(:lang=nso) font(:lang=ny) font(:lang=oc) font(:lang=om) font(:lang=pap-an) font(:lang=pap-aw) font(:lang=pl) font(:lang=pt) font(:lang=rm) font(:lang=rn) font(:lang=ro) font(:lang=rw) font(:lang=sc) font(:lang=se) font(:lang=sg) font(:lang=sk) font(:lang=sl) font(:lang=sma) font(:lang=smj) font(:lang=smn) font(:lang=sn) font(:lang=so) font(:lang=sq) font(:lang=ss) font(:lang=st) font(:lang=su) font(:lang=sv) font(:lang=sw) font(:lang=tk) font(:lang=tl) font(:lang=tn) font(:lang=tr) font(:lang=ts) font(:lang=ty) font(:lang=uz) font(:lang=vo) font(:lang=vot) font(:lang=wa) font(:lang=wen) font(:lang=wo) font(:lang=xh) font(:lang=yap) font(:lang=za) font(:lang=zu) font(creteround) fontsquirrel-crete-round-fonts Source checksums ---------------- https://www.fontsquirrel.com/fonts/download/crete-round#/crete-round.zip : CHECKSUM(SHA256) this package : 3e374da87c5abaa7ba33a18714624468be4cf843bd8d88745c6aa85da22c5012 CHECKSUM(SHA256) upstream package : aa600ad82e68b3b888bbe977cb60005879f756530984e0e220c84440bbc7525d However, diff -r shows no differences Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1397775 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/fontsquirrel-crete-round-fonts
any updates here? Package built on koji?
Sorry for the delay. Built in rawhide.