Description of problem: Version-Release number of selected component (if applicable): 5.7.0.11-rc1.20161115160629_46cf4f1 How reproducible: 100% Steps to Reproduce: 1.Manage ec2 or azure or gce providers 1.Navigate to Networks->Subnets 2.select and delete the subnet Actual results: The page just refreshes and "NotImplementedError (raw_delete_subnet must be implemented in a subclass)?" is thrown in production.log Expected results: should be able to delete the subnet. Additional info: production.log [----] I, [2016-11-24T01:47:42.183903 #2979:15f89d4] INFO -- : Started POST "/cloud_subnet/button/4?pressed=cloud_subnet_delete" for 127.0.0.1 at 2016-11-24 01:47:42 -0500 [----] I, [2016-11-24T01:47:42.186107 #2979:15f89d4] INFO -- : Processing by CloudSubnetController#button as JS [----] I, [2016-11-24T01:47:42.186179 #2979:15f89d4] INFO -- : Parameters: {"pressed"=>"cloud_subnet_delete", "id"=>"4"} [----] I, [2016-11-24T01:47:42.203581 #2979:15f89d4] INFO -- : Completed 500 Internal Server Error in 17ms (ActiveRecord: 0.0ms) [----] F, [2016-11-24T01:47:42.204069 #2979:15f89d4] FATAL -- : [----] F, [2016-11-24T01:47:42.204120 #2979:15f89d4] FATAL -- : NotImplementedError (raw_delete_subnet must be implemented in a subclass): [----] F, [2016-11-24T01:47:42.204149 #2979:15f89d4] FATAL -- : [----] F, [2016-11-24T01:47:42.204176 #2979:15f89d4] FATAL -- : app/models/cloud_subnet.rb:81:in `raw_delete_subnet' [----] F, [2016-11-24T01:47:42.204198 #2979:15f89d4] FATAL -- : app/models/cloud_subnet.rb:73:in `delete_subnet' [----] F, [2016-11-24T01:47:42.204218 #2979:15f89d4] FATAL -- : app/controllers/cloud_subnet_controller.rb:257:in `block in process_cloud_subnets' [----] F, [2016-11-24T01:47:42.204241 #2979:15f89d4] FATAL -- : app/controllers/cloud_subnet_controller.rb:248:in `each' [----] F, [2016-11-24T01:47:42.204264 #2979:15f89d4] FATAL -- : app/controllers/cloud_subnet_controller.rb:248:in `process_cloud_subnets' [----] F, [2016-11-24T01:47:42.204284 #2979:15f89d4] FATAL -- : app/controllers/cloud_subnet_controller.rb:148:in `delete_subnets' [----] F, [2016-11-24T01:47:42.204306 #2979:15f89d4] FATAL -- : app/controllers/cloud_subnet_controller.rb:23:in `button' [----] F, [2016-11-24T01:47:42.204330 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action' [----] F, [2016-11-24T01:47:42.204371 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/abstract_controller/base.rb:188:in `process_action' [----] F, [2016-11-24T01:47:42.204397 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_controller/metal/rendering.rb:30:in `process_action' [----] F, [2016-11-24T01:47:42.204418 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/abstract_controller/callbacks.rb:20:in `block in process_action' [----] F, [2016-11-24T01:47:42.204454 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/callbacks.rb:126:in `call' [----] F, [2016-11-24T01:47:42.204478 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/callbacks.rb:506:in `block (2 levels) in compile' [----] F, [2016-11-24T01:47:42.204499 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/callbacks.rb:455:in `call' [----] F, [2016-11-24T01:47:42.204521 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/callbacks.rb:101:in `__run_callbacks__' [----] F, [2016-11-24T01:47:42.204544 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks' [----] F, [2016-11-24T01:47:42.204575 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/callbacks.rb:90:in `run_callbacks' [----] F, [2016-11-24T01:47:42.204599 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/abstract_controller/callbacks.rb:19:in `process_action' [----] F, [2016-11-24T01:47:42.204620 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_controller/metal/rescue.rb:20:in `process_action' [----] F, [2016-11-24T01:47:42.204641 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_controller/metal/instrumentation.rb:32:in `block in process_action' [----] F, [2016-11-24T01:47:42.204661 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/notifications.rb:164:in `block in instrument' [----] F, [2016-11-24T01:47:42.204699 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/notifications/instrumenter.rb:21:in `instrument' [----] F, [2016-11-24T01:47:42.204724 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/notifications.rb:164:in `instrument' [----] F, [2016-11-24T01:47:42.204776 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_controller/metal/instrumentation.rb:30:in `process_action' [----] F, [2016-11-24T01:47:42.204801 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_controller/metal/params_wrapper.rb:248:in `process_action' [----] F, [2016-11-24T01:47:42.204822 #2979:15f89d4] FATAL -- : activerecord (5.0.0.1) lib/active_record/railties/controller_runtime.rb:18:in `process_action' [----] F, [2016-11-24T01:47:42.204843 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/abstract_controller/base.rb:126:in `process' [----] F, [2016-11-24T01:47:42.204864 #2979:15f89d4] FATAL -- : actionview (5.0.0.1) lib/action_view/rendering.rb:30:in `process' [----] F, [2016-11-24T01:47:42.204883 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_controller/metal.rb:190:in `dispatch' [----] F, [2016-11-24T01:47:42.204903 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_controller/metal.rb:262:in `dispatch' [----] F, [2016-11-24T01:47:42.204922 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:50:in `dispatch' [----] F, [2016-11-24T01:47:42.204941 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:32:in `serve' [----] F, [2016-11-24T01:47:42.204960 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:39:in `block in serve' [----] F, [2016-11-24T01:47:42.204979 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:26:in `each' [----] F, [2016-11-24T01:47:42.204999 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/journey/router.rb:26:in `serve' [----] F, [2016-11-24T01:47:42.205029 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/routing/route_set.rb:725:in `call' [----] F, [2016-11-24T01:47:42.205050 #2979:15f89d4] FATAL -- : secure_headers (3.0.3) lib/secure_headers/middleware.rb:10:in `call' [----] F, [2016-11-24T01:47:42.205069 #2979:15f89d4] FATAL -- : rack (2.0.1) lib/rack/etag.rb:25:in `call' [----] F, [2016-11-24T01:47:42.205090 #2979:15f89d4] FATAL -- : rack (2.0.1) lib/rack/conditional_get.rb:38:in `call' [----] F, [2016-11-24T01:47:42.205112 #2979:15f89d4] FATAL -- : rack (2.0.1) lib/rack/head.rb:12:in `call' [----] F, [2016-11-24T01:47:42.205137 #2979:15f89d4] FATAL -- : rack (2.0.1) lib/rack/session/abstract/id.rb:222:in `context' [----] F, [2016-11-24T01:47:42.205161 #2979:15f89d4] FATAL -- : rack (2.0.1) lib/rack/session/abstract/id.rb:216:in `call' [----] F, [2016-11-24T01:47:42.205186 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/middleware/cookies.rb:613:in `call' [----] F, [2016-11-24T01:47:42.205210 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/middleware/callbacks.rb:38:in `block in call' [----] F, [2016-11-24T01:47:42.205235 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/callbacks.rb:97:in `__run_callbacks__' [----] F, [2016-11-24T01:47:42.205258 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/callbacks.rb:750:in `_run_call_callbacks' [----] F, [2016-11-24T01:47:42.205283 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/callbacks.rb:90:in `run_callbacks' [----] F, [2016-11-24T01:47:42.205306 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/middleware/callbacks.rb:36:in `call' [----] F, [2016-11-24T01:47:42.205331 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/middleware/remote_ip.rb:79:in `call' [----] F, [2016-11-24T01:47:42.205355 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call' [----] F, [2016-11-24T01:47:42.205379 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/middleware/show_exceptions.rb:31:in `call' [----] F, [2016-11-24T01:47:42.205402 #2979:15f89d4] FATAL -- : railties (5.0.0.1) lib/rails/rack/logger.rb:36:in `call_app' [----] F, [2016-11-24T01:47:42.205426 #2979:15f89d4] FATAL -- : railties (5.0.0.1) lib/rails/rack/logger.rb:26:in `call' [----] F, [2016-11-24T01:47:42.205475 #2979:15f89d4] FATAL -- : request_store (1.3.1) lib/request_store/middleware.rb:9:in `call' [----] F, [2016-11-24T01:47:42.205501 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/middleware/request_id.rb:24:in `call' [----] F, [2016-11-24T01:47:42.205522 #2979:15f89d4] FATAL -- : rack (2.0.1) lib/rack/method_override.rb:22:in `call' [----] F, [2016-11-24T01:47:42.205541 #2979:15f89d4] FATAL -- : rack (2.0.1) lib/rack/runtime.rb:22:in `call' [----] F, [2016-11-24T01:47:42.205561 #2979:15f89d4] FATAL -- : activesupport (5.0.0.1) lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call' [----] F, [2016-11-24T01:47:42.205582 #2979:15f89d4] FATAL -- : actionpack (5.0.0.1) lib/action_dispatch/middleware/executor.rb:12:in `call' [----] F, [2016-11-24T01:47:42.205602 #2979:15f89d4] FATAL -- : rack (2.0.1) lib/rack/sendfile.rb:111:in `call' [----] F, [2016-11-24T01:47:42.205621 #2979:15f89d4] FATAL -- : railties (5.0.0.1) lib/rails/engine.rb:522:in `call' [----] F, [2016-11-24T01:47:42.205641 #2979:15f89d4] FATAL -- : puma (3.3.0) lib/puma/configuration.rb:224:in `call' [----] F, [2016-11-24T01:47:42.205662 #2979:15f89d4] FATAL -- : puma (3.3.0) lib/puma/server.rb:561:in `handle_request' [----] F, [2016-11-24T01:47:42.205683 #2979:15f89d4] FATAL -- : puma (3.3.0) lib/puma/server.rb:406:in `process_client' [----] F, [2016-11-24T01:47:42.205708 #2979:15f89d4] FATAL -- : puma (3.3.0) lib/puma/server.rb:271:in `block in run' [----] F, [2016-11-24T01:47:42.205730 #2979:15f89d4] FATAL -- : puma (3.3.0) lib/puma/thread_pool.rb:111:in `block in spawn_thread' [----] I, [2016-11-24T01:47:46.137323 #2962:17aa304] INFO -- : Started GET "/ws/notifications" [WebSocket] for 127.0.0.1 at 2016-11-24 01:47:46 -0500 [----] I, [2016-11-24T01:47:46.137494 #2962:17aa304] INFO -- : Successfully upgraded to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: Upgrade, HTTP_UPGRADE: WebSocket) [----] I, [2016-11-24T01:47:46.144484 #2962:5328e94] INFO -- : Registered connection (Z2lkOi8vdm1kYi9Vc2VyLzE) [----] I, [2016-11-24T01:47:46.896330 #2962:57e52ac] INFO -- : NotificationChannel is transmitting the subscription confirmation [----] I, [2016-11-24T01:47:46.896974 #2962:57e52ac] INFO -- : NotificationChannel is streaming from notifications_1
@Mainn can you make sure you do a proper assert in the controllers? You should be marking only OpentStack as supported for these actions, rest should return unsupported in the flash messages.
btw. the real expected result is: "Should have a clean message about action not being supported" Supporting of the actions needs to be an RFE for each provider.
Looking at similar code, it appears the preferred approach is to have the edit/delete buttons simply not show up if the feature is not supported. https://github.com/ManageIQ/manageiq/pull/13096
Verified on 5.8.0.13-rc2 and RHOS 10