Spec URL: https://marcindulak.fedorapeople.org/packages/py-idstools/r01/python-idstools.spec SRPM URL: https://marcindulak.fedorapeople.org/packages/py-idstools/r01/python-idstools-0.5.4-1.fc23.src.rpm Description: py-idstools is a collection of Python libraries for working with IDS systems (typically Snort and Suricata) Fedora Account System Username: marcindulak
have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1244657 ? thanks in advance
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* BSD", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/gil/1398369-python-idstools/licensecheck.txt The following source files are without license headers: py-idstools-0.5.4/bin/idstools-dumpdynamicrules py-idstools-0.5.4/bin/idstools-eve2pcap py-idstools-0.5.4/bin/idstools-gensidmsgmap py-idstools-0.5.4/bin/idstools-rulecat py-idstools-0.5.4/bin/idstools-u2bench py-idstools-0.5.4/bin/idstools-u2eve py-idstools-0.5.4/bin/idstools-u2fast py-idstools-0.5.4/bin/idstools-u2json py-idstools-0.5.4/bin/idstools-u2spewfoo py-idstools-0.5.4/doc/conf.py py-idstools-0.5.4/idstools/__init__.py py-idstools-0.5.4/idstools/compat/argparse/argparse.py py-idstools-0.5.4/idstools/scripts/dumpdynamicrules.py py-idstools-0.5.4/tests/test_classificationmap.py py-idstools-0.5.4/tests/test_signaturemap.py Please, ask to upstream to confirm the licensing of code and/or content/s, and add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification [!]: License file installed when any subpackage combination is installed. [!]: Package contains no bundled libraries without FPC exception. py-idstools-0.5.4/idstools/compat/argparse/__init__.py py-idstools-0.5.4/idstools/compat/argparse/argparse.py py-idstools-0.5.4/idstools/compat/argparse/LICENSE.txt [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [?]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [?]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-idstools , python3-idstools [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-idstools-0.5.4-1.fc26.noarch.rpm python3-idstools-0.5.4-1.fc26.noarch.rpm python-idstools-0.5.4-1.fc26.src.rpm python2-idstools.noarch: W: spelling-error %description -l en_US py -> pt, p, y python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/eve2pcap.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/eve2pcap.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/u2fast.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/u2fast.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/gensidmsgmap.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/gensidmsgmap.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/u2eve.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/u2eve.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/u2json.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/u2json.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/u2spewfoo.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/u2spewfoo.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/rulecat.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/rulecat.py 644 /usr/bin/env python python3-idstools.noarch: W: spelling-error %description -l en_US py -> pt, p, y python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py 644 /usr/bin/env python Please, fix these problems python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2fast python3-idstools.noarch: W: no-manual-page-for-binary idstools-eve2pcap python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2eve python3-idstools.noarch: W: no-manual-page-for-binary idstools-gensidmsgmap python3-idstools.noarch: W: no-manual-page-for-binary idstools-rulecat python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2json NOTE: manual pages should be generated with sphinx in py-idstools-0.5.4/doc python-idstools.src: W: spelling-error %description -l en_US py -> pt, p, y python-idstools.src:1: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 1) 3 packages and 0 specfiles checked; 28 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- python3-idstools.noarch: W: spelling-error %description -l en_US py -> pt, p, y python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py 644 /usr/bin/env python python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2eve python3-idstools.noarch: W: no-manual-page-for-binary idstools-rulecat python3-idstools.noarch: W: no-manual-page-for-binary idstools-gensidmsgmap python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2json python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2fast python3-idstools.noarch: W: no-manual-page-for-binary idstools-eve2pcap python2-idstools.noarch: W: spelling-error %description -l en_US py -> pt, p, y python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/gensidmsgmap.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/gensidmsgmap.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/u2json.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/u2json.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/rulecat.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/rulecat.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/u2fast.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/u2fast.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/u2spewfoo.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/u2spewfoo.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/u2eve.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/u2eve.py 644 /usr/bin/env python python2-idstools.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/idstools/scripts/eve2pcap.py /usr/bin/env python python2-idstools.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/idstools/scripts/eve2pcap.py 644 /usr/bin/env python 2 packages and 0 specfiles checked; 28 errors, 8 warnings. Requires -------- python3-idstools (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python2-idstools (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-idstools: python3-idstools python3.5dist(idstools) python3dist(idstools) python2-idstools: python-idstools python2-idstools python2.7dist(idstools) python2dist(idstools) Source checksums ---------------- https://github.com/jasonish/py-idstools/archive/0.5.4.tar.gz#/py-idstools-0.5.4.tar.gz : CHECKSUM(SHA256) this package : 951dfdff8d81ac186bf4870c06829bc579167afd7b3ca211157f1832fa781c72 CHECKSUM(SHA256) upstream package : 951dfdff8d81ac186bf4870c06829bc579167afd7b3ca211157f1832fa781c72 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1398369 --plugins Python -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Issues: [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* BSD", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/gil/1398369-python-idstools/licensecheck.txt The following source files are without license headers: py-idstools-0.5.4/bin/idstools-dumpdynamicrules py-idstools-0.5.4/bin/idstools-eve2pcap py-idstools-0.5.4/bin/idstools-gensidmsgmap py-idstools-0.5.4/bin/idstools-rulecat py-idstools-0.5.4/bin/idstools-u2bench py-idstools-0.5.4/bin/idstools-u2eve py-idstools-0.5.4/bin/idstools-u2fast py-idstools-0.5.4/bin/idstools-u2json py-idstools-0.5.4/bin/idstools-u2spewfoo py-idstools-0.5.4/doc/conf.py py-idstools-0.5.4/idstools/__init__.py py-idstools-0.5.4/idstools/compat/argparse/argparse.py py-idstools-0.5.4/idstools/scripts/dumpdynamicrules.py py-idstools-0.5.4/tests/test_classificationmap.py py-idstools-0.5.4/tests/test_signaturemap.py Please, ask to upstream to confirm the licensing of code and/or content/s, and add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification [!]: License file installed when any subpackage combination is installed. [!]: Package contains no bundled libraries without FPC exception. py-idstools-0.5.4/idstools/compat/argparse/__init__.py py-idstools-0.5.4/idstools/compat/argparse/argparse.py py-idstools-0.5.4/idstools/compat/argparse/LICENSE.txt [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Package does not include license text files separate from upstream. [!]: Package consistently uses macros (instead of hard-coded directory names). "%{!?py2_build: %global py2_build CFLAGS="%{optflags}" /usr/bin/python2 setup.py build --executable="/usr/bin/python2 -s"}" [?]: Package complies to the Packaging Guidelines why customized the py?_build/install macros? Please, fix these problems python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py 644 /usr/bin/env python NON blocking issues: python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2fast python3-idstools.noarch: W: no-manual-page-for-binary idstools-eve2pcap python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2eve python3-idstools.noarch: W: no-manual-page-for-binary idstools-gensidmsgmap python3-idstools.noarch: W: no-manual-page-for-binary idstools-rulecat python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2json manual pages should be generated with sphinx in py-idstools-0.5.4/doc ?
Spec URL: https://marcindulak.fedorapeople.org/packages/py-idstools/r02/python-idstools.spec SRPM URL: https://marcindulak.fedorapeople.org/packages/py-idstools/r02/python-idstools-0.5.4-1.fc23.src.rpm (In reply to gil cattaneo from comment #3) > Issues: > > [!]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. I've asked upstream to include a license file https://github.com/jasonish/py-idstools/issues/32 > > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* BSD", > "Unknown or generated". 17 files have unknown license. Detailed output > of licensecheck in /home/gil/1398369-python-idstools/licensecheck.txt > Removed the libraries bundled under the compat folder, and with them: MIT/X11 (BSD like) ------------------ py-idstools-0.5.4/idstools/compat/ordereddict.py The setup.py file is explicit about BSD license so there should be no licensing problem for other files > The following source files are without license headers: > py-idstools-0.5.4/bin/idstools-dumpdynamicrules > py-idstools-0.5.4/bin/idstools-eve2pcap > py-idstools-0.5.4/bin/idstools-gensidmsgmap > py-idstools-0.5.4/bin/idstools-rulecat > py-idstools-0.5.4/bin/idstools-u2bench > py-idstools-0.5.4/bin/idstools-u2eve > py-idstools-0.5.4/bin/idstools-u2fast > py-idstools-0.5.4/bin/idstools-u2json > py-idstools-0.5.4/bin/idstools-u2spewfoo > py-idstools-0.5.4/doc/conf.py > py-idstools-0.5.4/idstools/__init__.py > py-idstools-0.5.4/idstools/compat/argparse/argparse.py > py-idstools-0.5.4/idstools/scripts/dumpdynamicrules.py > py-idstools-0.5.4/tests/test_classificationmap.py > py-idstools-0.5.4/tests/test_signaturemap.py > > Please, ask to upstream to confirm the licensing of code and/or content/s, > and add license headers > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Clarification > > [!]: License file installed when any subpackage combination is installed. see above, we don't have explicit license file yet > > [!]: Package contains no bundled libraries without FPC exception. > py-idstools-0.5.4/idstools/compat/argparse/__init__.py > py-idstools-0.5.4/idstools/compat/argparse/argparse.py > py-idstools-0.5.4/idstools/compat/argparse/LICENSE.txt addressed above > > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. see above > > [!]: Package does not include license text files separate from upstream. > > [!]: Package consistently uses macros (instead of hard-coded directory > names). > > "%{!?py2_build: %global py2_build CFLAGS="%{optflags}" /usr/bin/python2 > setup.py build --executable="/usr/bin/python2 -s"}" > > [?]: Package complies to the Packaging Guidelines > why customized the py?_build/install macros? I've removed the macros. Without those macros the RPM does not build on a standalone CentOS7, but it builds in koji and mock. > > Please, fix these problems > > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py > /usr/bin/env python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py 644 /usr/bin/env > python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py 644 /usr/bin/env > python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py 644 /usr/bin/env > python > I remove the python shabang from those files during %build, and reported this at https://github.com/jasonish/py-idstools/issues/33 > NON blocking issues: > python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2fast > python3-idstools.noarch: W: no-manual-page-for-binary idstools-eve2pcap > python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2eve > python3-idstools.noarch: W: no-manual-page-for-binary idstools-gensidmsgmap > python3-idstools.noarch: W: no-manual-page-for-binary idstools-rulecat > python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2json > > manual pages should be generated with sphinx in py-idstools-0.5.4/doc ? let's drop building the documentation with sphinx and adding the -doc packages, for at least two reasons: 1. cd doc&& make man creates rather ugly idstools.1 idstools-rulecat.1, there is some structure in those but they look mostly like parsing of doc strings. 2. python34-sphinxcontrib-programoutput needed for a sphinx run is not available on EPEL7
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-idstools
python-idstools-0.5.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a0684e943f
python-idstools-0.5.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-736b58c885
python-idstools-0.5.4-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9f3d307043
python-idstools-0.5.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-736b58c885
python-idstools-0.5.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a0684e943f
python-idstools-0.5.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9f3d307043
python-idstools-0.5.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-idstools-0.5.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
python-idstools-0.5.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.