Bug 1399077 - RFE: Improve for VM selecting when vm's name is also a meaningful ID or UUID
Summary: RFE: Improve for VM selecting when vm's name is also a meaningful ID or UUID
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: virt-viewer
Version: 7.4
Hardware: x86_64
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Pavel Grunt
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-28 09:05 UTC by Xiaodai Wang
Modified: 2017-08-01 15:04 UTC (History)
9 users (show)

Fixed In Version: virt-viewer-5.0-1.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-01 15:04:11 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:1849 0 normal SHIPPED_LIVE virt-viewer bug fix and enhancement update 2017-08-01 17:49:46 UTC

Description Xiaodai Wang 2016-11-28 09:05:47 UTC
Description of problem:
RFE: Improve for VM selecting when vm's name is also a meaningful ID or UUID

Version-Release number of selected component (if applicable):
virt-viewer-2.0-12.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a running guest and check it's ID by "virsh list"
# virsh list
 Id    Name                           State
----------------------------------------------------
 3     rhel7.3-1005                   running
 4     rhel7.2                        running
 5     3                              running

2. Created a guest which the name is same as a ID of another guest.
3. Run virt-viewer to open the new created guest.
$ virt-viewer -c qemu:///system 3

Actual results:
rhel7.3-1005 is opened.

Expected results:
Due to "3" could be a ID of another guest and the name of a guest, It's better to find all available guest which corresponding to the name/id/uuid the user typed in command line, and show them in a dialog to ask user to select which one is they wanted.


Additional info:
uuid may have same problem when a guest's name is a uuid.

Comment 2 Martin Tessun 2016-12-16 08:22:46 UTC
I think it is quite unusual to name a VM name to a id.

Anyways we should better document how the selection process works or maybe add some cmdline option to specify if the VM is specified by name/id/uid.

So adding a new (optional) option to be able to specifically tell virt-viewer it is connecting to a VM-name, VM-ID or VM-UUID, e.g. for your usecase:

$ virt-viewer -c qemu:///system 3

Would still connect to id=3 (being rhel7.3-1005)

$ virt-viewer --vm-name -c qemu:///system 3

would then connect to the VM with name "3".

Sounds more feasible to me, as it would not break automation scripts for opening VM consoles without the possibility of doing user interaction.

Comment 3 Pavel Grunt 2016-12-20 12:12:07 UTC
I agree with Martin. The situation described in the comment 0 is interesting but it is a corner case.

cli options like --name, --id, --uuid (i would omit the 'vm' to match similar options in other virt tools)

Comment 7 Xiaodai Wang 2017-03-20 06:09:10 UTC
I followed case (https://polarion.engineering.redhat.com/polarion/#/project/RedHatEnterpriseLinux7/workitem?id=RHEL7-85842) and verified it with virt-viewer-5.0-2.el7.x86_64 in below env.  All steps are success.

# virsh list
 Id    Name                           State
----------------------------------------------------
 1     rhel7.3-1005                   running
 2     e8fc0fd9-8415-44b6-9ef9-cd9a8d5b05f2 running
 3     1                              running

So move the bug from ON_QA to VERIFIED.

Comment 8 errata-xmlrpc 2017-08-01 15:04:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1849


Note You need to log in before you can comment on or make changes to this bug.