Created attachment 1225503 [details]
VM Template table-view screenshot
Description of problem:
Infrastructure provisioning template selection screen includes "Hide deprecated" checkbox and "Deprecated" column which only apply to cloud provisioning
Version-Release number of selected component (if applicable): 5.7.0
Steps to Reproduce:
1. Navigate to Compute -> Infrastructure -> Virtual Machines
2. Select Lifecycle -> Provision VMs
VM Template table-view screen shows "Hide deprecated" checkbox and "Deprecated" column which was added for cloud (GCE specifically) and is not used by any infra providers. (See attachment)
Unrelated fields are hidden.
The field is not inaccurate for the infra side since all templates show as "false" but these fields serve no purpose and therefore seem confusing.
New Checkbox added in PR https://github.com/ManageIQ/manageiq/pull/11896
On pre provisioning screen we need to hide "Hide Deprecated" check-box when user is submitting a provisioning request for Infrastructure VM.
Currently default is set to hide deprecated templates here https://github.com/ManageIQ/manageiq/blob/master/app/controllers/application_controller/miq_request_methods.rb#L167 so need to set this to true only when provisioning cloud templates.
Should hide the check-box here https://github.com/ManageIQ/manageiq/blob/master/app/views/miq_request/_pre_prov.html.haml#L8
Also need to hide it from list of Templates here
and in a grid after a template is selected:
No need to add in list of headers for Infrastructure provisioning https://github.com/ManageIQ/manageiq/blob/master/app/controllers/application_controller/miq_request_methods.rb#L412
Hopefully i got all the places covered, Let me know if you have questions.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.