Bug 1399815 - RFE: --chroot='*pattern*' --no-chroot='*pattern*' option
Summary: RFE: --chroot='*pattern*' --no-chroot='*pattern*' option
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Copr
Classification: Community
Component: cli
Version: unspecified
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Copr Team
QA Contact:
URL:
Whiteboard:
: 1475134 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-29 19:33 UTC by Van de Bugger
Modified: 2023-04-03 18:40 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-03 18:40:27 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1475134 0 unspecified CLOSED RFE: copr build --{in,ex}clude-chroots=PATTERN, copr create --add-chroots=PATTERN 2021-02-22 00:41:40 UTC

Internal Links: 1475134

Description Van de Bugger 2016-11-29 19:33:50 UTC
Description of problem:

Option --chroot (or -r) allows to specify systems to build the package. In my experience reverse option --no-chroot (or -R) would be much more useful: to build on all systems (enabled in the project), *except* specified in the command line.

Version-Release number of selected component (if applicable):

copr-cli-1.57-1.fc24.noarch

Comment 1 Pavel Raiskup 2016-11-30 06:09:59 UTC
Thanks for the report.

(In reply to Van de Bugger from comment #0)
> Description of problem:
> 
> Option --chroot (or -r) allows to specify systems to build the package. In
> my experience reverse option --no-chroot (or -R) would be much more useful:
> to build on all systems (enabled in the project), *except* specified in the
> command line.

Can you please elaborate a bit?  '--no-chroot' sounds like you wanted to build
for no chroot.  What you talk about looks like the default copr-cli
behavior (build for all chroots enabled in copr).  But most likely I
misinterpreted your request..

Comment 2 Van de Bugger 2016-12-13 18:57:44 UTC
Existing options:

$ copr-cli build project foo-1.1.1-1.src.rpm
# Initiate build foo in ALL chroots enabled in the project settings.

$ copr-cli build -r fedora-25-i386 project foo-1.1.1-1.src.rpm
# Initiate build foo in ONE chroot fedora-25-i386.

Desired option:

$ copr-cli build -R fedora-25-i386 project foo-1.1.1-1.src.rpm
# Initiate build foo in all chroots enabled in the project settings EXCEPT fedora-25-i386.

Comment 3 Pavel Raiskup 2016-12-13 23:41:00 UTC
Reading your initial description again, it is clear, sorry.

The `--exclude-chroot` sounds more self-descriptive (and I would rather
avoid using short options).  Also I would encourage to use fnmatch to support
pattern matching.

Comment 4 Van de Bugger 2016-12-14 08:24:26 UTC
> The `--exclude-chroot` sounds more self-descriptive…

However, I am not aware about copr server internals. To me option --chroot is not self-descriptive and rather cryptic.

I do not insist on particular option name anyway.

> Also I would encourage to use fnmatch to support pattern matching.

Yes, it would be nice.

Comment 5 Pavel Raiskup 2016-12-14 09:04:03 UTC
(In reply to Van de Bugger from comment #4)
> To me option --chroot is not self-descriptive and rather cryptic.

I guess some documentation asks for a fix then, but I doubt Copr is the
right place anyway - that would different issue:

From `man 2 chroot`, 'chroot - change root directory'.  That is rather
really low level term, "syscall", used widely in Fedora and especially in
`mock` (Copr is built on top of `mock` tool).

Comment 6 Fedora End Of Life 2017-07-26 00:00:56 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 7 Pavel Raiskup 2020-12-14 10:33:03 UTC
*** Bug 1475134 has been marked as a duplicate of this bug. ***

Comment 8 Pavel Raiskup 2020-12-14 10:37:23 UTC
Once we have fixed https://pagure.io/copr/copr/issue/1350, I think
we can look at this - and enhance your proposal by bug 1475134 -
so both `--chroot` and `--no-chroot` also accept patterns.

Note for myself: similar thing is in GNU tar for --xattrs-include=
and --xatrrs-exclude.

Comment 9 Jakub Kadlčík 2021-01-08 21:48:32 UTC
The `--exclude-chroot` is implemented in PR#1650
except for the pattern support, which I would like to add separately (and to the --chroot parameter as well)

Comment 10 Jakub Kadlčík 2023-04-03 18:40:27 UTC
The bugs related to Copr build system are now migrated to the
default Copr team tracker:
https://github.com/fedora-copr/copr/issues/2645


Note You need to log in before you can comment on or make changes to this bug.