Bug 1399860 - Removing an audit log for no OVF_STORE disks when attaching a storage domain
Summary: Removing an audit log for no OVF_STORE disks when attaching a storage domain
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.1.0-alpha
: 4.1.0.2
Assignee: Maor
QA Contact: Avihai
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-29 23:03 UTC by Maor
Modified: 2017-02-01 14:54 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:54:03 UTC
oVirt Team: Storage
Embargoed:
amureini: needinfo+
rule-engine: ovirt-4.1+


Attachments (Terms of Use)
auditlogwarnning (6.36 KB, image/png)
2016-11-29 23:04 UTC, Maor
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 67601 0 master MERGED core: Remove warn audit log for missing OVF_STORE 2016-12-04 14:33:57 UTC

Description Maor 2016-11-29 23:03:25 UTC
Description of problem:
In previous ovirt-engine versions it was more likely to have an old storage domain without an OVF_STORE disk that will be attached to a new DC which supports OVF_STORE disk, since the setup could use different DCs from different versions like DC 3.4 .
For that reason we added a warning audit log that will inform the user that this Storage Domain does not contain an OVF_STORE disk and there will be no VMs or Templates to recover (The current message is "This Data center compatibility version does not support importing a data domain with its entities (VMs and Templates). The imported domain will be imported without them.")

The problem this audit log reflects is that it can't distinguish between new storage domains or old storage domains from old DCs, since new storage domains does not contain any disks.

Also, since ovirt-engine 4.1 the Data Center versiosn that should be supported are only 3.6, 4.0 and 4.1 Data Centers (All of those should support OVF_STORE disk)

That is why I think that this audit log can be removed but we will still keep the log message for better investigation on future bugs.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Create a new Storage Domain and attach it to DC
2.
3.

Actual results:
the following audit log will be presented:
"This Data center compatibility version does not support importing a data domain with its entities (VMs and Templates). The imported domain will be imported without them."

Expected results:
No audit log, merely an indication in the engine.log

Additional info:

Comment 1 Maor 2016-11-29 23:04:19 UTC
Created attachment 1226072 [details]
auditlogwarnning

Comment 2 Maor 2016-11-29 23:07:00 UTC
Yaniv, Allon
What do you think about removing the warning audit log, should we expect any customer feedback on that, or the engine.log should be good enough?

Comment 3 Allon Mureinik 2016-11-30 05:13:42 UTC
(In reply to Maor from comment #2)
> Yaniv, Allon
> What do you think about removing the warning audit log, should we expect any
> customer feedback on that, or the engine.log should be good enough?

I don't have a strong opinion either way, but frankly, I don't think this is worth the effort.
Yaniv, your call.

Comment 4 Yaniv Lavi 2016-11-30 14:49:21 UTC
(In reply to Allon Mureinik from comment #3)
> (In reply to Maor from comment #2)
> > Yaniv, Allon
> > What do you think about removing the warning audit log, should we expect any
> > customer feedback on that, or the engine.log should be good enough?
> 
> I don't have a strong opinion either way, but frankly, I don't think this is
> worth the effort.
> Yaniv, your call.

Yes, we can remove this.
Does 4.0 support 3.5 SD import?

Comment 5 Maor 2016-11-30 15:52:30 UTC
(In reply to Yaniv Dary from comment #4)
> (In reply to Allon Mureinik from comment #3)
> > (In reply to Maor from comment #2)
> > > Yaniv, Allon
> > > What do you think about removing the warning audit log, should we expect any
> > > customer feedback on that, or the engine.log should be good enough?
> > 
> > I don't have a strong opinion either way, but frankly, I don't think this is
> > worth the effort.
> > Yaniv, your call.
> 
> Yes, we can remove this.
> Does 4.0 support 3.5 SD import?

yes, it can basically support the import of every SD version

Comment 6 Avihai 2017-01-18 07:09:40 UTC
Tested scenario as requested ( attached a new storage domain to DC) 

Indeed No audit log entry was created .

The message I see in the engine log is as follows:
2017-01-18 08:56:56,303+02 WARN  [org.ovirt.engine.core.bll.storage.domain.AttachStorageDomainToPoolCommand] (org.ovirt.thread.pool-6-thread-15) [] There are no OVF_STORE disks on storage domain id f64a49c0-3376-471a-8fe0-789ac9284e41


Tested on oVirt Engine Version: 
4.1.0-0.4.master.20170109112129.git05e2d0d.el7.centos


Note You need to log in before you can comment on or make changes to this bug.