Bug 1400545 - Dump volume specific options in get-state output in a more parseable manner
Summary: Dump volume specific options in get-state output in a more parseable manner
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: 3.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Samikshan Bairagya
QA Contact:
URL:
Whiteboard:
Depends On: 1399995
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-01 13:17 UTC by Samikshan Bairagya
Modified: 2017-03-08 10:20 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.9.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1399995
Environment:
Last Closed: 2017-03-08 10:20:37 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Samikshan Bairagya 2016-12-01 13:17:08 UTC
+++ This bug was initially created as a clone of Bug #1399995 +++

Description of problem:

Currently the get-state cli outputs the volume options in the following format:

Volume1.rebalance.skipped: 0                                                    
Volume1.rebalance.lookedup: 0                                                   
Volume1.rebalance.files: 0                                                      
Volume1.rebalance.data: 0Bytes                                                  
[Volume1.options]                                                               
features.barrier: on                                                            
transport.address-family: inet                                                  
performance.readdir-ahead: on                                                   
nfs.disable: on                                                                 
                                                                                
Volume2.name: tv2                                                         
Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9                                
Volume2.type: Distribute

This above format is a valid ini file format syntactically, but is not very easily parseable. The following format should be more easily parseable:

Volume1.rebalance.skipped: 0
Volume1.rebalance.lookedup: 0
Volume1.rebalance.files: 0
Volume1.rebalance.data: 0Bytes
Volume1.options.features.barrier: on
Volume1.options.transport.address-family: inet
Volume1.options.performance.readdir-ahead: on
Volume1.options.nfs.disable: on

Volume2.name: tv2
Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
Volume2.type: Distribute


Version-Release number of selected component (if applicable): mainline

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-11-30 04:14:39 EST ---

REVIEW: http://review.gluster.org/15975 (glusterd, cli: Fix volume options output format in get-state cli) posted (#1) for review on master by Samikshan Bairagya (samikshan)

--- Additional comment from Worker Ant on 2016-12-01 08:12:08 EST ---

COMMIT: http://review.gluster.org/15975 committed in master by Atin Mukherjee (amukherj) 
------
commit 331a45942333e27f596b1930f7d459f59850c8a4
Author: Samikshan Bairagya <samikshan>
Date:   Wed Nov 30 14:35:59 2016 +0530

    glusterd, cli: Fix volume options output format in get-state cli
    
    Currently the get-state cli outputs the volume options in the
    following format:
    
    Volume1.rebalance.skipped: 0
    Volume1.rebalance.lookedup: 0
    Volume1.rebalance.files: 0
    Volume1.rebalance.data: 0Bytes
    [Volume1.options]
    features.barrier: on
    transport.address-family: inet
    performance.readdir-ahead: on
    nfs.disable: on
    
    Volume2.name: tv2
    Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
    Volume2.type: Distribute
    
    This above format is a valid ini file format syntactically, but is
    not very easily parseable. This patch changes the format to look like
    the following and should be more easily parseable:
    
    Volume1.rebalance.skipped: 0
    Volume1.rebalance.lookedup: 0
    Volume1.rebalance.files: 0
    Volume1.rebalance.data: 0Bytes
    Volume1.options.features.barrier: on
    Volume1.options.transport.address-family: inet
    Volume1.options.performance.readdir-ahead: on
    Volume1.options.nfs.disable: on
    
    Volume2.name: tv2
    Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
    Volume2.type: Distribute
    
    Change-Id: I9768b45de288d9817ec669d3a801874eb1914750
    BUG: 1399995
    Signed-off-by: Samikshan Bairagya <samikshan>
    Reviewed-on: http://review.gluster.org/15975
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Shubhendu Tripathi <shtripat>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2016-12-01 13:21:02 UTC
REVIEW: http://review.gluster.org/15993 (glusterd, cli: Fix volume options output format in get-state cli) posted (#1) for review on release-3.9 by Samikshan Bairagya (samikshan)

Comment 2 Worker Ant 2016-12-02 05:44:45 UTC
COMMIT: http://review.gluster.org/15993 committed in release-3.9 by Atin Mukherjee (amukherj) 
------
commit d69d802b6e63c5b95bd9ab8eae5fd2799564a897
Author: Samikshan Bairagya <samikshan>
Date:   Wed Nov 30 14:35:59 2016 +0530

    glusterd, cli: Fix volume options output format in get-state cli
    
    Currently the get-state cli outputs the volume options in the
    following format:
    
    Volume1.rebalance.skipped: 0
    Volume1.rebalance.lookedup: 0
    Volume1.rebalance.files: 0
    Volume1.rebalance.data: 0Bytes
    [Volume1.options]
    features.barrier: on
    transport.address-family: inet
    performance.readdir-ahead: on
    nfs.disable: on
    
    Volume2.name: tv2
    Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
    Volume2.type: Distribute
    
    This above format is a valid ini file format syntactically, but is
    not very easily parseable. This patch changes the format to look like
    the following and should be more easily parseable:
    
    Volume1.rebalance.skipped: 0
    Volume1.rebalance.lookedup: 0
    Volume1.rebalance.files: 0
    Volume1.rebalance.data: 0Bytes
    Volume1.options.features.barrier: on
    Volume1.options.transport.address-family: inet
    Volume1.options.performance.readdir-ahead: on
    Volume1.options.nfs.disable: on
    
    Volume2.name: tv2
    Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
    Volume2.type: Distribute
    
    > Reviewed-on: http://review.gluster.org/15975
    > Smoke: Gluster Build System <jenkins.org>
    > Reviewed-by: Shubhendu Tripathi <shtripat>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Atin Mukherjee <amukherj>
    > CentOS-regression: Gluster Build System <jenkins.org>
    
    (cherry picked from commit 331a45942333e27f596b1930f7d459f59850c8a4)
    
    Change-Id: I9768b45de288d9817ec669d3a801874eb1914750
    BUG: 1400545
    Signed-off-by: Samikshan Bairagya <samikshan>
    Reviewed-on: http://review.gluster.org/15993
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 3 Kaushal 2017-03-08 10:20:37 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.1, please open a new bug report.

glusterfs-3.9.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-January/029725.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.