Description of problem: Error: Duplicate declaration: Package[nfs-utils] is already declared in file /etc/puppet/modules/tripleo/manifests/profile/base/cinder/volume/nfs.pp:53; cannot redeclare at /etc/puppet/modules/manila/manifests/backend/netapp.pp:144 on node overcloud-ctrl-0.cluster.local
Created attachment 1226862 [details] cinder-netapp-config.yaml
Created attachment 1226864 [details] manila-netapp-config.yaml
openstack overcloud deploy --templates \ -e /usr/share/openstack-tripleo-heat-templates/environments/puppet-pacemaker.yaml \ -e /usr/share/openstack-tripleo-heat-templates/environments/tls-endpoints-public-dns.yaml \ -e ~/tripleo/custom/manila-netapp-config.yaml \ -e ~/tripleo/custom/network-environment.yaml \ -e ~/tripleo/custom/enable-tls.yaml \ -e ~/tripleo/custom/scheduler_hints_env.yaml \ -e ~/tripleo/custom/cinder-netapp-config.yaml \ -e ~/tripleo/custom/all_params.yaml \ --control-scale 3 --compute-scale 2 --ntp-server 0.uk.pool.ntp.org \ --neutron-network-type vxlan --neutron-tunnel-types vxlan
Created attachment 1226867 [details] manila-netapp-config.yaml
2 recommendations: 1. test on your environment after removing the nfs-utils section from the puppet-manila/netapp.pp file. If this works and correctly configures manila and your cinder nfs on the same server, then we can look at pulling that code out. (I am not convinced it is 100% needed there, but I would have to do a lot more research) 2. explicitly set package_ensure for that module to false/undef in hiera something like this manila::profile::backend::netapp::package_ensure: false I don't run triple-o, but we are using that particular puppet-manila module w/o any issues. Keep in mind here we are not running cinder nfs on our control nodes I know Tom is going to try to test this as well. If it turns out that we don't need the nfs-utils for that netapp piece, I can pull that and put it up for review
The problem is in usage of "package" directive (where puppet doesn't like that Package class for nfs-utils is declared multiple times). Using "ensure_packages" (instead of "package") in both puppet modules should solve the problem.
This isn't a problem for me any more however it isn't clear what resolved it. Potentially I was calling controllerExtraConfigPre twice. Sorry, slightly weird issue.
Thanks Tom, will close this then.
I posted a change to puppet-manila to use ensure_resource, I believe it merged last night. https://review.openstack.org/#/c/408658/ Glad your problem resolved itself.