Bug 1400775
| Summary: | Better to disable the Create button when Configuration File field didn't pass the validation check | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Yadan Pei <yapei> |
| Component: | Management Console | Assignee: | Jakub Hadvig <jhadvig> |
| Status: | CLOSED ERRATA | QA Contact: | Yadan Pei <yapei> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3.4.0 | CC: | aos-bugs, jforrest, jokerman, mmccomas, tdawson, wsun, yanpzhan |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause: Putting a file invalid/unsupported format content in the Configuration File field.
Consequence: User is able to hit the Create button, but gets error alert since the content is in invalid/unsupported format.
Fix: Add validation for the Configuration File field.
Result: If the field contains invalid/unsupported format, disable Create button.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-12 19:17:39 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Yadan Pei
2016-12-02 03:15:45 UTC
Commit pushed to master at https://github.com/openshift/origin-web-console https://github.com/openshift/origin-web-console/commit/1793f9b25440e35a6df9208a1c4389543965db77 Bug 1400775 - Disable the Create button when Configuration File field didn't pass the validation check Will check when new puddle is ready Change to MODIFIED because there is no new puddle now, please feel free to change back to ON_QA when it could be tested This has been merged into ocp and is in OCP v3.4.0.33 or newer. Checked on OCP v3.4.0.33, fix not merged yet, will check on next puddle OCP v3.4.0.34 is out and ready to be checked. There was some management console changes with v3.4.0.34, but the pull request in Comment #1 is for Master, not for enterprise-3.4. That doesn't mean the code hasn't made it in, just that it isn't for that pull request. Checked on OCP 3.4 with version openshift v3.4.0.34+87d9d8d, the bug still exists. The bug's target release is 3.4.0, we can not test it if the fix for the bug is not in enterprise-3.4. this fix was not targeted for 3.4, it should only be in 3.5 This has been merged into ocp and is in OCP v3.5.0.7 or newer. Checked against v3.5.0.7 with steps: 1.Visit Resources -> Secrets page, click "Create Secret" 2.Secret Type: Image Secret Secret Name: imagesecret Authetication Type: Configuration File 3.Upload non json(like yaml) format file to Configuration File field, warning info "Configuration file should be in JSON format" is shown and Create button is disbaled 4.Upload a json format file but not in dockerConfig format, also prints "Configuration file should be in JSON format" warning and Create button is disabled 5.Only when configuration file is uploaded with correct dockerconfig format file, the secret could be created successfully Move to VERIFIED Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:0884 |