Bug 1400802 - glusterfs_ctx_defaults_init is re-initializing ctx->locks
Summary: glusterfs_ctx_defaults_init is re-initializing ctx->locks
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: cli
Version: 3.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: rjoseph
QA Contact:
URL:
Whiteboard:
Depends On: 1397419
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-02 06:35 UTC by rjoseph
Modified: 2016-12-21 23:21 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8.7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1397419
Environment:
Last Closed: 2016-12-14 07:13:24 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description rjoseph 2016-12-02 06:35:08 UTC
+++ This bug was initially created as a clone of Bug #1397419 +++

Description of problem:

In glusterfs_ctx_defaults_init both glusterfsd and cli is re-initializing ctx->locks which can overwrite previous state.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-11-22 08:59:07 EST ---

REVIEW: http://review.gluster.org/15904 (cli: glusterfs_ctx_defaults_init should not re-initialize ctx->locks) posted (#1) for review on master by Rajesh Joseph (rjoseph)

--- Additional comment from Worker Ant on 2016-11-22 08:59:10 EST ---

REVIEW: http://review.gluster.org/15905 (glusterfsd: glusterfs_ctx_defaults_init should not re-initialize ctx->locks) posted (#1) for review on master by Rajesh Joseph (rjoseph)

--- Additional comment from Worker Ant on 2016-11-24 09:29:05 EST ---

COMMIT: http://review.gluster.org/15904 committed in master by Atin Mukherjee (amukherj) 
------
commit 8df8a2308fcf5efda638f160428158127930d00f
Author: Rajesh Joseph <rjoseph>
Date:   Tue Nov 22 01:48:26 2016 +0530

    cli: glusterfs_ctx_defaults_init should not re-initialize ctx->locks
    
    glusterfs_ctx_new already initialize ctx->locks therefore the second
    initialization in glusterfs_ctx_defaults_init does not make sense.
    
    Change-Id: I8a44bed13af20e60e8bafb05360e88c0b237056c
    BUG: 1397419
    Signed-off-by: Rajesh Joseph <rjoseph>
    Reviewed-on: http://review.gluster.org/15904
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

--- Additional comment from Worker Ant on 2016-12-02 01:23:42 EST ---

COMMIT: http://review.gluster.org/15905 committed in master by Atin Mukherjee (amukherj) 
------
commit 47e69455d3aede77960fd81a7cf3d6b4a869dbfa
Author: Rajesh Joseph <rjoseph>
Date:   Tue Nov 22 01:51:19 2016 +0530

    glusterfsd: glusterfs_ctx_defaults_init should not re-initialize ctx->locks
    
    glusterfs_ctx_new already initialize ctx->locks therefore the second
    initialization in glusterfs_ctx_defaults_init does not make sense.
    
    Change-Id: I6027cbd311da8e80585e0f0dcd6916e3bc8dd284
    BUG: 1397419
    Signed-off-by: Rajesh Joseph <rjoseph>
    Reviewed-on: http://review.gluster.org/15905
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Poornima G <pgurusid>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 1 Worker Ant 2016-12-02 06:36:18 UTC
REVIEW: http://review.gluster.org/16001 (glusterfsd: glusterfs_ctx_defaults_init should not re-initialize ctx->locks) posted (#1) for review on release-3.8 by Rajesh Joseph (rjoseph)

Comment 2 Worker Ant 2016-12-02 06:38:52 UTC
REVIEW: http://review.gluster.org/16003 (cli: glusterfs_ctx_defaults_init should not re-initialize ctx->locks) posted (#1) for review on release-3.8 by Rajesh Joseph (rjoseph)

Comment 3 Worker Ant 2016-12-05 03:54:43 UTC
COMMIT: http://review.gluster.org/16003 committed in release-3.8 by Vijay Bellur (vbellur) 
------
commit 48031e69fd8928e79b3ae4ae49640530e131e2fd
Author: Rajesh Joseph <rjoseph>
Date:   Tue Nov 22 01:48:26 2016 +0530

    cli: glusterfs_ctx_defaults_init should not re-initialize ctx->locks
    
    glusterfs_ctx_new already initialize ctx->locks therefore the second
    initialization in glusterfs_ctx_defaults_init does not make sense.
    
    > Reviewed-on: http://review.gluster.org/15904
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Atin Mukherjee <amukherj>
    (cherry picked from commit 8df8a2308fcf5efda638f160428158127930d00f)
    
    Change-Id: I8a44bed13af20e60e8bafb05360e88c0b237056c
    BUG: 1400802
    Signed-off-by: Rajesh Joseph <rjoseph>
    Reviewed-on: http://review.gluster.org/16003
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Niels de Vos 2016-12-14 07:13:24 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.7, please open a new bug report.

glusterfs-3.8.7 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2016-December/000226.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 5 Worker Ant 2016-12-21 23:21:36 UTC
REVIEW: http://review.gluster.org/16249 (cli: glusterfs_ctx_defaults_init should not re-initialize ctx->locks) posted (#1) for review on release-3.8-fb by Kevin Vigor (kvigor)


Note You need to log in before you can comment on or make changes to this bug.