Bug 1402058 - [RFE] Introspection of diskless nodes
Summary: [RFE] Introspection of diskless nodes
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-ironic-inspector
Version: 11.0 (Ocata)
Hardware: Unspecified
OS: Unspecified
Target Milestone: Upstream M1
: 12.0 (Pike)
Assignee: mkovacik
QA Contact: mlammon
Depends On:
Blocks: 1442136 1475631
TreeView+ depends on / blocked
Reported: 2016-12-06 16:49 UTC by Dmitry Tantsur
Modified: 2018-02-05 19:02 UTC (History)
8 users (show)

Fixed In Version: openstack-ironic-inspector-5.1.1-0.20170418093722.9142b7d.el7ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2017-12-13 20:54:56 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Launchpad 1554243 0 None None None 2016-12-06 16:50:38 UTC
OpenStack gerrit 326620 0 None MERGED Allow diskless nodes introspection 2020-11-17 12:27:41 UTC
Red Hat Product Errata RHEA-2017:3462 0 normal SHIPPED_LIVE Red Hat OpenStack Platform 12.0 Enhancement Advisory 2018-02-16 01:43:25 UTC

Description Dmitry Tantsur 2016-12-06 16:49:20 UTC
Currently introspection fails when a node has no disks. We need a new API/CLI flag to mark a node as diskless, to allow introspection on it to pass. We probably also need a global option to treat all nodes as diskless.

Then we need Ironic inspection interface to provide this flag based on presence of a valid storage_interface field (to be introduced as part of BFV).

Comment 1 Dmitry Tantsur 2016-12-06 16:50:39 UTC
Upstream RFE: https://bugs.launchpad.net/ironic/+bug/1554243

Comment 3 mkovacik 2017-01-30 17:25:01 UTC
patch merged upstream; https://review.openstack.org/#/c/326620/

Comment 4 mkovacik 2017-02-14 16:08:13 UTC
Update on the upstream status: code merged, present in Ocata (inspector version 5.0)
Changing status to ON_QA;

Comment 10 mlammon 2017-07-20 20:21:17 UTC
This was tested in a kvm virtual environment successfully. 

install osp 12 undercloud with several nodes (i.e 3 controller, 2 compute, 1 <spare>)
On hypervisor, virsh detach-disk --domain <spare> --target vda --persistent
openstack baremetal import --json ~/instackenv.json  # contains 
openstack baremetal configure boot
openstack baremetal introspection bulk start
openstack baremetal list  # look for the uuid of <spare> used for 0 disk
openstack baremetal node show <uuid> | grep properties

As expected result:
The introspection succeeded now with one bare metal and property "u'local_gb': u'0'"

Comment 12 mlammon 2017-07-20 20:38:16 UTC
Additional testing to show that we can still detect and fail node with local_gb drive =0 by using device hints

This will set the device hints to seek out this case.

for i in `ironic node-list | awk '/None/ {print $2}'`;
do ironic node-update $i add properties/root_device='{"size": "> 1"}';done

follow with introspection

Comment 15 errata-xmlrpc 2017-12-13 20:54:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.