RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1402207 - Review Request: puppet-etcd - Installs and configures etcd
Summary: Review Request: puppet-etcd - Installs and configures etcd
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: trunk
Assignee: Haïkel Guémar
QA Contact: Alan Pevec
URL:
Whiteboard:
Depends On:
Blocks: RDO-OCATA
TreeView+ depends on / blocked
 
Reported: 2016-12-07 03:52 UTC by Feng Pan
Modified: 2017-06-22 15:55 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-06-22 15:55:00 UTC
Embargoed:
karlthered: rdo-review+


Attachments (Terms of Use)

Description Feng Pan 2016-12-07 03:52:51 UTC
Description of problem:

puppet-etcd [1] is a puppet module to install and configure etcd. etcd is a distributed key value store. etcd is used by networking-vpp ML2 plugin.

[1] https://github.com/cristifalcas/puppet-etcd

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Javier Peña 2016-12-16 13:43:39 UTC
Initial licensecheck output:

$ licensecheck -r .
./spec/spec_helper.rb: *No copyright* UNKNOWN
./spec/classes/init_spec.rb: *No copyright* UNKNOWN
./lib/puppet/type/etcd_key.rb: *No copyright* UNKNOWN
./lib/puppet/provider/etcd_key/etcdctl.rb: *No copyright* UNKNOWN
./Rakefile: *No copyright* UNKNOWN
./README.md: *No copyright* UNKNOWN
./LICENSE: Apache (v2.0)
./Gemfile: *No copyright* UNKNOWN

The git repo shows a possibly wrong copyright assignment at https://github.com/cristifalcas/puppet-etcd/blob/master/LICENSE#L1 . Haïkel, do you think this could be an issue?

Comment 2 Alan Pevec 2016-12-20 14:06:09 UTC
> The git repo shows a possibly wrong copyright assignment at https://github.com/cristifalcas/puppet-etcd/blob/master/LICENSE#L1 

What's wrong about that line?

Comment 3 Javier Peña 2016-12-20 15:08:01 UTC
(In reply to Alan Pevec from comment #2)
> > The git repo shows a possibly wrong copyright assignment at https://github.com/cristifalcas/puppet-etcd/blob/master/LICENSE#L1 
> 
> What's wrong about that line?

It's assigning copyright to "RR. Tyler Croy <tyler>", who has not commited any change to the repository.

Comment 4 Haïkel Guémar 2017-01-09 14:58:51 UTC
After investigation, it looks like it was bootstrapped using code from https://github.com/jenkinsci/puppet-jenkins but license file was not modified.
Since original project has same licensing conditions, it's ok but please file a ticket fixing license file and crediting original author for its contribution.

Package approved, please move forward.

Comment 5 Feng Pan 2017-01-09 16:53:46 UTC
Ticket filed and resolved upstream, https://github.com/cristifalcas/puppet-etcd/issues/16

The license file no longer shows RR. Tyler Croy <tyler>

Comment 6 Christopher Brown 2017-06-22 15:55:00 UTC
This was merged, closing.


Note You need to log in before you can comment on or make changes to this bug.