Created attachment 1228900 [details] screen shot of JSON format inside YAML through Edit YAML action for tempalte(other Resources) Description of problem: === OpenShift webconsole template Edit YAML action still shows JSON format partially. Version-Release number of selected component (if applicable): === OCP 3.3 How reproducible(Steps to Reproduce): === 1. oc create -f /usr/share/openshift/examples/xpaas-templates/eap64-sso-s2i.json 2. Goto console-> Resources-> Other Resources-> select Template-> eap64-sso-s2i-> Actions->Edit YAML Actual results: === The template partially shows JSON format. Please see attached screenshot. (around livenessProbe and readinessProbe) Expected results: === It should display with YAML format only. Additional info: === Due to issue, users cannot copy&paste the template through web console.
JSON embedded in YAML is valid YAML. There should be nothing wrong with using the template in this format. This is working as intended, once we get to a certain level of nested objects we have the editor switch to embedded JSON.
This was originally done because Edit YAML was in a modal dialog and had limited space. We can remove the restriction and have it fully parse into the block model.
Commit pushed to master at https://github.com/openshift/origin-web-console https://github.com/openshift/origin-web-console/commit/bb8691174d7c7033a8dab17d8b47ad9bf73c1f9b Bug 1402260 remove nesting limitation from json to yaml parsing
This has been merged into ocp and is in OCP v3.5.0.7 or newer.
Created attachment 1243536 [details] check-template
Tested on OCP v3.5.0.7. 1.Create template in project: oc create -f origin/examples/sample-app/application-template-stibuild.json 2.From other resource page choose template "ruby-helloworld-sample", check edit yaml. There is no JSON embedded in YAML, and even update with JSON embedded in YAML and save, check edit yaml again, it's still in yaml format. Are these the right steps to check the fix? I upload a screenshot "check-template" as well. If it's not enough, pls help point out the steps, thanks!
That sounds like the right verification steps
Thanks, Jessica.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:0884