Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1402279

Summary:	Improve daemon logging
Product:	[oVirt] ovirt-imageio	Reporter:	Ondra Machacek <omachace>
Component:	Daemon	Assignee:	Daniel Erez <derez>
Status:	CLOSED NOTABUG	QA Contact:	Raz Tamir <ratamir>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	---	CC:	amureini, bugs, nsoffer, omachace, tnisan, ylavi
Target Milestone:	ovirt-4.1.0-beta	Flags:	rule-engine: ovirt-4.1+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-02 10:02:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ondra Machacek 2016-12-07 07:37:40 UTC

It's very hard to debug problems with daemon.

For example when exception here[1] occurs, you should print traceback, so we know what's the problem.

I believe it can be improved on more places.

[1] https://github.com/oVirt/ovirt-imageio/blob/master/daemon/ovirt_imageio_daemon/server.py#L160

Comment 1 Allon Mureinik 2016-12-07 09:47:00 UTC

Tentatively suggesting for 4.1.
If we see this is non-intrusive enough, we ca definitely backport to 4.0.z too.

Comment 2 Ondra Machacek 2016-12-07 09:48:28 UTC

Please at least log the tracebacks of exceptions in 4.0.z.
It's impossible to debug anything, because exceptions are swalloed.

Comment 3 Amit Aviram 2016-12-14 14:36:56 UTC

Ondra, what are the versions of ovirt-imageio-daemon, ovirt-imageio-common in your host?

Comment 4 Ondra Machacek 2016-12-14 14:39:31 UTC

It's following:

[vagrant@host1 ~]$ rpm -qa | grep imageio
ovirt-imageio-daemon-0.5.0-0.201611201242.gitb02532b.el7.centos.noarch
ovirt-imageio-common-0.5.0-0.201611201242.gitb02532b.el7.centos.noarch

Comment 5 Daniel Erez 2016-12-27 16:25:04 UTC

Hi Ondra,

We don't log traceback for 4xx status since it's originated from a user error (i.e. bad parameters), so a full traceback won't help. For 5xx statuses, the traceback should be logged. Did you encounter any other scenario that should have the traceback logged?

Comment 6 Ondra Machacek 2017-01-02 09:03:56 UTC

Hi Daniel,

This one is most important I think, I didn't encounter any other.

Comment 7 Daniel Erez 2017-01-02 09:13:14 UTC

@Nir - (In reply to Ondra Machacek from comment #6)
> Hi Daniel,
> 
> This one is most important I think, I didn't encounter any other.

@Nir - do we have anything else to do in this case besides logging a warning?

Comment 8 Nir Soffer 2017-01-02 09:57:26 UTC

(In reply to Daniel Erez from comment #7)
> @Nir - (In reply to Ondra Machacek from comment #6)
> > Hi Daniel,
> > 
> > This one is most important I think, I didn't encounter any other.
> 
> @Nir - do we have anything else to do in this case besides logging a warning?

I still do not understand this bug. We don't have any details about the error that
is not easy enough to debug without a traceback.

If we don't get more data we should close this bug. The attached patch should be
reverted.

Comment 9 Daniel Erez 2017-01-02 10:02:29 UTC

(In reply to Nir Soffer from comment #8)
> (In reply to Daniel Erez from comment #7)
> > @Nir - (In reply to Ondra Machacek from comment #6)
> > > Hi Daniel,
> > > 
> > > This one is most important I think, I didn't encounter any other.
> > 
> > @Nir - do we have anything else to do in this case besides logging a warning?
> 
> I still do not understand this bug. We don't have any details about the
> error that
> is not easy enough to debug without a traceback.
> 
> If we don't get more data we should close this bug. The attached patch
> should be
> reverted.

Closing. Please re-open if a traceback is mandatory for another error.

Comment 10 Ondra Machacek 2017-01-02 10:17:46 UTC

Feel free to keep it closed if you think the logging of the daemon is good, I've just opened this bug, because it was really hard to work with logs for me, but maybe it's just me, so it's OK if the bug is closed.