Bug 1402315 - VM MaxDiskSize is limited to 8191GB
Summary: VM MaxDiskSize is limited to 8191GB
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: General
Version: 4.0.5.5
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ovirt-4.1.0-beta
: 4.1.0.2
Assignee: Allon Mureinik
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-07 08:58 UTC by boruvka.michal
Modified: 2019-07-16 11:57 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:41:42 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)
disk size error (68.77 KB, image/jpeg)
2016-12-07 08:58 UTC, boruvka.michal
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github oVirt ovirt-site pull 644 0 None closed MaxDiskSize -> MaxDiskBlockSize 2020-07-06 06:40:39 UTC
oVirt gerrit 68114 0 master MERGED core: Add MaxBlockDiskSize to engine-config 2020-07-06 06:40:39 UTC

Description boruvka.michal 2016-12-07 08:58:17 UTC
Created attachment 1228938 [details]
disk size error

Description of problem:
I can't create disk with size greater then 8191GB. 

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. create disk with size 20480
2.
3.

Actual results:
in attachement

Expected results:


Additional info:

Comment 1 Yaniv Lavi 2016-12-08 13:35:48 UTC
This is controlled by a engine option that can be changed by engine-config tool (MaxDiskSize [1]). We do not test bigger disks and you will be entering to untested territory. You can try it out and see if this works for you.
We are not planning to change this, therefore closing.


[1] https://www.ovirt.org/develop/developer-guide/engine/engine-config-options/

Comment 2 Yaniv Lavi 2016-12-08 13:42:38 UTC
You can also open a RFE on this, but please provide the use case that requires this.

Comment 3 boruvka.michal 2016-12-08 19:20:48 UTC
Could you please help me. I cant set it ..

[root@ovm2 ~]# engine-config -g MaxDiskSize
Error fetching MaxDiskSize value: no such entry. Please verify key name and property file support.
[root@ovm2 ~]# engine-config -s MaxDiskSize=20480
Error setting MaxDiskSize's value. No such entry.

Comment 4 boruvka.michal 2016-12-09 11:37:52 UTC
In RHEV is limit 2147483648 GB ...

Comment 5 Sandro Bonazzola 2016-12-11 06:07:07 UTC
Modified is not the correct state for this bug, moving back to new since it has been reopened.

Can you please attach a full sos report?

Comment 6 Allon Mureinik 2016-12-11 08:22:28 UTC
(In reply to boruvka.michal from comment #3)
> Could you please help me. I cant set it ..
> 
> [root@ovm2 ~]# engine-config -g MaxDiskSize
> Error fetching MaxDiskSize value: no such entry. Please verify key name and
> property file support.
> [root@ovm2 ~]# engine-config -s MaxDiskSize=20480
> Error setting MaxDiskSize's value. No such entry.

The config value's name is MaxBlockDiskSize, and not MaxDiskSize as (wrongly) noted in comment 1.

I've created a pull request to fix the mistake in the site that mislead Yaniv:
https://github.com/oVirt/ovirt-site/pull/644

Comment 7 boruvka.michal 2016-12-11 10:25:36 UTC
(In reply to Allon Mureinik from comment #6)
> (In reply to boruvka.michal from comment #3)
> > Could you please help me. I cant set it ..
> > 
> > [root@ovm2 ~]# engine-config -g MaxDiskSize
> > Error fetching MaxDiskSize value: no such entry. Please verify key name and
> > property file support.
> > [root@ovm2 ~]# engine-config -s MaxDiskSize=20480
> > Error setting MaxDiskSize's value. No such entry.
> 
> The config value's name is MaxBlockDiskSize, and not MaxDiskSize as
> (wrongly) noted in comment 1.
> 
> I've created a pull request to fix the mistake in the site that mislead
> Yaniv:
> https://github.com/oVirt/ovirt-site/pull/644

I have got the same error with MaxBlockDiskSize.

[root@ovm2 ~]# engine-config -g MaxBlockDiskSize
Error fetching MaxBlockDiskSize value: no such entry. Please verify key name and property file support.

Comment 8 Allon Mureinik 2016-12-11 11:13:25 UTC
Sandro - this is a bug (or at least an inconsistency) in the tool. In the engine, many (most) config values don't have entries in the database, and the default is used from the code.
The engine-config tool doesn't use the regular engine's code, but reimplmenents its own DAOs, and thus can't handle keys that are only used with a default value that isn't in the database.
Moving to integration team to decide how (whether?) to handle this.

Comment 9 Yaniv Lavi 2016-12-11 11:50:25 UTC
For now you can change this in the engine DB in vdc_options as a workaround.

Comment 10 Allon Mureinik 2016-12-11 11:58:13 UTC
(In reply to Allon Mureinik from comment #8)
> Sandro - this is a bug (or at least an inconsistency) in the tool. In the
> engine, many (most) config values don't have entries in the database, and
> the default is used from the code.
> The engine-config tool doesn't use the regular engine's code, but
> reimplmenents its own DAOs, and thus can't handle keys that are only used
> with a default value that isn't in the database.
> Moving to integration team to decide how (whether?) to handle this.
This statement may have been premature. Even with such a key in the database, the tool doesn't seem to retrieve it.
Sandro, can someone from your team take a look at this? Either I'm being incredibly daft, or we have a nasty bug here.

Comment 11 Allon Mureinik 2016-12-11 14:35:20 UTC
Arg, that's daft of me. This property isn't registered in engine-config.properties. 
It's a trivial fix, although I'm not sure if we'd want to expose this to users. Yaniv - your call.

Comment 12 Yaniv Lavi 2016-12-11 14:42:54 UTC
(In reply to Allon Mureinik from comment #11)
> Arg, that's daft of me. This property isn't registered in
> engine-config.properties. 
> It's a trivial fix, although I'm not sure if we'd want to expose this to
> users. Yaniv - your call.

We should support that, since it is only the tested limit on the real limit.
User may want to do this as in the reporter use case.

Comment 13 boruvka.michal 2016-12-11 17:57:24 UTC
I have add to engine-config.properties these lines:
MaxBlockDiskSize.description="Max disk size"
MaxBlockDiskSize.type=Integer

and now engine-config works fine.

Thank you

Comment 14 Allon Mureinik 2016-12-11 18:29:53 UTC
(In reply to boruvka.michal from comment #13)
> I have add to engine-config.properties these lines:
> MaxBlockDiskSize.description="Max disk size"
> MaxBlockDiskSize.type=Integer
> 
> and now engine-config works fine.
> 
> Thank you
Yup, that's the trivial fix I meant in comment 11.
I've posted a patch to gerrit, see in the external references.

Comment 15 Raz Tamir 2017-01-17 14:18:17 UTC
Verified over ovirt-engine-4.1.0-0.4.master.20170116141310.gita30debd.el7.centos

[root@storage-ge-05 ~]# engine-config -g MaxBlockDiskSize
MaxBlockDiskSize: 8192 version: general

As expected


Note You need to log in before you can comment on or make changes to this bug.