Bug 1402644 - [virtio-win][qemu-ga-win]Error describtion is not clear with guest-sync-delimited command
Summary: [virtio-win][qemu-ga-win]Error describtion is not clear with guest-sync-delim...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: virtio-win
Version: 7.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Sameeh Jubran
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-08 02:47 UTC by xiagao
Modified: 2018-04-10 06:30 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-10 06:28:08 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0657 0 None None None 2018-04-10 06:30:38 UTC

Description xiagao 2016-12-08 02:47:45 UTC
Description of problem:
Error describtion is not clear when executing guest-sync-delimited command without id parameter

Version-Release number of selected component (if applicable):
host:
qemu-kvm-rhev-2.6.0-27.el7.x86_64

guest:
win2012-r2
virtio-win-1.9.0-3.el7.src.rpm
qemu guest agent 7.3.2-1


How reproducible:
100%

Steps to Reproduce:
1.Boot guest with virtio serial and install/start guest agent.
/usr/libexec/qemu-kvm -S -name avocado-vt-vm1 -nodefaults -vga std -m 3G -smp 4 -drive file=50fee0e6-9b31-4dd0-bd33-6ce8e0a3ef77,if=none,id=drive-ide0-0-0,format=raw,cache=none -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=0 -vnc :8 -rtc base=localtime,clock=host,driftfix=slew -boot order=cd,menu=on -enable-kvm -monitor stdio -qmp tcp:0:1238,server,nowait -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x7 -chardev socket,path=/tmp/qga.sock,server,nowait,id=qga0 -device virtserialport,bus=virtio-serial0.0,chardev=qga0,name=org.qemu.guest_agent.0 -netdev tap,id=hostnet0,vhost=on -device virtio-net-pci,netdev=hostnet0,id=net0,mac=00:1a:4a:16:01:56,bus=pci.0,addr=0x3 -drive file=/usr/share/virtio-win/virtio-win-1.9.0.iso,if=none,readonly=on,media=cdrom,format=raw,id=cdrom2 -device ide-drive,drive=cdrom2,bus=ide.1,unit=0,id=ide-cd2

2. Connect the chardev socket in host side for sending commands to guest:
# nc -U /tmp/qga.sock

3. Send  "guest-ping" command in the host side:
{"execute":"guest-ping"}
{"return": {}}


4. Send "guest-sync-delimited" command in the host side,but without id info:
{"execute":"guest-sync-delimited"}


Actual results:
{"error": {"desc": "Invalid parameter type, expected: integer"}}

Expected results:
{"error": {"class": "InvalidParameterType", "data": {"name": "id", "expected": "integer"}}}

Additional info:

Comment 2 Sameeh Jubran 2017-11-07 12:27:08 UTC
The error is much clearer now as we dropped the old qemu-ga-win win repository and moved to a qemu-ga-win that is built from upstream qemu (currently qemu 2.9.0).

{"error": {"class": "GenericError", "desc": "Parameter 'id' is missing"}}

I have created an official build, lets test it:
https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=14484052

Comment 3 xiagao 2017-11-10 08:32:08 UTC
Verify this bug on the following pkg:
qemu-ga-win-2.9.2-2.el7ev.noarch
qemu-kvm-rhev-2.9.0-16.el7.x86_64
virtio-win-1.9.3-1.el7.iso

1.Boot win10-64 guest with virtio serial and install/start guest agent.

2. Connect the chardev socket in host side for sending commands to guest:
# nc -U /tmp/qga.sock

3. Send  "guest-ping" command in the host side:
{"execute":"guest-ping"}
{"return": {}}


4. Send "guest-sync-delimited" command in the host side,but without id info:
{"execute":"guest-sync-delimited"}
{"error": {"class": "GenericError", "desc": "Parameter 'id' is missing"}}

The result is expected.

Comment 5 errata-xmlrpc 2018-04-10 06:28:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0657


Note You need to log in before you can comment on or make changes to this bug.