Hide Forgot
Spec URL: https://fedorapeople.org/~dcallagh/python-aiohttp-negotiate/python-aiohttp-negotiate.spec SRPM URL: https://fedorapeople.org/~dcallagh/python-aiohttp-negotiate/python-aiohttp-negotiate-0.11-1.fc26.src.rpm Description: A mixin for supporting Negotiate authentication with aiohttp. Fedora Account System Username: dcallagh
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Check is present, but package provides no tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-aiohttp-negotiate-0.11-1.fc24.noarch.rpm python-aiohttp-negotiate-0.11-1.fc24.src.rpm python3-aiohttp-negotiate.noarch: W: spelling-error %description -l en_US mixin -> mixing, mix in, mix-in python-aiohttp-negotiate.src: W: spelling-error %description -l en_US mixin -> mixing, mix in, mix-in 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python3-aiohttp-negotiate (rpmlib, GLIBC filtered): python(abi) python3-aiohttp python3-gssapi python3-www-authenticate Provides -------- python3-aiohttp-negotiate: python3-aiohttp-negotiate Source checksums ---------------- https://github.com/ox-it/aiohttp-negotiate/archive/0.11.tar.gz#/aiohttp-negotiate-0.11.tar.gz : CHECKSUM(SHA256) this package : e40a899dbd0d7218c53c9d6087950c2308929cdea09018ac8381eb95a38e0498 CHECKSUM(SHA256) upstream package : e40a899dbd0d7218c53c9d6087950c2308929cdea09018ac8381eb95a38e0498 https://raw.githubusercontent.com/danc86/aiohttp-negotiate/350ac51ba0ab0b871d39c975af27d027e35f514e/LICENSE : CHECKSUM(SHA256) this package : a8500cd72f262994f0466b991d745e2e25bc1ef83f9fc812f3b98fcede0ee012 CHECKSUM(SHA256) upstream package : a8500cd72f262994f0466b991d745e2e25bc1ef83f9fc812f3b98fcede0ee012 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1402675 Buildroot used: fedora-24-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 APPROVED
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-aiohttp-negotiate
python-www-authenticate-0.9.2-1.fc24 python-aiohttp-negotiate-0.11-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a80cdd6f1d
python-www-authenticate-0.9.2-1.fc25 python-aiohttp-negotiate-0.11-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-828303816d
python-www-authenticate-0.9.2-1.el7 python-aiohttp-negotiate-0.11-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7220d868a2
python-aiohttp-negotiate-0.11-1.fc25, python-www-authenticate-0.9.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-828303816d
python-aiohttp-negotiate-0.11-1.el7, python-www-authenticate-0.9.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7220d868a2
python-aiohttp-negotiate-0.11-1.fc24, python-www-authenticate-0.9.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a80cdd6f1d
python-aiohttp-negotiate-0.11-1.fc25, python-www-authenticate-0.9.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-aiohttp-negotiate-0.11-1.fc24, python-www-authenticate-0.9.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.