Bug 1402880 - Hot-plugged memory devices are wrongly reported
Summary: Hot-plugged memory devices are wrongly reported
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.2.0
: 4.2.0
Assignee: Milan Zamazal
QA Contact: Israel Pinto
URL:
Whiteboard:
Depends On:
Blocks: 1228543
TreeView+ depends on / blocked
 
Reported: 2016-12-08 14:24 UTC by jniederm
Modified: 2017-12-20 10:57 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-12-20 10:57:07 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.2+


Attachments (Terms of Use)
virsh-dumpxml (7.20 KB, text/plain)
2016-12-08 14:24 UTC, jniederm
no flags Details
engine-screenshot.png (59.15 KB, image/png)
2016-12-08 14:24 UTC, jniederm
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 69930 0 master MERGED virt: Update memory devices correctly 2017-01-24 15:43:47 UTC
oVirt gerrit 72078 0 ovirt-4.1 MERGED virt: Update memory devices correctly 2017-02-14 10:12:44 UTC

Description jniederm 2016-12-08 14:24:21 UTC
Created attachment 1229498 [details]
virsh-dumpxml

Description of problem:
Dimm devices are reported correct number of times but it is n-times the first hot-plugged dimm. I.e. reported address (and alias) doesn't differ. 


Version-Release number of selected component (if applicable):
4.1 master, dev build, commit 620c403

How reproducible:
100%

Steps to Reproduce:
1. Start a VM with small memory
2. Hot-plug memory several times
3. Compare dumpxml result of `virsh` on host with 'VM' > 'Vm Devices' subtab in webadmin (or content of vm_devices table) 

Actual results:
Addresses and aliases differs in virsh output however they don't differ in engine. All engine records corresponds to the first dimm in virsh report.

Expected results:
virsh and engine report same data.

Comment 1 jniederm 2016-12-08 14:24:58 UTC
Created attachment 1229499 [details]
engine-screenshot.png

Comment 2 jniederm 2016-12-09 11:53:20 UTC
We need reliable info about hot-pugged memory in engine in order to be able to request memory module unplug.

Comment 3 Milan Zamazal 2017-01-09 15:47:56 UTC
This is a Vdsm bug in matching the memory devices with domain XML output. I'll make a fix.

Comment 4 Israel Pinto 2017-08-15 07:05:17 UTC
Verify with:
Software version:4.2.0-0.0.master.20170813134654.gitaee967b.el7.centos

Steps:
1. Start a VM with small memory
2. Hot-plug memory several times with diff sizes
3. Compare dumpxml result of `virsh` on host with 'VM' > 'Vm Devices' subtab in webadmin (or content of vm_devices table) 

The address and aliases are the same - PASS

Comment 5 Sandro Bonazzola 2017-12-20 10:57:07 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.