Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1403152 - [AWS][SDN] - Cannot edit or create Cloud networks/subnets
[AWS][SDN] - Cannot edit or create Cloud networks/subnets
Status: CLOSED ERRATA
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS (Show other bugs)
5.7.0
Unspecified Unspecified
unspecified Severity urgent
: GA
: 5.8.0
Assigned To: Tzu-Mainn Chen
Ola Pavlenko
ui:sdn:amazon
: ZStream
Depends On:
Blocks: 1437148
  Show dependency treegraph
 
Reported: 2016-12-09 04:11 EST by Pavol Kotvan
Modified: 2018-02-13 02:47 EST (History)
7 users (show)

See Also:
Fixed In Version: 5.8.0.8
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1437148 (view as bug list)
Environment:
Last Closed: 2017-05-31 10:31:46 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: Bug
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: AWS


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2017:1367 normal SHIPPED_LIVE Moderate: CFME 5.8.0 security, bug, and enhancement update 2017-05-31 14:16:03 EDT

  None (edit)
Comment 4 Harpreet Kataria 2016-12-09 11:39:30 EST
Mainn,

Please send it back to me if this is not cloud networks/subnets specific bug.

Thanks,
~Harpreet
Comment 5 Tzu-Mainn Chen 2017-03-09 15:55:58 EST
Hi Hapreet!  I think this may be a generic UI bug, based on the following (definitely put it back my way if you think I'm wrong though)!

Looking at the cloud subnet edit button code, I see the following:

https://github.com/tzumainn/manageiq-ui-classic/blob/master/app/helpers/application_helper/toolbar/cloud_subnet_center.rb#L16

As far as I understand, that means the edit button should *only* be visible to those subnets whose model supports :update, as follows:

https://github.com/ManageIQ/manageiq/blob/master/app/models/manageiq/providers/openstack/network_manager/cloud_subnet.rb#L18

I've verified that the other providers' subnets do not have similar code - so if the button appears anyway, I think there may be something wrong with ApplicationHelper::Button::GenericFeatureButtonWithDisable
Comment 8 Tzu-Mainn Chen 2017-03-10 11:25:00 EST
This is partially fixed by https://github.com/ManageIQ/manageiq/pull/13096, which should be in a later 5.7 build.  We'll work on fixing the others.
Comment 9 Tzu-Mainn Chen 2017-03-10 11:43:14 EST
A backport of https://github.com/ManageIQ/manageiq/pull/12692 should fix the subnet creation issue, leaving only network creation/edit
Comment 10 Tzu-Mainn Chen 2017-03-10 14:31:02 EST
And https://github.com/ManageIQ/manageiq-ui-classic/pull/657 should fix the network issues.
Comment 12 CFME Bot 2017-03-16 15:16:11 EDT
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/46255b6198a229cb2b8b0ca5ea34bafc8f0ed516

commit 46255b6198a229cb2b8b0ca5ea34bafc8f0ed516
Author:     Tzu-Mainn Chen <tzumainn@redhat.com>
AuthorDate: Fri Mar 10 21:25:19 2017 +0100
Commit:     Tzu-Mainn Chen <tzumainn@redhat.com>
CommitDate: Fri Mar 10 21:26:10 2017 +0100

    Add SupportsFeatureMixin to CloudNetwork
    
    This is needed to allow non-OpenStack providers to filter out certain
    buttons in the UI.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1403152

 app/models/cloud_network.rb | 1 +
 1 file changed, 1 insertion(+)
Comment 13 CFME Bot 2017-03-28 04:02:58 EDT
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/84236b2f9d46ac9230b50799bcd65fc8b6b62de3

commit 84236b2f9d46ac9230b50799bcd65fc8b6b62de3
Author:     Tzu-Mainn Chen <tzumainn@redhat.com>
AuthorDate: Fri Mar 10 19:32:47 2017 +0100
Commit:     Tzu-Mainn Chen <tzumainn@redhat.com>
CommitDate: Fri Mar 10 21:08:14 2017 +0100

    Disable cloud network buttons if no provider supports it
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1403152

 .../application_helper/button/cloud_network_new.rb | 13 +++++++++
 .../toolbar/cloud_network_center.rb                |  9 ++++--
 .../toolbar/cloud_networks_center.rb               |  3 +-
 .../buttons/cloud_network_new_spec.rb              | 33 ++++++++++++++++++++++
 4 files changed, 55 insertions(+), 3 deletions(-)
 create mode 100644 app/helpers/application_helper/button/cloud_network_new.rb
 create mode 100644 spec/helpers/application_helper/buttons/cloud_network_new_spec.rb
Comment 14 Tzu-Mainn Chen 2017-03-28 09:56:44 EDT
https://github.com/ManageIQ/manageiq/pull/14392 also needed
Comment 16 Ronnie Rasouli 2017-05-11 08:18:57 EDT
verified on openstack network, edited the network name and set it as shared, tested on 5.8.0.13
Comment 18 errata-xmlrpc 2017-05-31 10:31:46 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1367

Note You need to log in before you can comment on or make changes to this bug.