Bug 1403353 - FTBFS: libspectre-0.2.7-8.fc25
Summary: FTBFS: libspectre-0.2.7-8.fc25
Alias: None
Product: Fedora
Classification: Fedora
Component: libspectre
Version: 25
Hardware: x86_64
OS: Linux
Target Milestone: ---
Assignee: Marek Kašík
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: BaseRuntimeFTBFS
TreeView+ depends on / blocked
Reported: 2016-12-09 19:18 UTC by Stephen Gallagher
Modified: 2016-12-14 21:30 UTC (History)
4 users (show)

Fixed In Version: libspectre-0.2.7-9.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2016-12-14 21:30:17 UTC
Type: Bug

Attachments (Terms of Use)
Patch to fix FTBFS (3.33 KB, patch)
2016-12-09 19:18 UTC, Stephen Gallagher
mkasik: review+
Details | Diff

Description Stephen Gallagher 2016-12-09 19:18:40 UTC
Created attachment 1230118 [details]
Patch to fix FTBFS

Description of problem:
When attempting to rebuild portions of the frozen package set of Fedora 25, we discovered that libspectre fails to build against newer versions of ghostscript.

Version-Release number of selected component (if applicable):

How reproducible:
Every time

Steps to Reproduce:
1. fedpkg clone libspectre
2. fedpkg switch-branch f25
3. fedpkg local

Actual results:
spectre-gs.c: In function 'critic_error_code':
spectre-gs.c:46:9: error: 'e_Fatal' undeclared (first use in this function)
    case e_Fatal:
spectre-gs.c:46:9: note: each undeclared identifier is reported only once for each function it appears in
spectre-gs.c:51:9: error: 'e_ExecStackUnderflow' undeclared (first use in this function)
    case e_ExecStackUnderflow:
spectre-gs.c: In function 'spectre_gs_process':
spectre-gs.c:112:20: error: 'e_NeedInput' undeclared (first use in this function)
   error = error == e_NeedInput ? 0 : error;
Makefile:437: recipe for target 'libspectre_la-spectre-gs.lo' failed

Expected results:
Successful build of the package.

Additional info:
This is needed as part of the Base Runtime effort. We are trying to minimize the possibility of churn from packaging changes post-F25 GA, so we would prefer to make a targeted build fix rather than unconditionally backporting from Rawhide unless both 1) no backwards-incompatible changes have occurred and 2) no new build- or runtime dependencies have appeared.

Please find attached a patch that pulls in an upstream fix for building against newer versions of ghostscript.

If you feel it is acceptable, please pull it in and commit it to dist-git. If you feel like you also want to backport the Rawhide version to F25, please commit this patch *first* and then a new set of patches to pull the new version (so that we can reference the specific git hash that fixes this issue). 

If you feel the patch is unacceptable, please respond before Dec. 22 with an explanation of why. If we hear no response before then, a provenpackager will make the change so that we can unblock the Base Runtime effort.

Comment 1 Marek Kašík 2016-12-12 14:06:59 UTC
Thank you for the patch. I've pushed it to F25 branch.

Comment 2 Fedora Update System 2016-12-12 14:09:37 UTC
libspectre-0.2.7-9.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-adb366bc38

Comment 3 Fedora Update System 2016-12-13 05:31:11 UTC
libspectre-0.2.7-9.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-adb366bc38

Comment 4 Fedora Update System 2016-12-14 21:30:17 UTC
libspectre-0.2.7-9.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.