Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/microdnf.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/microdnf-0-5.gitbb62334.fc26.src.rpm Description: Micor DNF. Fedora Account System Username: ignatenkobrain
Taking this review.
Overall, this looks great. However, there's one problem: > Release: 5.git%{shortcommit}%{?dist} This is not valid form, per the guidelines. Pre-release builds (that is, git snapshot builds like this one) need to have a release number less than 1. So, it should start with "0.1" or something like that.
Yes, prerelease versions must have a release beginning with 0.N. Snapshot releases must also include the date. 0.5.20161209git%{shortcommit}%{?dist} https://fedoraproject.org/wiki/Packaging:Versioning And the big cleanup I'm working on, which you may find clearer: https://fedoraproject.org/wiki/User:Tibbs/VersioningCleanup Just got a suggestion for clarifying this even further, so I'll be working on that more over the weekend.
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/microdnf.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/microdnf-1-1.fc26.src.rpm Jason, Neal, * IMO 0.X makes sense when Version != 0 * gitdate is completely useless (even is mandated guidelines) Given that I just released v1 in upstream to not have long and pointless discussion here.
Looks good to me. PACKAGE APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/microdnf