RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1403753 - Review request: puppet-curator
Summary: Review request: puppet-curator
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: trunk
Assignee: hguemar
QA Contact: hguemar
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-12 10:30 UTC by Alejandro Andreu
Modified: 2016-12-19 08:03 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-12-19 08:03:19 UTC
Embargoed:


Attachments (Terms of Use)

Description Alejandro Andreu 2016-12-12 10:30:28 UTC
In order for the puppet-logstash module to work together with MidoNet Analytics we also need to have puppet-curator.

puppet-curator will install and manage Elasticsearch Curator.

Project URL: https://github.com/tubemogul/puppet-curator

Comment 1 Javier Peña 2016-12-12 15:21:24 UTC
Initial licensecheck output:

$ licensecheck -r .
./spec/spec_helper_acceptance.rb: *No copyright* UNKNOWN
./spec/spec_helper.rb: *No copyright* UNKNOWN
./spec/defines/curator_cron_spec.rb: *No copyright* UNKNOWN
./spec/classes/curator_spec.rb: *No copyright* UNKNOWN
./spec/classes/coverage_spec.rb: *No copyright* UNKNOWN
./spec/acceptance/class_spec.rb: *No copyright* UNKNOWN
./Rakefile: *No copyright* UNKNOWN
./README.markdown: *No copyright* UNKNOWN
./LICENSE: *No copyright* Apache (v2.0) GENERATED FILE
./Guardfile: *No copyright* UNKNOWN
./Gemfile: *No copyright* UNKNOWN
./CONTRIBUTORS: *No copyright* UNKNOWN
./CONTRIBUTING.md: *No copyright* UNKNOWN
./CHANGELOG: *No copyright* UNKNOWN

The source is licensed using ASL 2.0, and the GitHub history does not show any apparent issue.

Comment 2 Javier Peña 2016-12-12 15:29:20 UTC
I have one concern about the module usage. If I understood it correctly, it does install elasticsearch-curator from pip, which can be an issue when combined with Python packages deployed via RPM packages, like TripleO does.

Would it be possible to achieve the same result using the elasticsearch-curator rpm? It is already packaged in Fedora.

Comment 3 Alejandro Andreu 2016-12-19 08:03:19 UTC
Hi Javier. What you suggested makes the most sense. I already submitted a list of changes to install Curator from the RPM so I'm closing this ticket off.

Related changes:
- https://review.openstack.org/#/c/410301/
- https://review.openstack.org/#/c/409862/
- https://review.rdoproject.org/r/#/c/4053/


Note You need to log in before you can comment on or make changes to this bug.