Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1404583

Summary:	Upcall: Possible use after free when log level set to TRACE
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	upcall	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.8	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.8.8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1404168	Environment:
Last Closed:	2017-01-16 12:27:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1404168
Bug Blocks:

Description Niels de Vos 2016-12-14 07:43:09 UTC

+++ This bug was initially created as a clone of Bug #1404168 +++

Description of problem:

While running few tests on NFS-Ganesa/Gluster cluster, Ravishankar(/itisravi) found that there is possible chance of use after free in upcall xlator when log level is set to TRACE. This happens when there are expired client entries to be cleaned up.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-12-13 10:30:36 CET ---

REVIEW: http://review.gluster.org/16117 (upcall: Fix 'use after free' in a log message) posted (#1) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2016-12-13 15:26:33 CET ---

REVIEW: http://review.gluster.org/16117 (upcall: Fix 'use after free' in a log message) posted (#2) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2016-12-13 15:48:45 CET ---

COMMIT: http://review.gluster.org/16117 committed in master by Niels de Vos (ndevos) 
------
commit 212c7600d2070a4414bc89fd7d2c186b5994cd54
Author: Soumya Koduri <skoduri>
Date:   Tue Dec 13 14:38:18 2016 +0530

    upcall: Fix 'use after free' in a log message
    
    There is chance of accessing freed pointer in a log message at TRACE
    level while cleaning up expired client entries.
    
    Change-Id: I06b4dad755df63978ab04ca52442bfd4600d139a
    BUG: 1404168
    Reported-by: Ravishankar N <ravishankar>
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/16117
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    Smoke: Gluster Build System <jenkins.org>

Comment 1 Worker Ant 2016-12-14 07:50:14 UTC

REVIEW: http://review.gluster.org/16128 (upcall: Fix 'use after free' in a log message) posted (#1) for review on release-3.8 by Niels de Vos (ndevos)

Comment 2 Worker Ant 2016-12-19 13:03:09 UTC

COMMIT: http://review.gluster.org/16128 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 4815730ba043bc0ccdebaa0650e35fd6f7947f3d
Author: Niels de Vos <ndevos>
Date:   Wed Dec 14 08:47:28 2016 +0100

    upcall: Fix 'use after free' in a log message
    
    There is chance of accessing freed pointer in a log message at TRACE
    level while cleaning up expired client entries.
    
    Cherry picked from commit 212c7600d2070a4414bc89fd7d2c186b5994cd54:
    > Change-Id: I06b4dad755df63978ab04ca52442bfd4600d139a
    > BUG: 1404168
    > Reported-by: Ravishankar N <ravishankar>
    > Signed-off-by: Soumya Koduri <skoduri>
    > Reviewed-on: http://review.gluster.org/16117
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Niels de Vos <ndevos>
    > Smoke: Gluster Build System <jenkins.org>
    
    Change-Id: I06b4dad755df63978ab04ca52442bfd4600d139a
    BUG: 1404583
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/16128
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: soumya k <skoduri>

Comment 3 Worker Ant 2016-12-21 23:22:25 UTC

REVIEW: http://review.gluster.org/16263 (upcall: Fix 'use after free' in a log message) posted (#1) for review on release-3.8-fb by Kevin Vigor (kvigor)

Comment 4 Niels de Vos 2017-01-16 12:27:19 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.8, please open a new bug report.

glusterfs-3.8.8 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2017-January/000064.html
[2] https://www.gluster.org/pipermail/gluster-users/