+++ This bug was initially created as a clone of Bug #1404168 +++ Description of problem: While running few tests on NFS-Ganesa/Gluster cluster, Ravishankar(/itisravi) found that there is possible chance of use after free in upcall xlator when log level is set to TRACE. This happens when there are expired client entries to be cleaned up. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: --- Additional comment from Worker Ant on 2016-12-13 10:30:36 CET --- REVIEW: http://review.gluster.org/16117 (upcall: Fix 'use after free' in a log message) posted (#1) for review on master by soumya k (skoduri) --- Additional comment from Worker Ant on 2016-12-13 15:26:33 CET --- REVIEW: http://review.gluster.org/16117 (upcall: Fix 'use after free' in a log message) posted (#2) for review on master by soumya k (skoduri) --- Additional comment from Worker Ant on 2016-12-13 15:48:45 CET --- COMMIT: http://review.gluster.org/16117 committed in master by Niels de Vos (ndevos) ------ commit 212c7600d2070a4414bc89fd7d2c186b5994cd54 Author: Soumya Koduri <skoduri> Date: Tue Dec 13 14:38:18 2016 +0530 upcall: Fix 'use after free' in a log message There is chance of accessing freed pointer in a log message at TRACE level while cleaning up expired client entries. Change-Id: I06b4dad755df63978ab04ca52442bfd4600d139a BUG: 1404168 Reported-by: Ravishankar N <ravishankar> Signed-off-by: Soumya Koduri <skoduri> Reviewed-on: http://review.gluster.org/16117 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos> Smoke: Gluster Build System <jenkins.org>
REVIEW: http://review.gluster.org/16129 (upcall: Fix 'use after free' in a log message) posted (#1) for review on release-3.7 by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/16129 committed in release-3.7 by Niels de Vos (ndevos) ------ commit 9eb9a82438ccce41b2c542093b969f39ddef25c0 Author: Niels de Vos <ndevos> Date: Wed Dec 14 08:47:28 2016 +0100 upcall: Fix 'use after free' in a log message There is chance of accessing freed pointer in a log message at TRACE level while cleaning up expired client entries. Cherry picked from commit 212c7600d2070a4414bc89fd7d2c186b5994cd54: > Change-Id: I06b4dad755df63978ab04ca52442bfd4600d139a > BUG: 1404168 > Reported-by: Ravishankar N <ravishankar> > Signed-off-by: Soumya Koduri <skoduri> > Reviewed-on: http://review.gluster.org/16117 > NetBSD-regression: NetBSD Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.org> > Reviewed-by: Niels de Vos <ndevos> > Smoke: Gluster Build System <jenkins.org> Change-Id: I06b4dad755df63978ab04ca52442bfd4600d139a BUG: 1404586 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/16129 NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: soumya k <skoduri>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.19, please open a new bug report. glusterfs-3.7.19 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://lists.gluster.org/pipermail/gluster-users/2017-January/029623.html [2] https://www.gluster.org/pipermail/gluster-users/