Bug 1404601
| Summary: | [engine-backend] Storage server connection removal fails after a storage domain creation failure | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Elad <ebenahar> | ||||
| Component: | Backend.Core | Assignee: | Tal Nisan <tnisan> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Elad <ebenahar> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.0.6.3 | CC: | bugs, tnisan, ylavi | ||||
| Target Milestone: | ovirt-4.1.0-beta | Keywords: | Regression | ||||
| Target Release: | 4.1.0.3 | Flags: | rule-engine:
ovirt-4.1+
ylavi: blocker- |
||||
| Hardware: | x86_64 | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-02-15 14:51:59 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP. Steps I did: 1. Destroyed an NFS storage domain 2. From the storage, cleaned the path content 3. Tried to add a new storage domain with the same connection details Storage domain creation succeeded. Used: rhevm-4.1.0.4-0.1.el7.noarch vdsm-4.19.4-1.el7ev.x86_64 |
Created attachment 1231502 [details] engine.log and vdsm.log Description of problem: When storage domain creation fails, engine performs roll-back to the operation and fails to remove the storage connection. It seems that no storage domain removal is being done as part of the failed storage domain creation roll-back. Version-Release number of selected component (if applicable): ovirt-engine-4.1.0-0.2.master.20161210231201.git26a385e.el7.centos.noarch vdsm-4.18.999-1147.git951e122.el7.centos.x86_64 How reproducible: Always Steps to Reproduce: 1. Remove or destroy an NFS storage domain. Do not format the domain, leave the domain data in the storage 2. Try to add a new storage domain with the same connection details Actual results: Storage domain creation fails because it's not empty as should be: 2016-12-14 10:23:02,920+02 INFO [org.ovirt.engine.core.vdsbroker.vdsbroker.CreateStorageDomainVDSCommand] (default task-7) [3515edb5] START, CreateStorageDomainVDSCommand(HostName = host1, CreateStorageDomainVDSCommandParameters:{runAsync='true', hostId='ea312772-52bd-47af-bd04-63097511fbda', storageDomain='StorageDomainStatic:{name='nfs1', id='9c8c04b5-326f-411d-acfd-7966a006 8e74'}', args='10.35.110.11:/Storage_NFS/elad/1'}), log id: 6fb8ed36 2016-12-14 10:23:05,082+02 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (default task-7) [3515edb5] Correlation ID: null, Call Stack: null, Custom Event ID: - 1, Message: VDSM host1 command failed: Storage domain is not empty - requires cleaning: ('10.35.110.11:/Storage_NFS/elad/1',) But then, storage connection removal fails: 2016-12-14 10:23:05,367+02 WARN [org.ovirt.engine.core.bll.storage.connection.RemoveStorageServerConnectionCommand] (default task-14) [17d96f84-257c-4960-8f4c-f4cd283d0f68] Validation of action 'RemoveStorageServerConnection' failed for user admin@internal-authz. Reasons: VAR__ACTION__REMOVE,VAR__TYPE__STORAGE__CONNECTION,$domainNames nfs1,ACTION_TYPE_FAILED_STORAGE_CONNECTION_BELONGS_TO_SEVERAL_STORAGE_DOMAINS The domain remains as 'unattached' in the system. It seems that the storage connection removal attempt is being done without storage domain removal first. Expected results: After a failure in storage domain creation, the connection and the domain should be removed successfully Additional info: engine.log and vdsm.log