Bug 1404607 - Force updateOVF does not update OVF store when Adding VM/Disk or removing disk (Only removing VM works)
Summary: Force updateOVF does not update OVF store when Adding VM/Disk or removing dis...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ovirt-4.1.3
: 4.1.3.3
Assignee: Maor
QA Contact: Avihai
URL:
Whiteboard:
: 1404565 (view as bug list)
Depends On:
Blocks: 1270562
TreeView+ depends on / blocked
 
Reported: 2016-12-14 08:56 UTC by Avihai
Modified: 2017-07-06 13:22 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-06 13:22:19 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)
engine & vdsm logs (host1 - HSM , host2 - SPM) (1.36 MB, application/x-gzip)
2016-12-14 08:56 UTC, Avihai
no flags Details
Full scenario logs (649.73 KB, application/x-gzip)
2016-12-14 10:03 UTC, Avihai
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 75608 0 master MERGED core: Print success audit log when action ends with success 2017-06-12 12:22:25 UTC
oVirt gerrit 76906 0 master MERGED core: refactor OVF_STORE update on deactivate 2017-06-12 12:21:57 UTC
oVirt gerrit 76907 0 master MERGED webadmin: Call UpdateOvfStoreForStorageDomain from webadmin 2017-06-12 12:22:17 UTC
oVirt gerrit 76908 0 master MERGED restapi: Call UpdateOvfStoreForStorageDomain from REST 2017-06-12 12:22:10 UTC
oVirt gerrit 78053 0 master MERGED core:Remove redundant parameter class. 2017-06-12 12:22:03 UTC
oVirt gerrit 78086 0 ovirt-engine-4.1 MERGED core:Remove redundant parameter class. 2017-06-12 15:26:33 UTC
oVirt gerrit 78087 0 ovirt-engine-4.1 MERGED core: refactor OVF_STORE update on deactivate 2017-06-12 15:26:41 UTC
oVirt gerrit 78088 0 ovirt-engine-4.1 MERGED restapi: Call UpdateOvfStoreForStorageDomain from REST 2017-06-12 15:26:50 UTC
oVirt gerrit 78089 0 ovirt-engine-4.1 MERGED webadmin: Call UpdateOvfStoreForStorageDomain from webadmin 2017-06-12 15:26:58 UTC
oVirt gerrit 78090 0 ovirt-engine-4.1 MERGED core: Print success audit log when action ends with success 2017-06-12 15:27:06 UTC

Description Avihai 2016-12-14 08:56:38 UTC
Created attachment 1231519 [details]
engine & vdsm logs (host1 - HSM , host2 - SPM)

Description of problem:
WebGUI&API Force updateOVF does not update VM with disk

Version-Release number of selected component (if applicable):
OVF store of the NFS doamin should be updated  & ovf file should be there with disk info in it .

How reproducible:
100%

Setup :
1 DC 
1 cluster (C1)
2 Hosts in cluster C1 ( Host1 - HSM , Host2 - SPM ) 
3 storage domains (NFS , gluster , iscsi)

Steps to Reproduce:

1. Can be reproduced creating ONLY 1 SD .

2. Scedualed updateOVF initiated to avoid bug 1403581 ( last update was 2016-12-14 07:46:23)

3. Create a VM1 without disks (VM is down)  .

4. Force updateOVF on the NFS storage domain -> OVF not updated (bug 1404565)

5. Scedualed updateOVF initiated - VM updated & OVF created 

6. Remove VM1 . 

7. Initiated  force updateOVF on the NFS storage domain (Dec 14, 2016
8:57:37 AM- OVF_STORE for domain nfs_dom was updated )

9. Check OVF store of NFS domain -> indeed OVF file removed as expected .

10. Add disk (NFS domain iscsi bootable) to VM1  (EVENT LOG : Dec 14, 2016 9:17:10 AM -The disk VM1_Disk1 was successfully added to VM VM1)

11. update  initiated  force updateOVF via API (Dec 14, 2016 9:20:29 AM)  on the NFS storage domain - (Dec 14, 2016 9:26:54 AM )  	

12.check OVF file 



Actual results:
OVF store of the NFS domain seems to be updated by engine & VDSM logs BUT OVF is not update with neither VM or disk info .


Expected results:
OVF store of the NFS doamin should be updated  & ovf file should be there with disk info in it .


Additional info:
1.It looks like even after scheduled OVF store update .
2.VM was in down state .
3.After the Next scheduled OVF update OVF store updated as expected .

Comment 1 Avihai 2016-12-14 08:57:38 UTC
correction -> Version-Release number of selected component (if applicable):
oVirt Engine Version: 4.1.0-0.2.master.20161212172238.gitea103bd.el7.centos

Comment 2 Avihai 2016-12-14 09:29:53 UTC
I tried also to add an additional disk VM1_Disk2(the first disk was VM1_Disk1 ) & force updateOVF but I do not see its updated .

In conclusion:

What Works :
Remove VM 

Not Working :
1)If not schedualed update Nothing works !  - bug

2) After schedualed update , modify VM/disk + force update:

- create VM No disk - bug #1404565 ( you can 
-  create VM +disk (or 2disks) - bug
-  delete disk from VM

Comment 3 Avihai 2016-12-14 09:44:10 UTC
(In reply to Avihai from comment #2)
> I tried also to add an additional disk VM1_Disk2(the first disk was
> VM1_Disk1 ) & force updateOVF but I do not see its updated .
> 
> In conclusion:
> 
> What Works :
> Remove VM 
> 
> Not Working :
> 1)If not scheduled update Nothing works !  - bug
> 
> 2) After scheduled update , modify VM/disk + force update:
> 
> - create VM No disk - bug #1404565 ( you can 
> -  create VM +disk (or 2disks) - bug
> -  delete disk from VM

Last info missed some bug id's so this is the corrected version :
Works (meaning OVF store content is updated) :
Remove VM 

Not Working (meaning OVF store content is NOT updated) :
1)If not scheduled update Nothing works !  - bug 1403581

2) After scheduled update , modify VM/disk + force update:

- create VM No disk - bug #1404565 
-  create VM +disk (or 2disks) - bug
-  delete disk from VM

Comment 4 Avihai 2016-12-14 10:03:45 UTC
Created attachment 1231574 [details]
Full scenario logs

This logs correlate to this full scenario from clean configuration including all issues found .

Setup :
1 DC 
1 cluster (C1)
2 Hosts in cluster C1 ( Host1 - HSM , Host2 - SPM ) 
3 storage domains (NFS , gluster , iscsi)

Steps to Reproduce:

1. Can be reproduced creating ONLY 1 SD .

2. Scedualed updateOVF initiated to avoid bug 1403581 ( last update was 2016-12-14 07:46:23)

3. Create a VM1 without disks (VM is down)  .

4. Force updateOVF on the NFS storage domain -> OVF not updated (bug 1404565)

5. Scedualed updateOVF initiated - VM updated & OVF created 

6. Remove VM1 . 

7. Initiated  force updateOVF on the NFS storage domain (Dec 14, 2016
8:57:37 AM- OVF_STORE for domain nfs_dom was updated )

9. Check OVF store of NFS domain -> indeed OVF file removed as expected .

10. Add disk (VM1_Disk1 ,NFS domain iscsi bootable) to VM1  (EVENT LOG : Dec 14, 2016 9:17:10 AM -The disk VM1_Disk1 was successfully added to VM VM1)

11. update  initiated  force updateOVF via API (Dec 14, 2016 9:20:29 AM)  on the NFS storage domain - (Dec 14, 2016 9:26:54 AM )  	

12.check OVF file -> Not update (opened bug XXX) 

13. schedualed OVF (Dec 14, 2016 9:46 AM) -> OVF updated

14.added another disk (VM1_Disk2 ) from the same SD(NFS)

15. update  initiated  force updateOVF (Dec 14, 2016 11:02:21) 

16.check OVF file  -> Not jupdate 

17. delete both Disks 

18. update  initiated  force updateOVF (Dec 14, 2016 11:11:28) 

19.check OVF file  -> OVF NOT UPDATED !

Comment 5 Avihai 2016-12-14 11:20:17 UTC
Tal , you can aggregate/dup both bugs ( #1404565 , #1403581 ) to this bug as they are all with the same issue & solve it there .

Comment 6 Yaniv Kaul 2016-12-14 16:08:17 UTC
Why is it high severity? Reduced to Medium, unless I can understand the context.

Comment 7 Avihai 2016-12-14 17:38:01 UTC
(In reply to Yaniv Kaul from comment #6)
> Why is it high severity? Reduced to Medium, unless I can understand the
> context.

This bug aggregates both bug #1404565 & bug #1403581( which is also in high priority ) as it looks the source problem (modify VM/disk not updating OVF store) is the same .

This means that most of force OVF feature ( RFE bug #1270562) does not work .

IMHO a customer not having force OVF backup means the following & looks like high severity to me for the following reasons :

1) No REAL VM backup/export + import storage domain not working properly for the first hour as OVF's are not updated when the costumer needs it .(until scheduled OVF update occurs which is a very disruptive workaround) 

2) Even after scheduled OVF update occurs the costumer can not update OVF store until the next scheduled update , meaning OVF store is not updated for 1H interval .

This means import storage domain + VM backup/export will be not relevant if any changes were made until next scheduled OVF update and if the costumer will try to import storage domain + VM backup/export he will have a stale version then he expected .

3) If faulty scheduled OVF update occurs there is no way to recouperate from it except waiting for an entire hour until next scheduled OVF .

Comment 8 Yaniv Kaul 2016-12-15 06:26:34 UTC
*** Bug 1404565 has been marked as a duplicate of this bug. ***

Comment 9 Yaniv Lavi 2017-02-23 11:25:12 UTC
Moving out all non blocker\exceptions.

Comment 10 Yaniv Kaul 2017-06-01 07:49:26 UTC
(In reply to Yaniv Dary from comment #9)
> Moving out all non blocker\exceptions.

Same, now moving to 4.1.4.

Comment 11 Allon Mureinik 2017-06-20 09:57:09 UTC
All these patches are included in 4.1.3.3

Comment 12 Avihai 2017-06-25 10:35:05 UTC
verified at 4.1.3.4


Note You need to log in before you can comment on or make changes to this bug.