Bug 1404674 - [engine-webadmin] 'Use Host' drop down is not highlighted when committing storage domain creation for a DC with no active hosts
Summary: [engine-webadmin] 'Use Host' drop down is not highlighted when committing sto...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.0
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.1.0-beta
: 4.1.0.2
Assignee: Alexander Wels
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-14 12:10 UTC by Elad
Modified: 2017-02-01 14:50 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:50:18 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)
screenshot from webadmin (29.02 KB, image/png)
2016-12-14 12:10 UTC, Elad
no flags Details
New Cluster modal (51.35 KB, image/png)
2016-12-14 16:13 UTC, Benny Zlotnik
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 68665 0 master MERGED webadmin: Bootstrap layout storage popup 2017-01-05 18:46:33 UTC
oVirt gerrit 70581 0 ovirt-engine-4.1 MERGED webadmin: Bootstrap layout storage popup 2017-01-16 16:07:06 UTC

Description Elad 2016-12-14 12:10:39 UTC
Created attachment 1231644 [details]
screenshot from webadmin

Description of problem:
Webadmin: In a DC with no active hosts, when trying to commit a storage domain creation, the 'Use Host' drop down field is not highlighted upon commit.

Version-Release number of selected component (if applicable):
ovirt-engine-4.1.0-0.2.master.20161210231201.git26a385e.el7.centos.noarch
ovirt-engine-webadmin-portal-4.1.0-0.2.master.20161210231201.git26a385e.el7.centos.noarch
ovirt-web-ui-0.1.0-4.el7.centos.x86_64


How reproducible:
Always

Steps to Reproduce:
1. Try to create a storage domain in a DC with no active hosts


Actual results:
'Use Host' field is not highlighted

Expected results:
'Use Host' field should get highlighted if there are no active hosts in the DC


Additional info:
screenshot from webadmin

Comment 1 Benny Zlotnik 2016-12-14 16:13:14 UTC
Created attachment 1231789 [details]
New Cluster modal

Comment 2 Benny Zlotnik 2016-12-14 16:18:12 UTC
It appears that in the "New Cluster" window the CPU Type dropdown is being highlighted correctly as seen in the screenshot. The difference between the two dropdowns is that the one in the New Domain window is not using patternfly. But after being marked as invalid in StorageModel#validate the "Use Host" dropdown does get a "border-color: red" style attribute which cannot be seen for some reason without manually adding "border: 1px solid"

What would be the suggested course of action?

Comment 3 Greg Sheremeta 2016-12-15 16:34:37 UTC
I'm not sure why it's not working. Afaik, they both use the new PatternFly selects that Alexander implemented. I'd say this is a UX bug. Moving to Alexander.

Comment 4 Alexander Wels 2017-01-06 14:00:30 UTC
I updated the dialog to be bootstrap based layout which also fixed this issue (I did that anyway for something else, so happy coincidence).

Comment 5 Jiri Belka 2017-01-12 12:12:52 UTC
fail, ovirt-engine-webadmin-portal-4.1.0-0.4.master.20170111151514.git3d62579.el7.centos.noarch

host field does not have red border which would infor user for need to have a host in the DC

Comment 7 Lucie Leistnerova 2017-01-26 15:29:13 UTC
trying create storage with no host changes 'Host to Use' border and title to red

verified in ovirt-engine-webadmin-portal-4.1.0.2-0.1.el7.noarch


Note You need to log in before you can comment on or make changes to this bug.