Created attachment 1231758 [details] Fix FTBFS on Fedora 25 Description of problem: When attempting to rebuild portions of the frozen package set of Fedora 25, we discovered that python-service-identity fails to build due to pyOpenSSL 16.x no longer exposing the OpenSSL.test.util api. Version-Release number of selected component (if applicable): python-service-identity-14.0.0-4.fc25 How reproducible: Every time Steps to Reproduce: 1. fedpkg clone python-service-identity 2. fedpkg switch-branch f25 3. fedpkg mock-build Actual results: tests/test_common.py .......................................................... ==================================== ERRORS ==================================== ___________________ ERROR collecting tests/test_pyopenssl.py ___________________ tests/test_pyopenssl.py:3: in <module> from OpenSSL.test.util import TestCase E ImportError: No module named test.util ___________________ ERROR collecting tests/test_pyopenssl.py ___________________ tests/test_pyopenssl.py:3: in <module> from OpenSSL.test.util import TestCase E ImportError: No module named test.util ================ 58 passed, 10 skipped, 2 error in 0.24 seconds ================ error: Bad exit status from /var/tmp/rpm-tmp.dHeyPW (%check) Bad exit status from /var/tmp/rpm-tmp.dHeyPW (%check) RPM build errors: Child return code was: 1 Expected results: Successful build of the package. Additional info: This is needed as part of the Base Runtime effort. We are trying to minimize the possibility of churn from packaging changes post-F25 GA, so we would prefer to make a targeted build fix rather than unconditionally backporting from Rawhide unless both 1) no backwards-incompatible changes have occurred and 2) no new build- or runtime dependencies have appeared. In the case of python-service-identity, it has been rebased in Rawhide to 16.x and requires a new build dependency: python-attrs. Please find attached a patch that just removes the pyOpenSSL test so that the package builds successfully. If you feel it is acceptable, please pull it in and commit it to dist-git. If you feel like you also want to update the F25 version to the 16.x release, please commit this patch *first* and then a new set of patches to pull the new version (so that we can reference the specific git hash that fixes this issue). If you feel the patch is unacceptable, please respond before Dec. 22 with an explanation of why. If we hear no response before then, a provenpackager will make the change so that we can unblock the Base Runtime effort.
I pushed the patch to git (for base runtime to pick up), but didn't run a build.