Spec file: https://raw.githubusercontent.com/oglok/python-networking-l2gw/master/python-networking-l2gw.spec SRPM file: https://github.com/oglok/python-networking-l2gw/raw/master/python-networking-l2gw-2016.1.1-0.20161214124701.deb7ad9.el7.centos.src.rpm Description: Neutron driver for L2GW
New files: Spec file: https://raw.githubusercontent.com/oglok/python-networking-l2gw/master/python-networking-l2gw.spec SRPM file: https://github.com/oglok/python-networking-l2gw/raw/master/python-networking-l2gw-2016.1.1-0.20161216151453.c2a04cd.el7.centos.src.rpm
Initial licensecheck output: $ licensecheck -r . ./tools/tox_install.sh: *No copyright* UNKNOWN ./tools/pretty_tox_serial.sh: *No copyright* UNKNOWN ./setup.py: Apache (v2.0) GENERATED FILE ./networking_l2gw/tests/unit/services/l2gateway/test_plugin.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/test_agent_scheduler.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/service_drivers/test_rpc_l2gw.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/service_drivers/test_agent_api.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/ovsdb/test_data.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/common/test_tunnel_calls.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/common/test_l2gw_validators.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/agent/test_l2gw_agent.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/agent/test_base_agent_manager.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/agent/test_agent_api.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/agent/ovsdb/test_ovsdb_writer.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/agent/ovsdb/test_ovsdb_monitor.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/agent/ovsdb/test_manager.py: Apache (v2.0) ./networking_l2gw/tests/unit/services/l2gateway/agent/ovsdb/test_base_connection.py: Apache (v2.0) ./networking_l2gw/tests/unit/l2gatewayclient/test_cli20_l2gw_ext.py: Apache (v2.0) ./networking_l2gw/tests/unit/l2gatewayclient/test_cli20_l2gw_conn_ext.py: Apache (v2.0) ./networking_l2gw/tests/unit/l2gatewayclient/test_cli20.py: *No copyright* Apache (v2.0) ./networking_l2gw/tests/unit/db/test_migrations.py: *No copyright* Apache (v2.0) ./networking_l2gw/tests/unit/db/test_l2gw_db.py: Apache (v2.0) ./networking_l2gw/tests/unit/db/ovsdb/test_lib.py: Apache (v2.0) ./networking_l2gw/tests/unit/db/ovsdb/test_idl_impl.py: Apache (v2.0) ./networking_l2gw/tests/tempest/config.py: Apache (v2.0) ./networking_l2gw/tests/scenario/test_l2gateways.py: Apache (v2.0) ./networking_l2gw/tests/scenario/ovsdb_connections.py: Apache (v2.0) ./networking_l2gw/tests/fullstack/test_l2gw.py: *No copyright* Apache (v2.0) ./networking_l2gw/tests/contrib/post_test_hook.sh: *No copyright* UNKNOWN ./networking_l2gw/tests/contrib/gate_hook.sh: *No copyright* UNKNOWN ./networking_l2gw/tests/api/test_l2gw_negative.py: Apache (v2.0) ./networking_l2gw/tests/api/test_l2gw_extensions.py: Apache (v2.0) ./networking_l2gw/tests/api/base_l2gw.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/service_drivers/rpc_l2gw.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/service_drivers/agent_api.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/service_drivers/__init__.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/plugin.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/ovsdb/data.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/l2gw_agent.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/exceptions.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/common/tunnel_calls.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/common/topics.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/common/ovsdb_schema.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/common/l2gw_validators.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/common/constants.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/common/config.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent_scheduler.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/ovsdb_writer.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/ovsdb_monitor.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/ovsdb_model.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/ovsdb_common_class.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/native/connection.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/native/commands.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/manager.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/impl_idl.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/base_connection.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/ovsdb/api.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/l2gateway_config.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/base_agent_manager.py: Apache (v2.0) ./networking_l2gw/services/l2gateway/agent/agent_api.py: Apache (v2.0) ./networking_l2gw/l2gatewayclient/l2gw_client_ext/_l2_gateway_connection.py: Apache (v2.0) ./networking_l2gw/l2gatewayclient/l2gw_client_ext/_l2_gateway.py: Apache (v2.0) ./networking_l2gw/extensions/l2gatewayconnection.py: Apache (v2.0) ./networking_l2gw/extensions/l2gateway.py: Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/versions/start_networking_l2gw.py: Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/versions/newton/expand/49ce408ac349_add_indexes_to_tenant_id.py: *No copyright* Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/versions/newton/contract/2f533f7705dd_rename_tenant_to_project.py: Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/versions/liberty/expand/60019185aa99_initial_expand.py: *No copyright* Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/versions/liberty/contract/79919185aa99_initial_contract.py: *No copyright* Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/versions/kilo_release.py: *No copyright* Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/versions/EXPAND_HEAD: *No copyright* UNKNOWN ./networking_l2gw/db/migration/alembic_migrations/versions/CONTRACT_HEAD: *No copyright* UNKNOWN ./networking_l2gw/db/migration/alembic_migrations/versions/54c9c8fe22bf_db_models_for_ovsdb_hardware_vtep_schema.py: Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/versions/42438454c556_l2gateway_models.py: Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/env.py: Apache (v2.0) ./networking_l2gw/db/migration/alembic_migrations/README: *No copyright* UNKNOWN ./networking_l2gw/db/l2gateway/ovsdb/models.py: Apache (v2.0) ./networking_l2gw/db/l2gateway/ovsdb/lib.py: Apache (v2.0) ./networking_l2gw/db/l2gateway/l2gateway_models.py: Apache (v2.0) ./networking_l2gw/db/l2gateway/l2gateway_db.py: Apache (v2.0) ./networking_l2gw/db/l2gateway/head.py: *No copyright* Apache (v2.0) ./networking_l2gw/db/l2gateway/db_query.py: Apache (v2.0) ./networking_l2gw/cmd/eventlet/agent.py: Apache (v2.0) ./networking_l2gw/cmd/eventlet/__init__.py: Apache (v2.0) ./networking_l2gw/_i18n.py: *No copyright* Apache (v2.0) ./networking_l2gw/__init__.py: *No copyright* Apache (v2.0) ./doc/source/conf.py: Apache (v2.0) ./devstack/settings: *No copyright* UNKNOWN ./devstack/plugin.sh: *No copyright* UNKNOWN ./devstack/devstackgaterc: *No copyright* Apache (v2.0) ./debian/rules: *No copyright* UNKNOWN ./debian/control: *No copyright* UNKNOWN ./debian/compat: *No copyright* UNKNOWN ./debian/changelog: *No copyright* UNKNOWN ./contrib/install_l2gateway_agent.sh: Apache (v2.0) ./contrib/install_and_config_l2gateway_plugin.sh: Apache (v2.0) ./LICENSE: *No copyright* GENERATED FILE The module is licensed with Apache 2.0.
Just as a reminder, we need formal reviews not just license check (puppet-xxx are an exception)
(In reply to Haïkel Guémar from comment #3) > Just as a reminder, we need formal reviews not just license check > (puppet-xxx are an exception) This is not what I understood from previous discussions. We were supposed to refine the spec during the Gerrit review, then approve here once they're ready (and always before merging the last rdoinfo change). We may need to clarify this (and properly document it in https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk) to avoid future misunderstandings.
@jpena: agreed, this is confusing for every one. I was asking just to ensure that we have proper formal reviews published and avoid lawyers slapping our wrists for not doing them. :) I just did it since rnoriega pinged me. --- I manually reviewed files without proper licensing and they are ok with upstream licensing guidelines. I hereby approve this package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 20 files have unknown license. Detailed output of licensecheck in /home/haikel/1404754-python-networking-l2gw/srpm /review-python-networking-l2gw/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /etc/neutron [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /etc/neutron, /usr/lib/systemd [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -networking-l2gw , python-networking-l2gw-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Yes, that's overridden by DLRN, nothing unusual [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define upstream_version 2016.1.1.dev108 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-networking-l2gw-2016.1.1-0.20161216151453.c2a04cd.el7.noarch.rpm python-networking-l2gw-doc-2016.1.1-0.20161216151453.c2a04cd.el7.noarch.rpm python-networking-l2gw-tests-2016.1.1-0.20161216151453.c2a04cd.el7.noarch.rpm python-networking-l2gw-2016.1.1-0.20161216151453.c2a04cd.el7.src.rpm python2-networking-l2gw.noarch: W: spelling-error Summary(en_US) API's -> A Pi's, AP's, AI's python2-networking-l2gw.noarch: E: no-changelogname-tag python2-networking-l2gw.noarch: W: non-etc-or-var-file-marked-as-conffile /usr/bin/neutron-l2gateway-agent python2-networking-l2gw.noarch: W: no-documentation python2-networking-l2gw.noarch: W: non-standard-gid /etc/neutron/l2gw_plugin.ini neutron python2-networking-l2gw.noarch: E: non-readable /etc/neutron/l2gw_plugin.ini 640 python2-networking-l2gw.noarch: W: non-standard-gid /etc/neutron/l2gateway_agent.ini neutron python2-networking-l2gw.noarch: E: non-readable /etc/neutron/l2gateway_agent.ini 640 python2-networking-l2gw.noarch: W: non-standard-gid /usr/bin/neutron-l2gateway-agent neutron python2-networking-l2gw.noarch: W: non-executable-in-bin /usr/bin/neutron-l2gateway-agent 640 python2-networking-l2gw.noarch: E: non-readable /usr/bin/neutron-l2gateway-agent 640 python2-networking-l2gw.noarch: E: non-executable-script /usr/bin/neutron-l2gateway-agent 640 /usr/bin/python2 python-networking-l2gw-doc.noarch: W: summary-not-capitalized C networking-l2gw documentation python-networking-l2gw-doc.noarch: E: no-changelogname-tag python-networking-l2gw-doc.noarch: W: spurious-executable-perm /usr/share/doc/python-networking-l2gw-doc-2016.1.1/README.rst python-networking-l2gw-tests.noarch: W: summary-not-capitalized C networking-l2gw tests python-networking-l2gw-tests.noarch: E: no-changelogname-tag python-networking-l2gw-tests.noarch: W: no-documentation python-networking-l2gw-tests.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/networking_l2gw/tests/contrib/post_test_hook.sh /usr/bin/env bash python-networking-l2gw-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/networking_l2gw/tests/contrib/post_test_hook.sh 644 /usr/bin/env bash python-networking-l2gw-tests.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/networking_l2gw/tests/contrib/gate_hook.sh /usr/bin/env bash python-networking-l2gw-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/networking_l2gw/tests/contrib/gate_hook.sh 644 /usr/bin/env bash python-networking-l2gw.src: W: spelling-error Summary(en_US) API's -> A Pi's, AP's, AI's python-networking-l2gw.src: E: no-changelogname-tag python-networking-l2gw.src: W: invalid-url Source0: networking-l2gw-2016.1.1.dev108-0.20161216151453.c2a04cd.tar.gz 4 packages and 0 specfiles checked; 12 errors, 13 warnings. Rpmlint (installed packages) ---------------------------- python-networking-l2gw-doc.noarch: W: summary-not-capitalized C networking-l2gw documentation python-networking-l2gw-doc.noarch: E: no-changelogname-tag python-networking-l2gw-doc.noarch: W: invalid-url URL: http://www.openstack.org/ <urlopen error [Errno -2] Name or service not known> python-networking-l2gw-doc.noarch: W: spurious-executable-perm /usr/share/doc/python-networking-l2gw-doc-2016.1.1/README.rst python2-networking-l2gw.noarch: E: no-changelogname-tag python2-networking-l2gw.noarch: W: invalid-url URL: http://www.openstack.org/ <urlopen error [Errno -2] Name or service not known> python2-networking-l2gw.noarch: W: non-etc-or-var-file-marked-as-conffile /usr/bin/neutron-l2gateway-agent python2-networking-l2gw.noarch: W: no-documentation python2-networking-l2gw.noarch: W: non-standard-gid /etc/neutron/l2gateway_agent.ini neutron python2-networking-l2gw.noarch: E: non-readable /etc/neutron/l2gateway_agent.ini 0640L python2-networking-l2gw.noarch: W: non-standard-gid /usr/bin/neutron-l2gateway-agent neutron python2-networking-l2gw.noarch: W: non-executable-in-bin /usr/bin/neutron-l2gateway-agent 0640L python2-networking-l2gw.noarch: E: non-readable /usr/bin/neutron-l2gateway-agent 0640L python2-networking-l2gw.noarch: E: non-executable-script /usr/bin/neutron-l2gateway-agent 0640L /usr/bin/python2 python2-networking-l2gw.noarch: W: non-standard-gid /etc/neutron/l2gw_plugin.ini neutron python2-networking-l2gw.noarch: E: non-readable /etc/neutron/l2gw_plugin.ini 0640L python-networking-l2gw-tests.noarch: W: summary-not-capitalized C networking-l2gw tests python-networking-l2gw-tests.noarch: E: no-changelogname-tag python-networking-l2gw-tests.noarch: W: invalid-url URL: http://www.openstack.org/ <urlopen error [Errno -2] Name or service not known> python-networking-l2gw-tests.noarch: W: no-documentation python-networking-l2gw-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/networking_l2gw/tests/contrib/post_test_hook.sh 0644L /usr/bin/env python-networking-l2gw-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/networking_l2gw/tests/contrib/gate_hook.sh 0644L /usr/bin/env 3 packages and 0 specfiles checked; 9 errors, 13 warnings. Requires -------- python-networking-l2gw-doc (rpmlib, GLIBC filtered): python2-networking-l2gw (rpmlib, GLIBC filtered): /usr/bin/python2 config(python2-networking-l2gw) python(abi) python-babel python-neutron-lib python-neutronclient python-pbr python-setuptools python-networking-l2gw-tests (rpmlib, GLIBC filtered): python(abi) python-networking-l2gw Provides -------- python-networking-l2gw-doc: python-networking-l2gw-doc python2-networking-l2gw: config(python2-networking-l2gw) python-networking-l2gw python2-networking-l2gw python-networking-l2gw-tests: python-networking-l2gw-tests Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n python-networking-l2gw -m rdo-mitaka-el7 Buildroot used: cloud7-openstack-mitaka-el7-build Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
This landed, closing.